Prevent an error when the first argument of import is a template

[fatfisz]

Fixes one of the problems described in #4433.

The handle-import plugin can't deal with webpack's dynamic imports. Before this change an unhelpful error was appearing in the console and the build was broken. The change ignores such imports altogether, resulting in no error.

Handling template literals by Next.js can be added later on, but maybe it would be better done through a webpack plugin instead of a babel one.

[timneutkens]

Should this actually throw a helpful error then 🤔

Besides that, it looks good 🙏

[fatfisz]

For now I'd appreciate it if there was no error - otherwise I'd need to disable the plugin completely. Next.js will work with this almost fine - the chunks just won't be marked as used on the server side. This seems to be an obscure scenario anyway, so maybe adding a note that glob imports are not fully supported yet (but won't break the build) will suffice?

I'll continue working on patching Webpack in an even better way so that maybe in the future the Babel plugin can be replaced completely with a Webpack one.

[timneutkens]

What I'm not following is why'd you want to make something that doesn't function work without compilation errors 🤔 Wouldn't that make it even worse for people that don't know it doesn't work use it 🤔

[fatfisz]

Ok, fair point. While I made it work somehow and it almost works out of the box, it might not be a good user experience. I'll disable the plugin for now and maybe come back to this later (though in a Webpack plugins incarnation).

[morgs32]

@fatfisz you break ground on the webpack plugin? Interested in helping.

[fatfisz]

I've actually managed to do what I needed, you can explore the results here: https://github.com/fatfisz/burdoc/tree/master/src/BurdocWebpackPlugin.

In a nutshell, I disable the handle-imports Next.js Babel plugin entirely, and instead I patch Webpack internals.

It goes something like this:

• patchImportParserPlugin, which takes care of providing chunk names for imports
• patchImportDependencyTemplate, which takes care of patching the import template so that __webpackChunkName is attached to modules.