-
Notifications
You must be signed in to change notification settings - Fork 27.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates Apollo Server Examples to use Apollo Server 4 & @as-integrations/next #42771
Conversation
Code seems okay, but yeah agree on merging into one. |
The Would it be prefered to have a single Apollo Server + Apollo Client example? Based on the content of the examples, maybe only the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next.js apps are usually hybrid (meaning they have both static and dynamic pages), so I think we could really merge everything into a single example, showcasing anything we need in one project. For now, I think we can merge this PR, as it resolves a bunch of issues, thank you! 💚
If you are interested in helping out with the merging of the examples, you can open a new PR with your suggested changes and we can continue the discussion there. 👍
FWIW it looks like there's still an Apollo Server 2 example in |
+1 I would just delete it if deprecated. |
Closes #42769
Description
This PR address #42769 by updating the
api-routes-apollo-server
,api-routes-apollo-server-and-client
andapi-routes-apollo-server-and-client-auth
examples to use Apollo Server 4 and @as-integrations/next, which is the Apollo Server Next integration package. The PR also updates the three examples to use Typescript. The functionality of the examples is the same.Documentation / Examples
pnpm build && pnpm lint
closes #33545
closes #30082
closes #21984
closes #10413