chore: update with-react-intl example #40999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaNdTriX
requested review from
timneutkens,
ijjk,
shuding,
leerob,
steven-tey and
balazsorban44
as code owners
HaNdTriX
force-pushed
the
examples/react-intl
branch
from
47a639b to
161e4ff
Compare
ijjk
reviewed
Sep 28, 2022
HaNdTriX
force-pushed
the
examples/react-intl
branch
from
9aae9b6 to
9731e5c
Compare
- ReactChild is deprecated - description should be a meta tag - locales can be null
The Next.js pipline (eslint) runs on Node 16. Type assert should be used from Node.js >= 17 onwards. If you want to know more about this check out the following discussion: eslint/eslint#15305
pnpm defaults to enable-pre-post-scripts=false leading to a broken example on the first run.
HaNdTriX
force-pushed
the
examples/react-intl
branch
from
9731e5c to
bf858d8
Compare
ijjk
approved these changes
Sep 30, 2022
|
🙏 Thanks @ijjk |
BowlingX
pushed a commit
to BowlingX/next.js
that referenced
this pull request
Oct 5, 2022
## Changes see commits ## Additional Info Since this example is quite complex I tried to remove additional noise (unused type inference). ## Documentation / Examples - [x] Make sure the linting passes by running `pnpm lint` - [x] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md) ## Related Closes: vercel#40975
Kikobeats
pushed a commit
to Kikobeats/next.js
that referenced
this pull request
Oct 24, 2022
## Changes see commits ## Additional Info Since this example is quite complex I tried to remove additional noise (unused type inference). ## Documentation / Examples - [x] Make sure the linting passes by running `pnpm lint` - [x] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md) ## Related Closes: vercel#40975
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
see commits
Additional Info
Since this example is quite complex I tried to remove additional noise (unused type inference).
Documentation / Examples
pnpm lintRelated
Closes: #40975