Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix token check if no token or query supplied #40060

Closed
wants to merge 1 commit into from
Closed

Fix token check if no token or query supplied #40060

wants to merge 1 commit into from

Conversation

JoelBalmer
Copy link

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this shouldn't be needed as req.query should always be an object and if it's undefined this would be a bug in Next.js and opening an issue with reproduction to allow investigating would be needed!

@ijjk ijjk closed this Aug 29, 2022
@JoelBalmer
Copy link
Author

@ijjk, ah i see my problem now - a series of issues on my end, the main of which was my secret being undefined which required a dev server restart to populate properly. Let me know if this would be a useful addition/note to the documentation (i.e. make sure your secret is not undefined), otherwise, no worries, and thanks for closing the PR for me :)

@ijjk
Copy link
Member

ijjk commented Aug 29, 2022

Ah I see, the env requiring a dev server restart won't be an issue too much longer x-ref: #38483

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants