-
Notifications
You must be signed in to change notification settings - Fork 27.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(examples): update with-apivideo #39727
Conversation
I see an error in the build test process: I've already faced this error trying to deploy to Vercel, and the only solution I found was to change the default install command to FYI, Any other solution that I can apply (if needed)? |
Hi @MarDi66 it looks like contributors are not allowed to edit your branch, so I cannot update or even merge this PR. I wanted to bring in the latest Further, keep in mind if we change or rename the directory, already existing links on the internet might break, but given the example is a few months old only, I think it is reasonable to rename without keeping the old one with a README that points to the new location. 👍 For simplicity's sake, we like to focus examples on the core feature/library they are presenting. Is SWR a vital part of the example? If not, maybe we should strip it, what do you think? |
With apivideo
Hey @balazsorban44 ✌🏼 I've removed the lock file changes and SWR from this PR. Cheers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Co-authored-by: Thibault Beyou <[email protected]>
Documentation / Examples
Hello Next.js 👋🏼
This PR aims to update the previous
with-apivideo-uploader
example by:with-apivideo
What's new
In addition to the uploader page, we have added:
What do we use
In this example, we use several Next.js features:
And api.video tools:
Thank's in advance for your review 🙏🏼