Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove buildId from dynamic import URLs #3498

Merged
merged 5 commits into from
Dec 27, 2017
Merged

Remove buildId from dynamic import URLs #3498

merged 5 commits into from
Dec 27, 2017

Conversation

arunoda
Copy link
Contributor

@arunoda arunoda commented Dec 25, 2017

This PR removes the buildId from the dynamic import URLs and adds webpack chunkHash to the filename.

So, dynamic imports will have better caching across multiple builds.

timneutkens
timneutkens approved these changes Dec 27, 2017
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@timneutkens timneutkens merged commit 337fb6a into canary Dec 27, 2017
@timneutkens timneutkens deleted the no-buildid-dynamic-import branch December 27, 2017 18:59
@lock lock bot locked as resolved and limited conversation to collaborators Dec 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@rauchg rauchg Awaiting requested review from rauchg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arunoda @timneutkens