Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jest dynamic imports testing #3361

Closed
wants to merge 5 commits into from
Closed

Jest dynamic imports testing #3361

wants to merge 5 commits into from

Conversation

PrudviGali
Copy link
Contributor

Closes #3345

yashha and others added 4 commits November 16, 2017 11:54
@yashha @timneutkens
Pulled encoding to top of head (vercel#3214)
a0e0f85
@brikou @timneutkens
Remove next.d.ts to use @types/next (vercel#3297)
bda073c
@dargue3 @timneutkens
Add with-mobx-state-tree example (vercel#3179)
a8c344f 
* Adapt with-mobx example for with-mobx-state-tree

* Remove unnecessary lastUpdate parameter to show off snapshot

* update readme

* make other.js more closely mimic index.js
@PrudviGali
added condition to check whether require.resolveWeak exists are not
3a74f87
@PrudviGali PrudviGali mentioned this pull request Dec 1, 2017
Closed
@PrudviGali
Copy link
Contributor Author

lint is failing for some examples/ pages. Authors have to fix this in the master branch to make builds succeed.

@timneutkens
Copy link
Member

@PrudviGali please use the canary branch

@timneutkens timneutkens changed the base branch from master to canary December 2, 2017 02:55
@PrudviGali
Copy link
Contributor Author

Created different pull request with the base as canary branch.

#3390

Closing this redundant one.

Thanks @timneutkens

@PrudviGali PrudviGali closed this Dec 4, 2017
@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PrudviGali @timneutkens @yashha @brikou @dargue3