Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Link): Do not ignore onMouseEnter prop with absolute href #32012

Merged
merged 2 commits into from
Dec 1, 2021
Merged

fix(Link): Do not ignore onMouseEnter prop with absolute href #32012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78eddb6
fix(Link): Do not ignore onMouseEnter prop with absolute href
ericmatthys Dec 1, 2021
b86fb43
Merge branch 'canary' into external-link-mouse-enter
ijjk Dec 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/next/client/link.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,11 +291,12 @@ function Link(props: React.PropsWithChildren<LinkProps>) {
}

childProps.onMouseEnter = (e: React.MouseEvent) => {
if (!isLocalURL(href)) return
if (child.props && typeof child.props.onMouseEnter === 'function') {
child.props.onMouseEnter(e)
}
prefetch(router, href, as, { priority: true })
if (isLocalURL(href)) {
prefetch(router, href, as, { priority: true })
}
}

// If child is an <a> tag and doesn't have a href attribute, or if the 'passHref' property is
Expand Down
13 changes: 13 additions & 0 deletions test/integration/client-navigation/pages/absolute-url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ export async function getServerSideProps({ query: { port } }) {

export default function Page({ port }) {
const router = useRouter()
const [hover, setHover] = React.useState(false)

return (
<>
<Link href="https://vercel.com/">
Expand Down Expand Up @@ -61,6 +63,17 @@ export default function Page({ port }) {
<Link href="mailto:[email protected]">
<a id="mailto-link">mailto:[email protected]</a>
</Link>
<br />
<Link href="https://vercel.com/">
<a
id="absolute-link-mouse-events"
data-hover={hover}
onMouseEnter={() => setHover(true)}
onMouseLeave={() => setHover(false)}
>
https://vercel.com/
</a>
</Link>
</>
)
}
15 changes: 15 additions & 0 deletions test/integration/client-navigation/test/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,21 @@ describe('Client Navigation', () => {
)
})

it('should call mouse handlers with an absolute url', async () => {
const browser = await webdriver(
context.appPort,
`/absolute-url?port=${context.appPort}`
)

await browser.elementByCss('#absolute-link-mouse-events').moveTo()

expect(
await browser
.waitForElementByCss('#absolute-link-mouse-events')
.getAttribute('data-hover')
).toBe('true')
})

it('should navigate an absolute local url', async () => {
const browser = await webdriver(
context.appPort,
Expand Down