Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazily init getStaticPathsWorker #31760

Merged

Conversation

timneutkens
Copy link
Member

Shaves off ~25ms during bootup when getStaticPaths is not used in the app.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk
Copy link
Member

ijjk commented Nov 24, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/initialize-staticpaths-worker-lazy Change
buildDuration 17.3s 17.3s ⚠️ +3ms
buildDurationCached 3.5s 3.4s -118ms
nodeModulesSize 339 MB 339 MB ⚠️ +383 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js add/initialize-staticpaths-worker-lazy Change
/ failed reqs 0 0
/ total time (seconds) 2.885 2.852 -0.03
/ avg req/sec 866.66 876.55 +9.89
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.34 1.294 -0.05
/error-in-render avg req/sec 1865.95 1932.4 +66.45
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/initialize-staticpaths-worker-lazy Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/initialize-staticpaths-worker-lazy Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js add/initialize-staticpaths-worker-lazy Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.45 kB 4.45 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/initialize-staticpaths-worker-lazy Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/initialize-staticpaths-worker-lazy Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/initialize-staticpaths-worker-lazy Change
buildDuration 18.4s 18.8s ⚠️ +425ms
buildDurationCached 3.6s 3.6s ⚠️ +2ms
nodeModulesSize 339 MB 339 MB ⚠️ +383 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js add/initialize-staticpaths-worker-lazy Change
/ failed reqs 0 0
/ total time (seconds) 2.904 2.842 -0.06
/ avg req/sec 860.85 879.63 +18.78
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.317 1.346 ⚠️ +0.03
/error-in-render avg req/sec 1898.12 1857.99 ⚠️ -40.13
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/initialize-staticpaths-worker-lazy Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/initialize-staticpaths-worker-lazy Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js add/initialize-staticpaths-worker-lazy Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.47 kB 4.47 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.2 kB 13.2 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/initialize-staticpaths-worker-lazy Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/initialize-staticpaths-worker-lazy Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 99b1213

@timneutkens timneutkens merged commit a4cd48e into vercel:canary Nov 24, 2021
@timneutkens timneutkens deleted the add/initialize-staticpaths-worker-lazy branch November 24, 2021 12:40
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants