Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract next-swc Rust code into its own package #31635

Merged
merged 14 commits into from
Nov 21, 2021

Conversation

padmaia
Copy link
Member

@padmaia padmaia commented Nov 19, 2021

Extract rust code into its own package so that we can have more granular caching.

Related: #31464

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Nov 19, 2021
@padmaia padmaia force-pushed the chore/next-swc-package branch 3 times, most recently from 0afe83c to 850a244 Compare November 20, 2021 00:17
@padmaia
Copy link
Member Author

padmaia commented Nov 20, 2021

I believe the failing tests will not fail once this is merged into the canary branch. @ijjk can you confirm?

@padmaia padmaia marked this pull request as ready for review November 20, 2021 01:05
@ijjk

This comment has been minimized.

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to ensure the binary is handled for isolated tests/PR stats. Looks good to land if the changes look alright to you 👍

@ijjk ijjk added create-next-app Related to our CLI tool for quickly starting a new Next.js application. area: documentation labels Nov 21, 2021
@ijjk

This comment has been minimized.

timneutkens
timneutkens previously approved these changes Nov 21, 2021
@ijjk
Copy link
Member

ijjk commented Nov 21, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary padmaia/next.js chore/next-swc-package Change
buildDuration 17.9s 18.1s ⚠️ +201ms
buildDurationCached 3.6s 3.6s -17ms
nodeModulesSize 339 MB 339 MB ⚠️ +1.13 kB
Page Load Tests Overall increase ✓
vercel/next.js canary padmaia/next.js chore/next-swc-package Change
/ failed reqs 0 0
/ total time (seconds) 2.982 3.037 ⚠️ +0.05
/ avg req/sec 838.24 823.1 ⚠️ -15.14
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.404 1.343 -0.06
/error-in-render avg req/sec 1780.2 1861.02 +80.82
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js chore/next-swc-package Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js chore/next-swc-package Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary padmaia/next.js chore/next-swc-package Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.45 kB 4.45 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js chore/next-swc-package Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js chore/next-swc-package Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary padmaia/next.js chore/next-swc-package Change
buildDuration 19.5s 19.6s ⚠️ +81ms
buildDurationCached 3.6s 3.6s -71ms
nodeModulesSize 339 MB 339 MB ⚠️ +1.13 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary padmaia/next.js chore/next-swc-package Change
/ failed reqs 0 0
/ total time (seconds) 2.986 2.962 -0.02
/ avg req/sec 837.24 844.13 +6.89
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.374 1.38 ⚠️ +0.01
/error-in-render avg req/sec 1819.24 1811.23 ⚠️ -8.01
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js chore/next-swc-package Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js chore/next-swc-package Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary padmaia/next.js chore/next-swc-package Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.47 kB 4.47 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.2 kB 13.2 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js chore/next-swc-package Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js chore/next-swc-package Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: cf98ea7

@timneutkens timneutkens merged commit a79d4fc into vercel:canary Nov 21, 2021
@timneutkens timneutkens deleted the chore/next-swc-package branch November 21, 2021 11:59
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application. created-by: Next.js team PRs by the Next.js team. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants