Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme.md): add good first issue section to readme.md #25085

Merged
merged 3 commits into from
May 18, 2021

Conversation

ananta
Copy link
Contributor

@ananta ananta commented May 13, 2021

Documentation / Examples

  • Make sure the linting passes

@timneutkens
Copy link
Member

Thanks!

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented May 18, 2021

Failing test suites

Commit: 71ad268

test/integration/prerender/test/index.test.js

  • SSG Prerender > enumlated serverless mode > should call /_error GIP on 500
Expand output

● SSG Prerender › enumlated serverless mode › should call /_error GIP on 500

expect(received).toMatch(expected)

Expected substring: "CUSTOM_ERROR_GIP_CALLED"
Received string:    ""

  1790 |         expect(res.status).toBe(500)
  1791 |         expect(await res.text()).toBe('FAIL_FUNCTION')
> 1792 |         expect(stderr).toMatch('CUSTOM_ERROR_GIP_CALLED')
       |                        ^
  1793 |         expect(stderr).not.toMatch('!!! WARNING !!!')
  1794 |       })
  1795 |     }

  at Object.<anonymous> (integration/prerender/test/index.test.js:1792:24)
      at runMicrotasks (<anonymous>)

@ijjk
Copy link
Member

ijjk commented May 18, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ananta/next.js add-good-first-issue-section-to-readme Change
buildDuration 16.3s 16.1s -204ms
buildDurationCached 5.2s 4.5s -637ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +285 B
Page Load Tests Overall increase ✓
vercel/next.js canary ananta/next.js add-good-first-issue-section-to-readme Change
/ failed reqs 0 0
/ total time (seconds) 2.842 2.743 -0.1
/ avg req/sec 879.57 911.51 +31.94
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.846 1.74 -0.11
/error-in-render avg req/sec 1354.12 1436.82 +82.7
Client Bundles (main, webpack, commons)
vercel/next.js canary ananta/next.js add-good-first-issue-section-to-readme Change
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 19.4 kB 19.4 kB
webpack-HASH.js gzip 994 B 994 B
Overall change 59.7 kB 59.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ananta/next.js add-good-first-issue-section-to-readme Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary ananta/next.js add-good-first-issue-section-to-readme Change
_app-HASH.js gzip 1.02 kB 1.02 kB
_error-HASH.js gzip 3.06 kB 3.06 kB
amp-HASH.js gzip 526 B 526 B
css-HASH.js gzip 334 B 334 B
hooks-HASH.js gzip 890 B 890 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 1.65 kB 1.65 kB
routerDirect..HASH.js gzip 331 B 331 B
withRouter-HASH.js gzip 329 B 329 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 8.54 kB 8.54 kB
Client Build Manifests
vercel/next.js canary ananta/next.js add-good-first-issue-section-to-readme Change
_buildManifest.js gzip 390 B 390 B
Overall change 390 B 390 B
Rendered Page Sizes
vercel/next.js canary ananta/next.js add-good-first-issue-section-to-readme Change
index.html gzip 561 B 561 B
link.html gzip 570 B 570 B
withRouter.html gzip 558 B 558 B
Overall change 1.69 kB 1.69 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary ananta/next.js add-good-first-issue-section-to-readme Change
buildDuration 19.4s 19s -435ms
buildDurationCached 6s 6s ⚠️ +27ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +285 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ananta/next.js add-good-first-issue-section-to-readme Change
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 19.4 kB 19.4 kB
webpack-HASH.js gzip 994 B 994 B
Overall change 59.7 kB 59.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ananta/next.js add-good-first-issue-section-to-readme Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary ananta/next.js add-good-first-issue-section-to-readme Change
_app-HASH.js gzip 1.02 kB 1.02 kB
_error-HASH.js gzip 3.06 kB 3.06 kB
amp-HASH.js gzip 526 B 526 B
css-HASH.js gzip 334 B 334 B
hooks-HASH.js gzip 890 B 890 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 1.65 kB 1.65 kB
routerDirect..HASH.js gzip 331 B 331 B
withRouter-HASH.js gzip 329 B 329 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 8.54 kB 8.54 kB
Client Build Manifests
vercel/next.js canary ananta/next.js add-good-first-issue-section-to-readme Change
_buildManifest.js gzip 390 B 390 B
Overall change 390 B 390 B
Serverless bundles
vercel/next.js canary ananta/next.js add-good-first-issue-section-to-readme Change
_error.js 17 kB 17 kB
404.html 2.42 kB 2.42 kB
500.html 2.41 kB 2.41 kB
amp.amp.html 10.8 kB 10.8 kB
amp.html 1.61 kB 1.61 kB
css.html 1.79 kB 1.79 kB
hooks.html 1.67 kB 1.67 kB
index.js 17.3 kB 17.3 kB
link.js 17.6 kB 17.6 kB
routerDirect.js 17.5 kB 17.5 kB
withRouter.js 17.6 kB 17.6 kB
Overall change 108 kB 108 kB

Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ananta/next.js add-good-first-issue-section-to-readme Change
buildDuration 13.5s 13.3s -152ms
buildDurationCached 6s 5.9s -14ms
nodeModulesSize 46.7 MB 46.7 MB ⚠️ +285 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ananta/next.js add-good-first-issue-section-to-readme Change
/ failed reqs 0 0
/ total time (seconds) 2.917 2.85 -0.07
/ avg req/sec 857.16 877.24 +20.08
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.788 1.871 ⚠️ +0.08
/error-in-render avg req/sec 1398.08 1336.16 ⚠️ -61.92
Client Bundles (main, webpack, commons)
vercel/next.js canary ananta/next.js add-good-first-issue-section-to-readme Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 7.26 kB 7.26 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 60.3 kB 60.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ananta/next.js add-good-first-issue-section-to-readme Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary ananta/next.js add-good-first-issue-section-to-readme Change
_app-HASH.js gzip 1.28 kB 1.28 kB
_error-HASH.js gzip 3.74 kB 3.74 kB
amp-HASH.js gzip 536 B 536 B
css-HASH.js gzip 339 B 339 B
hooks-HASH.js gzip 887 B 887 B
index-HASH.js gzip 227 B 227 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 303 B 303 B
withRouter-HASH.js gzip 302 B 302 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 9.38 kB 9.38 kB
Client Build Manifests
vercel/next.js canary ananta/next.js add-good-first-issue-section-to-readme Change
_buildManifest.js gzip 420 B 420 B
Overall change 420 B 420 B
Rendered Page Sizes
vercel/next.js canary ananta/next.js add-good-first-issue-section-to-readme Change
index.html gzip 614 B 614 B
link.html gzip 620 B 620 B
withRouter.html gzip 607 B 607 B
Overall change 1.84 kB 1.84 kB
Commit: 71ad268

This was referenced May 19, 2021
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 1, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants