Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure webpack cache is invalidated for alias change #24956

Merged
merged 3 commits into from
May 10, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented May 10, 2021

This ensures we don't attempt using an invalid cache from before rewrites were added since required imports for rewrites on the client are dead-code eliminated to reduce bundle sizes when rewrites aren't used that causes errors after rewrites have been added.

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Fixes: #24661

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

1 similar comment
@ijjk
Copy link
Member Author

ijjk commented May 10, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/rewrite-alias-cache Change
buildDuration 12.2s 12.3s ⚠️ +30ms
buildDurationCached 4.1s 3.8s -266ms
nodeModulesSize 46.5 MB 46.5 MB ⚠️ +48 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/rewrite-alias-cache Change
/ failed reqs 0 0
/ total time (seconds) 2.046 2.055 ⚠️ +0.01
/ avg req/sec 1222.11 1216.45 ⚠️ -5.66
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.057 1.079 ⚠️ +0.02
/error-in-render avg req/sec 2364.31 2317.54 ⚠️ -46.77
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/rewrite-alias-cache Change
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 19.3 kB 19.3 kB
webpack-HASH.js gzip 994 B 994 B
Overall change 59.6 kB 59.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/rewrite-alias-cache Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/rewrite-alias-cache Change
_app-HASH.js gzip 1.02 kB 1.02 kB
_error-HASH.js gzip 3.05 kB 3.05 kB
amp-HASH.js gzip 526 B 526 B
css-HASH.js gzip 334 B 334 B
hooks-HASH.js gzip 890 B 890 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 1.65 kB 1.65 kB
routerDirect..HASH.js gzip 331 B 331 B
withRouter-HASH.js gzip 329 B 329 B
99a142a5cfae..804.css gzip 125 B 125 B
Overall change 8.52 kB 8.52 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/rewrite-alias-cache Change
_buildManifest.js gzip 394 B 394 B
Overall change 394 B 394 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/rewrite-alias-cache Change
index.html gzip 561 B 561 B
link.html gzip 569 B 569 B
withRouter.html gzip 557 B 557 B
Overall change 1.69 kB 1.69 kB

Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/rewrite-alias-cache Change
buildDuration 15.2s 15s -255ms
buildDurationCached 5.7s 5.8s ⚠️ +60ms
nodeModulesSize 46.5 MB 46.5 MB ⚠️ +48 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/rewrite-alias-cache Change
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 19.3 kB 19.3 kB
webpack-HASH.js gzip 994 B 994 B
Overall change 59.6 kB 59.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/rewrite-alias-cache Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/rewrite-alias-cache Change
_app-HASH.js gzip 1.02 kB 1.02 kB
_error-HASH.js gzip 3.05 kB 3.05 kB
amp-HASH.js gzip 526 B 526 B
css-HASH.js gzip 334 B 334 B
hooks-HASH.js gzip 890 B 890 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 1.65 kB 1.65 kB
routerDirect..HASH.js gzip 331 B 331 B
withRouter-HASH.js gzip 329 B 329 B
99a142a5cfae..804.css gzip 125 B 125 B
Overall change 8.52 kB 8.52 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/rewrite-alias-cache Change
_buildManifest.js gzip 394 B 394 B
Overall change 394 B 394 B
Serverless bundles Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/rewrite-alias-cache Change
_error.js 1.34 MB 1.34 MB
404.html 2.42 kB 2.42 kB
500.html 2.41 kB 2.41 kB
amp.amp.html 10.8 kB 10.8 kB
amp.html 1.61 kB 1.61 kB
css.html 1.79 kB 1.79 kB
hooks.html 1.67 kB 1.67 kB
index.js 1.34 MB 1.34 MB -2 B
link.js 1.4 MB 1.4 MB -2 B
routerDirect.js 1.39 MB 1.39 MB -2 B
withRouter.js 1.39 MB 1.39 MB
Overall change 6.9 MB 6.9 MB -6 B

Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/rewrite-alias-cache Change
buildDuration 10.6s 10.6s ⚠️ +18ms
buildDurationCached 4.4s 4.3s -65ms
nodeModulesSize 46.5 MB 46.5 MB ⚠️ +48 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/rewrite-alias-cache Change
/ failed reqs 0 0
/ total time (seconds) 2.107 2.103 0
/ avg req/sec 1186.56 1188.99 +2.43
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.101 1.14 ⚠️ +0.04
/error-in-render avg req/sec 2271.31 2192.28 ⚠️ -79.03
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/rewrite-alias-cache Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 7.19 kB 7.19 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 60.2 kB 60.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/rewrite-alias-cache Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/rewrite-alias-cache Change
_app-HASH.js gzip 1.28 kB 1.28 kB
_error-HASH.js gzip 3.72 kB 3.72 kB
amp-HASH.js gzip 536 B 536 B
css-HASH.js gzip 339 B 339 B
hooks-HASH.js gzip 887 B 887 B
index-HASH.js gzip 227 B 227 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 303 B 303 B
withRouter-HASH.js gzip 302 B 302 B
21c68fa65a48..217.css gzip 125 B 125 B
Overall change 9.37 kB 9.37 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/rewrite-alias-cache Change
_buildManifest.js gzip 420 B 420 B
Overall change 420 B 420 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/rewrite-alias-cache Change
index.html gzip 614 B 614 B
link.html gzip 619 B 619 B
withRouter.html gzip 607 B 607 B
Overall change 1.84 kB 1.84 kB
Commit: 4cedde8

@ijjk ijjk merged commit e00e3c9 into vercel:canary May 10, 2021
@ijjk ijjk deleted the fix/rewrite-alias-cache branch May 10, 2021 22:29
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 1, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path rewrite Unhandled Runtime Error
2 participants