Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade eslint to the latest version #24377

Merged
merged 3 commits into from
Apr 25, 2021
Merged

Upgrade eslint to the latest version #24377

merged 3 commits into from
Apr 25, 2021

Conversation

timneutkens
Copy link
Member

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@ijjk
Copy link
Member

ijjk commented Apr 23, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
buildDuration 13.2s 13.3s ⚠️ +116ms
buildDurationCached 4.5s 4.2s -355ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +796 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.236 2.354 ⚠️ +0.12
/ avg req/sec 1117.9 1062.15 ⚠️ -55.75
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.177 1.207 ⚠️ +0.03
/error-in-render avg req/sec 2124.72 2070.55 ⚠️ -54.17
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
index.html gzip 610 B 610 B ✓
link.html gzip 614 B 616 B ⚠️ +2 B
withRouter.html gzip 604 B 605 B ⚠️ +1 B
Overall change 1.83 kB 1.83 kB ⚠️ +3 B

Diffs

Diff for 597-HASH.js 
@@ -1397,9 +1397,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
           : {
               default: obj
             };
-      }
-      /* global __NEXT_DATA__ */
-      // tslint:disable:no-console
+      } // tslint:disable:no-console
 
       var detectDomainLocale;
Diff for index.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-51b463afee0fd49dda07.js"
+      href="/_next/static/chunks/webpack-c6e8f5107ede59b60b44.js"
       as="script"
     />
     <link
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/597-43fe3bf983c91163dca3.js"
+      href="/_next/static/chunks/597-c155dff4a57343f91259.js"
       as="script"
     />
     <link
@@ -58,7 +58,7 @@
       src="/_next/static/chunks/polyfills-8683bd742a84c1edd48c.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-51b463afee0fd49dda07.js"
+      src="/_next/static/chunks/webpack-c6e8f5107ede59b60b44.js"
       async=""
     ></script>
     <script
@@ -66,7 +66,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/597-43fe3bf983c91163dca3.js"
+      src="/_next/static/chunks/597-c155dff4a57343f91259.js"
       async=""
     ></script>
     <script
Diff for link.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-51b463afee0fd49dda07.js"
+      href="/_next/static/chunks/webpack-c6e8f5107ede59b60b44.js"
       as="script"
     />
     <link
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/597-43fe3bf983c91163dca3.js"
+      href="/_next/static/chunks/597-c155dff4a57343f91259.js"
       as="script"
     />
     <link
@@ -63,7 +63,7 @@
       src="/_next/static/chunks/polyfills-8683bd742a84c1edd48c.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-51b463afee0fd49dda07.js"
+      src="/_next/static/chunks/webpack-c6e8f5107ede59b60b44.js"
       async=""
     ></script>
     <script
@@ -71,7 +71,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/597-43fe3bf983c91163dca3.js"
+      src="/_next/static/chunks/597-c155dff4a57343f91259.js"
       async=""
     ></script>
     <script
Diff for withRouter.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-51b463afee0fd49dda07.js"
+      href="/_next/static/chunks/webpack-c6e8f5107ede59b60b44.js"
       as="script"
     />
     <link
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/597-43fe3bf983c91163dca3.js"
+      href="/_next/static/chunks/597-c155dff4a57343f91259.js"
       as="script"
     />
     <link
@@ -58,7 +58,7 @@
       src="/_next/static/chunks/polyfills-8683bd742a84c1edd48c.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-51b463afee0fd49dda07.js"
+      src="/_next/static/chunks/webpack-c6e8f5107ede59b60b44.js"
       async=""
     ></script>
     <script
@@ -66,7 +66,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/597-43fe3bf983c91163dca3.js"
+      src="/_next/static/chunks/597-c155dff4a57343f91259.js"
       async=""
     ></script>
     <script
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
buildDuration 16.8s 16.7s -163ms
buildDurationCached 6.5s 6.4s -85ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +796 B
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
_error.js 1.39 MB 1.39 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.96 kB 1.96 kB ✓
css.html 2.13 kB 2.13 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB ✓
link.js 1.45 MB 1.45 MB -29 B
routerDirect.js 1.44 MB 1.44 MB -27 B
withRouter.js 1.44 MB 1.44 MB -27 B
Overall change 7.14 MB 7.14 MB -83 B
Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
buildDuration 11.6s 11.7s ⚠️ +49ms
buildDurationCached 4.8s 4.8s -88ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +796 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.288 2.291 0
/ avg req/sec 1092.65 1091.36 ⚠️ -1.29
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.186 1.252 ⚠️ +0.07
/error-in-render avg req/sec 2108.69 1996.75 ⚠️ -111.94
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.19 kB 7.19 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.36 kB 9.36 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
_buildManifest.js gzip 419 B 419 B ✓
Overall change 419 B 419 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
index.html gzip 612 B 612 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 605 B 606 B ⚠️ +1 B
Overall change 1.84 kB 1.84 kB ⚠️ +1 B

Diffs

Diff for 677f882d2ed8..c4df.HASH.js 
@@ -1234,9 +1234,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
           : {
               default: obj
             };
-      }
-      /* global __NEXT_DATA__ */
-      // tslint:disable:no-console
+      } // tslint:disable:no-console
 
       var detectDomainLocale;
Diff for index.html 
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8aa73afbb6b2a0863510.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.127ad5cf3a03e6dbd20b.js"
       as="script"
     />
     <link
@@ -61,7 +61,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8aa73afbb6b2a0863510.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.127ad5cf3a03e6dbd20b.js"
       async=""
     ></script>
     <script
Diff for link.html 
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8aa73afbb6b2a0863510.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.127ad5cf3a03e6dbd20b.js"
       as="script"
     />
     <link
@@ -66,7 +66,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8aa73afbb6b2a0863510.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.127ad5cf3a03e6dbd20b.js"
       async=""
     ></script>
     <script
Diff for withRouter.html 
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8aa73afbb6b2a0863510.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.127ad5cf3a03e6dbd20b.js"
       as="script"
     />
     <link
@@ -61,7 +61,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8aa73afbb6b2a0863510.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.127ad5cf3a03e6dbd20b.js"
       async=""
     ></script>
     <script
Commit: 286101a

@ijjk
Copy link
Member

ijjk commented Apr 23, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
buildDuration 14.8s 14.5s -263ms
buildDurationCached 4.9s 4.5s -375ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +4.6 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.565 2.586 ⚠️ +0.02
/ avg req/sec 974.8 966.78 ⚠️ -8.02
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.487 1.492 0
/error-in-render avg req/sec 1681.71 1675.06 ⚠️ -6.65
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
index.html gzip 610 B 610 B ✓
link.html gzip 614 B 616 B ⚠️ +2 B
withRouter.html gzip 604 B 605 B ⚠️ +1 B
Overall change 1.83 kB 1.83 kB ⚠️ +3 B

Diffs

Diff for 597-HASH.js 
@@ -1397,9 +1397,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
           : {
               default: obj
             };
-      }
-      /* global __NEXT_DATA__ */
-      // tslint:disable:no-console
+      } // tslint:disable:no-console
 
       var detectDomainLocale;
Diff for index.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-51b463afee0fd49dda07.js"
+      href="/_next/static/chunks/webpack-c6e8f5107ede59b60b44.js"
       as="script"
     />
     <link
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/597-43fe3bf983c91163dca3.js"
+      href="/_next/static/chunks/597-c155dff4a57343f91259.js"
       as="script"
     />
     <link
@@ -58,7 +58,7 @@
       src="/_next/static/chunks/polyfills-8683bd742a84c1edd48c.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-51b463afee0fd49dda07.js"
+      src="/_next/static/chunks/webpack-c6e8f5107ede59b60b44.js"
       async=""
     ></script>
     <script
@@ -66,7 +66,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/597-43fe3bf983c91163dca3.js"
+      src="/_next/static/chunks/597-c155dff4a57343f91259.js"
       async=""
     ></script>
     <script
Diff for link.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-51b463afee0fd49dda07.js"
+      href="/_next/static/chunks/webpack-c6e8f5107ede59b60b44.js"
       as="script"
     />
     <link
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/597-43fe3bf983c91163dca3.js"
+      href="/_next/static/chunks/597-c155dff4a57343f91259.js"
       as="script"
     />
     <link
@@ -63,7 +63,7 @@
       src="/_next/static/chunks/polyfills-8683bd742a84c1edd48c.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-51b463afee0fd49dda07.js"
+      src="/_next/static/chunks/webpack-c6e8f5107ede59b60b44.js"
       async=""
     ></script>
     <script
@@ -71,7 +71,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/597-43fe3bf983c91163dca3.js"
+      src="/_next/static/chunks/597-c155dff4a57343f91259.js"
       async=""
     ></script>
     <script
Diff for withRouter.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-51b463afee0fd49dda07.js"
+      href="/_next/static/chunks/webpack-c6e8f5107ede59b60b44.js"
       as="script"
     />
     <link
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/597-43fe3bf983c91163dca3.js"
+      href="/_next/static/chunks/597-c155dff4a57343f91259.js"
       as="script"
     />
     <link
@@ -58,7 +58,7 @@
       src="/_next/static/chunks/polyfills-8683bd742a84c1edd48c.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-51b463afee0fd49dda07.js"
+      src="/_next/static/chunks/webpack-c6e8f5107ede59b60b44.js"
       async=""
     ></script>
     <script
@@ -66,7 +66,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/597-43fe3bf983c91163dca3.js"
+      src="/_next/static/chunks/597-c155dff4a57343f91259.js"
       async=""
     ></script>
     <script
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
buildDuration 18.5s 18.4s -119ms
buildDurationCached 6.8s 6.8s ⚠️ +1ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +4.6 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
_error.js 1.39 MB 1.39 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.96 kB 1.96 kB ✓
css.html 2.13 kB 2.13 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB ⚠️ +2 B
link.js 1.45 MB 1.45 MB -27 B
routerDirect.js 1.44 MB 1.44 MB -27 B
withRouter.js 1.44 MB 1.44 MB -29 B
Overall change 7.14 MB 7.14 MB -81 B
Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
buildDuration 12.3s 12.3s -52ms
buildDurationCached 5.2s 5.1s -119ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +4.6 kB
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.548 2.544 0
/ avg req/sec 981.15 982.78 +1.63
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.511 1.491 -0.02
/error-in-render avg req/sec 1654.55 1676.77 +22.22
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.19 kB 7.19 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.36 kB 9.36 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
_buildManifest.js gzip 419 B 419 B ✓
Overall change 419 B 419 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
index.html gzip 612 B 612 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 605 B 606 B ⚠️ +1 B
Overall change 1.84 kB 1.84 kB ⚠️ +1 B

Diffs

Diff for 677f882d2ed8..c4df.HASH.js 
@@ -1234,9 +1234,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
           : {
               default: obj
             };
-      }
-      /* global __NEXT_DATA__ */
-      // tslint:disable:no-console
+      } // tslint:disable:no-console
 
       var detectDomainLocale;
Diff for index.html 
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8aa73afbb6b2a0863510.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.127ad5cf3a03e6dbd20b.js"
       as="script"
     />
     <link
@@ -61,7 +61,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8aa73afbb6b2a0863510.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.127ad5cf3a03e6dbd20b.js"
       async=""
     ></script>
     <script
Diff for link.html 
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8aa73afbb6b2a0863510.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.127ad5cf3a03e6dbd20b.js"
       as="script"
     />
     <link
@@ -66,7 +66,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8aa73afbb6b2a0863510.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.127ad5cf3a03e6dbd20b.js"
       async=""
     ></script>
     <script
Diff for withRouter.html 
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8aa73afbb6b2a0863510.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.127ad5cf3a03e6dbd20b.js"
       as="script"
     />
     <link
@@ -61,7 +61,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8aa73afbb6b2a0863510.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.127ad5cf3a03e6dbd20b.js"
       async=""
     ></script>
     <script
Commit: ac28aed

@ijjk
Copy link
Member

ijjk commented Apr 25, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
buildDuration 14.4s 14.1s -366ms
buildDurationCached 4.7s 4.4s -304ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +4.6 kB
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.418 2.422 0
/ avg req/sec 1034.02 1032.06 ⚠️ -1.96
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.262 1.2 -0.06
/error-in-render avg req/sec 1981.09 2082.47 +101.38
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
index.html gzip 608 B 611 B ⚠️ +3 B
link.html gzip 615 B 615 B ✓
withRouter.html gzip 605 B 606 B ⚠️ +1 B
Overall change 1.83 kB 1.83 kB ⚠️ +4 B

Diffs

Diff for 597-HASH.js 
@@ -1397,9 +1397,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
           : {
               default: obj
             };
-      }
-      /* global __NEXT_DATA__ */
-      // tslint:disable:no-console
+      } // tslint:disable:no-console
 
       var detectDomainLocale;
Diff for index.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-6fd2c2da65cda01d840f.js"
+      href="/_next/static/chunks/webpack-ed1890aadeae3a71879e.js"
       as="script"
     />
     <link
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/597-43fe3bf983c91163dca3.js"
+      href="/_next/static/chunks/597-c155dff4a57343f91259.js"
       as="script"
     />
     <link
@@ -58,7 +58,7 @@
       src="/_next/static/chunks/polyfills-8683bd742a84c1edd48c.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-6fd2c2da65cda01d840f.js"
+      src="/_next/static/chunks/webpack-ed1890aadeae3a71879e.js"
       async=""
     ></script>
     <script
@@ -66,7 +66,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/597-43fe3bf983c91163dca3.js"
+      src="/_next/static/chunks/597-c155dff4a57343f91259.js"
       async=""
     ></script>
     <script
Diff for link.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-6fd2c2da65cda01d840f.js"
+      href="/_next/static/chunks/webpack-ed1890aadeae3a71879e.js"
       as="script"
     />
     <link
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/597-43fe3bf983c91163dca3.js"
+      href="/_next/static/chunks/597-c155dff4a57343f91259.js"
       as="script"
     />
     <link
@@ -63,7 +63,7 @@
       src="/_next/static/chunks/polyfills-8683bd742a84c1edd48c.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-6fd2c2da65cda01d840f.js"
+      src="/_next/static/chunks/webpack-ed1890aadeae3a71879e.js"
       async=""
     ></script>
     <script
@@ -71,7 +71,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/597-43fe3bf983c91163dca3.js"
+      src="/_next/static/chunks/597-c155dff4a57343f91259.js"
       async=""
     ></script>
     <script
Diff for withRouter.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/webpack-6fd2c2da65cda01d840f.js"
+      href="/_next/static/chunks/webpack-ed1890aadeae3a71879e.js"
       as="script"
     />
     <link
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/597-43fe3bf983c91163dca3.js"
+      href="/_next/static/chunks/597-c155dff4a57343f91259.js"
       as="script"
     />
     <link
@@ -58,7 +58,7 @@
       src="/_next/static/chunks/polyfills-8683bd742a84c1edd48c.js"
     ></script>
     <script
-      src="/_next/static/chunks/webpack-6fd2c2da65cda01d840f.js"
+      src="/_next/static/chunks/webpack-ed1890aadeae3a71879e.js"
       async=""
     ></script>
     <script
@@ -66,7 +66,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/597-43fe3bf983c91163dca3.js"
+      src="/_next/static/chunks/597-c155dff4a57343f91259.js"
       async=""
     ></script>
     <script
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
buildDuration 17.6s 18.5s ⚠️ +859ms
buildDurationCached 6.7s 6.8s ⚠️ +73ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +4.6 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
_error.js 1.39 MB 1.39 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.96 kB 1.96 kB ✓
css.html 2.13 kB 2.13 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB ✓
link.js 1.45 MB 1.45 MB -27 B
routerDirect.js 1.44 MB 1.44 MB -27 B
withRouter.js 1.44 MB 1.44 MB -27 B
Overall change 7.14 MB 7.14 MB -81 B
Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
buildDuration 12.3s 12.2s -113ms
buildDurationCached 5.1s 5s -90ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +4.6 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.406 2.428 ⚠️ +0.02
/ avg req/sec 1039.15 1029.46 ⚠️ -9.69
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.244 1.25 ⚠️ +0.01
/error-in-render avg req/sec 2010.44 2000.04 ⚠️ -10.4
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.19 kB 7.19 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.36 kB 9.36 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
_buildManifest.js gzip 419 B 419 B ✓
Overall change 419 B 419 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/upgrade-eslint Change
index.html gzip 612 B 612 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 604 B 606 B ⚠️ +2 B
Overall change 1.83 kB 1.84 kB ⚠️ +2 B

Diffs

Diff for 677f882d2ed8..c4df.HASH.js 
@@ -1234,9 +1234,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
           : {
               default: obj
             };
-      }
-      /* global __NEXT_DATA__ */
-      // tslint:disable:no-console
+      } // tslint:disable:no-console
 
       var detectDomainLocale;
Diff for index.html 
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8aa73afbb6b2a0863510.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.127ad5cf3a03e6dbd20b.js"
       as="script"
     />
     <link
@@ -61,7 +61,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8aa73afbb6b2a0863510.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.127ad5cf3a03e6dbd20b.js"
       async=""
     ></script>
     <script
Diff for link.html 
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8aa73afbb6b2a0863510.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.127ad5cf3a03e6dbd20b.js"
       as="script"
     />
     <link
@@ -66,7 +66,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8aa73afbb6b2a0863510.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.127ad5cf3a03e6dbd20b.js"
       async=""
     ></script>
     <script
Diff for withRouter.html 
@@ -17,7 +17,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8aa73afbb6b2a0863510.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.127ad5cf3a03e6dbd20b.js"
       as="script"
     />
     <link
@@ -61,7 +61,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8aa73afbb6b2a0863510.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.127ad5cf3a03e6dbd20b.js"
       async=""
     ></script>
     <script
Commit: c86b22c

@kodiakhq kodiakhq bot merged commit cf4ba8d into vercel:canary Apr 25, 2021
This was referenced Apr 28, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Merged
Open
Open
Merged
Merged
Open
This was referenced Apr 28, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Merged
Open
Open
Open
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shuding shuding shuding approved these changes

@divmain divmain Awaiting requested review from divmain

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timneutkens @ijjk @shuding