Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade packages for example/with-typescript-eslint-jest #21963

Merged

Conversation

kaznak
Copy link
Contributor

@kaznak kaznak commented Feb 8, 2021

I met some error when I tried to use next/image in a repository derived from with-typescript-eslint-jest by create-next-app.
The detail situation was discussed in this thread and concluded the old @react-testing-library causes the error.

Therefore I made a patch that upgrades the packages of with-typescript-eslint-jest. Please merge this.

Thank you for reading!

@ijjk ijjk added the examples Issue was opened via the examples template. label Feb 8, 2021
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@leerob leerob merged commit 5d58626 into vercel:canary Feb 9, 2021
@kaznak kaznak deleted the update-example-with-typescript-eslint-jest branch February 9, 2021 12:34
This was referenced Jan 18, 2022
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants