-
Notifications
You must be signed in to change notification settings - Fork 27.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom loader and dynamic options in next-mdx #21647
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phuctm97
requested review from
ijjk,
lfades,
Timer and
timneutkens
as code owners
January 29, 2021 00:43
Stats from current PRDefault Server Mode (Increase detected
|
vercel/next.js canary | phuctm97/next.js custom-loader-options-mdx | Change | |
---|---|---|---|
buildDuration | 10.3s | 10.2s | -128ms |
nodeModulesSize | 75 MB | 75 MB | ✓ |
Page Load Tests Overall increase ✓
vercel/next.js canary | phuctm97/next.js custom-loader-options-mdx | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.188 | 2.153 | -0.04 |
/ avg req/sec | 1142.56 | 1161.13 | +18.57 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.47 | 1.442 | -0.03 |
/error-in-render avg req/sec | 1701 | 1733.29 | +32.29 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | phuctm97/next.js custom-loader-options-mdx | Change | |
---|---|---|---|
677f882d2ed8..38ed.js gzip | 13.1 kB | 13.1 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-HASH.js gzip | 6.63 kB | 6.63 kB | ✓ |
webpack-HASH.js gzip | 751 B | 751 B | ✓ |
Overall change | 59.4 kB | 59.4 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | phuctm97/next.js custom-loader-options-mdx | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31.3 kB | 31.3 kB | ✓ |
Overall change | 31.3 kB | 31.3 kB | ✓ |
Client Pages
vercel/next.js canary | phuctm97/next.js custom-loader-options-mdx | Change | |
---|---|---|---|
_app-2a09aa2..4a98.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-8b758..aef6.js gzip | 3.46 kB | 3.46 kB | ✓ |
hooks-c71ae4..70cd.js gzip | 887 B | 887 B | ✓ |
index-bbee2f..528b.js gzip | 227 B | 227 B | ✓ |
link-7faf09b..eba4.js gzip | 1.64 kB | 1.64 kB | ✓ |
routerDirect..bf84.js gzip | 303 B | 303 B | ✓ |
withRouter-a..5826.js gzip | 302 B | 302 B | ✓ |
Overall change | 8.09 kB | 8.09 kB | ✓ |
Client Build Manifests
vercel/next.js canary | phuctm97/next.js custom-loader-options-mdx | Change | |
---|---|---|---|
_buildManifest.js gzip | 321 B | 321 B | ✓ |
Overall change | 321 B | 321 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | phuctm97/next.js custom-loader-options-mdx | Change | |
---|---|---|---|
index.html gzip | 614 B | 614 B | ✓ |
link.html gzip | 620 B | 620 B | ✓ |
withRouter.html gzip | 607 B | 607 B | ✓ |
Overall change | 1.84 kB | 1.84 kB | ✓ |
Serverless Mode
General
vercel/next.js canary | phuctm97/next.js custom-loader-options-mdx | Change | |
---|---|---|---|
buildDuration | 12.3s | 12.2s | -104ms |
nodeModulesSize | 75 MB | 75 MB | ✓ |
Client Bundles (main, webpack, commons)
vercel/next.js canary | phuctm97/next.js custom-loader-options-mdx | Change | |
---|---|---|---|
677f882d2ed8..38ed.js gzip | 13.1 kB | 13.1 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-HASH.js gzip | 6.63 kB | 6.63 kB | ✓ |
webpack-HASH.js gzip | 751 B | 751 B | ✓ |
Overall change | 59.4 kB | 59.4 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | phuctm97/next.js custom-loader-options-mdx | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31.3 kB | 31.3 kB | ✓ |
Overall change | 31.3 kB | 31.3 kB | ✓ |
Client Pages
vercel/next.js canary | phuctm97/next.js custom-loader-options-mdx | Change | |
---|---|---|---|
_app-2a09aa2..4a98.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-8b758..aef6.js gzip | 3.46 kB | 3.46 kB | ✓ |
hooks-c71ae4..70cd.js gzip | 887 B | 887 B | ✓ |
index-bbee2f..528b.js gzip | 227 B | 227 B | ✓ |
link-7faf09b..eba4.js gzip | 1.64 kB | 1.64 kB | ✓ |
routerDirect..bf84.js gzip | 303 B | 303 B | ✓ |
withRouter-a..5826.js gzip | 302 B | 302 B | ✓ |
Overall change | 8.09 kB | 8.09 kB | ✓ |
Client Build Manifests
vercel/next.js canary | phuctm97/next.js custom-loader-options-mdx | Change | |
---|---|---|---|
_buildManifest.js gzip | 321 B | 321 B | ✓ |
Overall change | 321 B | 321 B | ✓ |
Serverless bundles
vercel/next.js canary | phuctm97/next.js custom-loader-options-mdx | Change | |
---|---|---|---|
_error.js | 1 MB | 1 MB | ✓ |
404.html | 2.67 kB | 2.67 kB | ✓ |
hooks.html | 1.92 kB | 1.92 kB | ✓ |
index.js | 1 MB | 1 MB | ✓ |
link.js | 1.06 MB | 1.06 MB | ✓ |
routerDirect.js | 1.05 MB | 1.05 MB | ✓ |
withRouter.js | 1.05 MB | 1.05 MB | ✓ |
Overall change | 5.19 MB | 5.19 MB | ✓ |
Webpack 5 Mode (Decrease detected ✓)
General
vercel/next.js canary | phuctm97/next.js custom-loader-options-mdx | Change | |
---|---|---|---|
buildDuration | 12.3s | 12.7s | |
nodeModulesSize | 75 MB | 75 MB | ✓ |
Page Load Tests Overall decrease ⚠️
vercel/next.js canary | phuctm97/next.js custom-loader-options-mdx | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.123 | 2.182 | |
/ avg req/sec | 1177.59 | 1145.69 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.465 | 1.502 | |
/error-in-render avg req/sec | 1706.14 | 1664.83 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | phuctm97/next.js custom-loader-options-mdx | Change | |
---|---|---|---|
597-7c719119..27b6.js gzip | 13 kB | 13 kB | ✓ |
framework.HASH.js gzip | 39.3 kB | 39.3 kB | ✓ |
main-HASH.js gzip | 6.58 kB | 6.58 kB | ✓ |
webpack-HASH.js gzip | 954 B | 954 B | ✓ |
Overall change | 59.8 kB | 59.8 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | phuctm97/next.js custom-loader-options-mdx | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31.1 kB | 31.1 kB | ✓ |
Overall change | 31.1 kB | 31.1 kB | ✓ |
Client Pages
vercel/next.js canary | phuctm97/next.js custom-loader-options-mdx | Change | |
---|---|---|---|
_app-6e0a903..b885.js gzip | 1.26 kB | 1.26 kB | ✓ |
_error-7a100..a392.js gzip | 3.38 kB | 3.38 kB | ✓ |
hooks-f7e199..11b9.js gzip | 904 B | 904 B | ✓ |
index-3dc22c..ffbb.js gzip | 232 B | 232 B | ✓ |
link-c010d28..b60a.js gzip | 1.63 kB | 1.63 kB | ✓ |
routerDirect..323a.js gzip | 308 B | 308 B | ✓ |
withRouter-a..2ef8.js gzip | 304 B | 304 B | ✓ |
Overall change | 8.02 kB | 8.02 kB | ✓ |
Client Build Manifests
vercel/next.js canary | phuctm97/next.js custom-loader-options-mdx | Change | |
---|---|---|---|
_buildManifest.js gzip | 299 B | 299 B | ✓ |
Overall change | 299 B | 299 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | phuctm97/next.js custom-loader-options-mdx | Change | |
---|---|---|---|
index.html gzip | 585 B | 585 B | ✓ |
link.html gzip | 592 B | 592 B | ✓ |
withRouter.html gzip | 579 B | 579 B | ✓ |
Overall change | 1.76 kB | 1.76 kB | ✓ |
Diffs
Diff for index.html
@@ -43,7 +43,7 @@
"props": { "pageProps": {} },
"page": "/",
"query": {},
- "buildId": "p4BWBPGAtuOOeCiYt9jRh",
+ "buildId": "tMFKWrg2zV8ClqDlPi-TA",
"isFallback": false,
"gip": true
}
@@ -77,11 +77,11 @@
async=""
></script>
<script
- src="/_next/static/p4BWBPGAtuOOeCiYt9jRh/_buildManifest.js"
+ src="/_next/static/tMFKWrg2zV8ClqDlPi-TA/_buildManifest.js"
async=""
></script>
<script
- src="/_next/static/p4BWBPGAtuOOeCiYt9jRh/_ssgManifest.js"
+ src="/_next/static/tMFKWrg2zV8ClqDlPi-TA/_ssgManifest.js"
async=""
></script>
</body>
Diff for link.html
@@ -48,7 +48,7 @@
"props": { "pageProps": {} },
"page": "/link",
"query": {},
- "buildId": "p4BWBPGAtuOOeCiYt9jRh",
+ "buildId": "tMFKWrg2zV8ClqDlPi-TA",
"isFallback": false,
"gip": true
}
@@ -82,11 +82,11 @@
async=""
></script>
<script
- src="/_next/static/p4BWBPGAtuOOeCiYt9jRh/_buildManifest.js"
+ src="/_next/static/tMFKWrg2zV8ClqDlPi-TA/_buildManifest.js"
async=""
></script>
<script
- src="/_next/static/p4BWBPGAtuOOeCiYt9jRh/_ssgManifest.js"
+ src="/_next/static/tMFKWrg2zV8ClqDlPi-TA/_ssgManifest.js"
async=""
></script>
</body>
Diff for withRouter.html
@@ -43,7 +43,7 @@
"props": { "pageProps": {} },
"page": "/withRouter",
"query": {},
- "buildId": "p4BWBPGAtuOOeCiYt9jRh",
+ "buildId": "tMFKWrg2zV8ClqDlPi-TA",
"isFallback": false,
"gip": true
}
@@ -77,11 +77,11 @@
async=""
></script>
<script
- src="/_next/static/p4BWBPGAtuOOeCiYt9jRh/_buildManifest.js"
+ src="/_next/static/tMFKWrg2zV8ClqDlPi-TA/_buildManifest.js"
async=""
></script>
<script
- src="/_next/static/p4BWBPGAtuOOeCiYt9jRh/_ssgManifest.js"
+ src="/_next/static/tMFKWrg2zV8ClqDlPi-TA/_ssgManifest.js"
async=""
></script>
</body>
Failing test suitesCommit: b2b9cd4 test/integration/script-loader/test/index.test.js
Expand output● Script Loader › priority lazy
|
Closed because I had no bandwidth to fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
@next/mdx
users to optionally use custom loader and dynamically resolving MDX options.Example use case: custom configuration/processor for different files.