Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add next.config.js for v3 next export example with-dynamic-import #1976

Merged
merged 5 commits into from
May 16, 2017

Conversation

johhansantana
Copy link
Contributor

@johhansantana johhansantana commented May 16, 2017

Added working v3-beta version in package.json.

Also, example here has syntax error.

This is my first pull request here, I'm not sure if I'm doing the right way :l

@johhansantana johhansantana changed the title add next.config.js for v3 next export add next.config.js for v3 next export example with-dynamic-import May 16, 2017
@vinaypuppal
Copy link
Contributor

vinaypuppal commented May 16, 2017

@johhansantana Can you also fix this in Readme
from

curl https://codeload.github.com/zeit/next.js/tar.gz/master | tar -xz --strip=2 next.js-master/examples/shared-modules
cd shared-modules

to

curl https://codeload.github.com/zeit/next.js/tar.gz/master | tar -xz --strip=2 next.js-master/examples/with-dynamic-import
cd with-dynamic-import

@johhansantana
Copy link
Contributor Author

@vinaypuppal done :D

@arunoda
Copy link
Contributor

arunoda commented May 16, 2017

Guys thanks for this.
But for the dynamic import example we should add the next export settings.
Could you remove the stuff from the next config file.

@johhansantana
Copy link
Contributor Author

Sorry for my ignorance but what is the next export settings ?

@vinaypuppal
Copy link
Contributor

@johhansantana No need of this file examples/with-dynamic-import/next.config.js for this example as its only needed if we want to use next export. So @arunoda asked you to remove it.

@johhansantana
Copy link
Contributor Author

ah! @vinaypuppal I think I was confused that this was the example for next export as it's at the end of the blog post

@arunoda
Copy link
Contributor

arunoda commented May 16, 2017

This is great.
Thanks.

@arunoda arunoda merged commit dff20ea into vercel:v3-beta May 16, 2017
@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants