Making font optimization as default #19758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
prateekbh
commented
Dec 2, 2020
•
prateekbh
commented
- Making font optimizations as default
- Re-enabling tests
- Fixes Font Optimization produces empty font definitions #19159
prateekbh
requested review from
ijjk,
lfades,
Timer and
timneutkens
as code owners
Stats from current PRDefault Server Mode (Increase detected
|
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| buildDuration | 9.3s | 9s | -290ms |
| nodeModulesSize | 82.3 MB | 82.3 MB | ✓ |
Page Load Tests Overall increase ✓
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 1.86 | 1.856 | 0 |
| / avg req/sec | 1343.93 | 1346.89 | +2.96 |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.21 | 1.157 | -0.05 |
| /error-in-render avg req/sec | 2066.69 | 2161.67 | +94.98 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| 677f882d2ed8..8b6e.js gzip | 12.8 kB | 12.8 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-3c9ff84..1d7c.js gzip | 6.56 kB | 6.56 kB | ✓ |
| webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59 kB | 59 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-fca3d..2eb1.js gzip | 3.44 kB | 3.44 kB | ✓ |
| hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
| index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
| link-db223d9..dbd7.js gzip | 1.61 kB | 1.61 kB | ✓ |
| routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
| withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
| Overall change | 8.01 kB | 8.01 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 321 B | 321 B | ✓ |
| Overall change | 321 B | 321 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| index.html gzip | 614 B | 614 B | ✓ |
| link.html gzip | 620 B | 620 B | ✓ |
| withRouter.html gzip | 608 B | 608 B | ✓ |
| Overall change | 1.84 kB | 1.84 kB | ✓ |
Serverless Mode
General
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| buildDuration | 10.6s | 10.8s | |
| nodeModulesSize | 82.3 MB | 82.3 MB | ✓ |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| 677f882d2ed8..8b6e.js gzip | 12.8 kB | 12.8 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-3c9ff84..1d7c.js gzip | 6.56 kB | 6.56 kB | ✓ |
| webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59 kB | 59 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-fca3d..2eb1.js gzip | 3.44 kB | 3.44 kB | ✓ |
| hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
| index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
| link-db223d9..dbd7.js gzip | 1.61 kB | 1.61 kB | ✓ |
| routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
| withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
| Overall change | 8.01 kB | 8.01 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 321 B | 321 B | ✓ |
| Overall change | 321 B | 321 B | ✓ |
Serverless bundles
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _error.js | 997 kB | 997 kB | ✓ |
| 404.html | 2.67 kB | 2.67 kB | ✓ |
| hooks.html | 1.92 kB | 1.92 kB | ✓ |
| index.js | 998 kB | 998 kB | ✓ |
| link.js | 1.05 MB | 1.05 MB | ✓ |
| routerDirect.js | 1.04 MB | 1.04 MB | ✓ |
| withRouter.js | 1.04 MB | 1.04 MB | ✓ |
| Overall change | 5.14 MB | 5.14 MB | ✓ |
Failing test suitesCommit: 76ca66c test/integration/font-optimization/test/index.test.js
Expand output● Font optimization for emulated serverless apps › should inline the google fonts for static pages ● Font optimization for emulated serverless apps › should inline the google fonts for static pages with Next/Head ● Font optimization for emulated serverless apps › should inline the google fonts for SSR pages |
Stats from current PRDefault Server Mode (Increase detected
|
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| buildDuration | 10.6s | 10.4s | -152ms |
| nodeModulesSize | 82.3 MB | 82.3 MB | -118 B |
Page Load Tests Overall increase ✓
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.065 | 2.095 | |
| / avg req/sec | 1210.74 | 1193.38 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.309 | 1.273 | -0.04 |
| /error-in-render avg req/sec | 1910.02 | 1963.19 | +53.17 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| 677f882d2ed8..8b6e.js gzip | 12.8 kB | 12.8 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-3c9ff84..1d7c.js gzip | 6.56 kB | 6.56 kB | ✓ |
| webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59 kB | 59 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-fca3d..2eb1.js gzip | 3.44 kB | 3.44 kB | ✓ |
| hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
| index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
| link-db223d9..dbd7.js gzip | 1.61 kB | 1.61 kB | ✓ |
| routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
| withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
| Overall change | 8.01 kB | 8.01 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 321 B | 321 B | ✓ |
| Overall change | 321 B | 321 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| index.html gzip | 614 B | 614 B | ✓ |
| link.html gzip | 620 B | 620 B | ✓ |
| withRouter.html gzip | 608 B | 608 B | ✓ |
| Overall change | 1.84 kB | 1.84 kB | ✓ |
Serverless Mode (Increase detected ⚠️ )
General Overall decrease ✓
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| buildDuration | 11.9s | 12.5s | |
| nodeModulesSize | 82.3 MB | 82.3 MB | -118 B |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| 677f882d2ed8..8b6e.js gzip | 12.8 kB | 12.8 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-3c9ff84..1d7c.js gzip | 6.56 kB | 6.56 kB | ✓ |
| webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59 kB | 59 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-fca3d..2eb1.js gzip | 3.44 kB | 3.44 kB | ✓ |
| hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
| index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
| link-db223d9..dbd7.js gzip | 1.61 kB | 1.61 kB | ✓ |
| routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
| withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
| Overall change | 8.01 kB | 8.01 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 321 B | 321 B | ✓ |
| Overall change | 321 B | 321 B | ✓ |
Serverless bundles Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _error.js | 997 kB | 998 kB | |
| 404.html | 2.67 kB | 2.67 kB | ✓ |
| hooks.html | 1.92 kB | 1.92 kB | ✓ |
| index.js | 998 kB | 998 kB | |
| link.js | 1.05 MB | 1.05 MB | |
| routerDirect.js | 1.04 MB | 1.04 MB | |
| withRouter.js | 1.04 MB | 1.04 MB | |
| Overall change | 5.14 MB | 5.14 MB |
Stats from current PRDefault Server Mode (Increase detected
|
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| buildDuration | 11.4s | 11s | -381ms |
| nodeModulesSize | 82.3 MB | 82.3 MB | -118 B |
Page Load Tests Overall increase ✓
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.268 | 2.294 | |
| / avg req/sec | 1102.09 | 1089.81 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.663 | 1.635 | -0.03 |
| /error-in-render avg req/sec | 1503.4 | 1529.42 | +26.02 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| 677f882d2ed8..8b6e.js gzip | 12.8 kB | 12.8 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-3c9ff84..1d7c.js gzip | 6.56 kB | 6.56 kB | ✓ |
| webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59 kB | 59 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-fca3d..2eb1.js gzip | 3.44 kB | 3.44 kB | ✓ |
| hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
| index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
| link-db223d9..dbd7.js gzip | 1.61 kB | 1.61 kB | ✓ |
| routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
| withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
| Overall change | 8.01 kB | 8.01 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 321 B | 321 B | ✓ |
| Overall change | 321 B | 321 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| index.html gzip | 614 B | 614 B | ✓ |
| link.html gzip | 620 B | 620 B | ✓ |
| withRouter.html gzip | 608 B | 608 B | ✓ |
| Overall change | 1.84 kB | 1.84 kB | ✓ |
Serverless Mode (Increase detected ⚠️ )
General Overall decrease ✓
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| buildDuration | 13.3s | 13.3s | -14ms |
| nodeModulesSize | 82.3 MB | 82.3 MB | -118 B |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| 677f882d2ed8..8b6e.js gzip | 12.8 kB | 12.8 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-3c9ff84..1d7c.js gzip | 6.56 kB | 6.56 kB | ✓ |
| webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59 kB | 59 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-fca3d..2eb1.js gzip | 3.44 kB | 3.44 kB | ✓ |
| hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
| index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
| link-db223d9..dbd7.js gzip | 1.61 kB | 1.61 kB | ✓ |
| routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
| withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
| Overall change | 8.01 kB | 8.01 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 321 B | 321 B | ✓ |
| Overall change | 321 B | 321 B | ✓ |
Serverless bundles Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _error.js | 997 kB | 998 kB | |
| 404.html | 2.67 kB | 2.67 kB | ✓ |
| hooks.html | 1.92 kB | 1.92 kB | ✓ |
| index.js | 998 kB | 998 kB | |
| link.js | 1.05 MB | 1.05 MB | |
| routerDirect.js | 1.04 MB | 1.04 MB | |
| withRouter.js | 1.04 MB | 1.04 MB | |
| Overall change | 5.14 MB | 5.14 MB |
Failing test suitesCommit: 451ffc6 test/integration/font-optimization/test/index.test.js
Expand output● Font optimization for emulated serverless apps › should inline the google fonts for static pages ● Font optimization for emulated serverless apps › should inline the google fonts for static pages with Next/Head ● Font optimization for emulated serverless apps › should inline the google fonts for SSR pages |
Failing test suitesCommit: 766fa30 test/integration/font-optimization/test/index.test.js
Expand output● Font optimization for emulated serverless apps › should inline the google fonts for static pages ● Font optimization for emulated serverless apps › should inline the google fonts for static pages with Next/Head ● Font optimization for emulated serverless apps › should inline the google fonts for SSR pages |
Failing test suitesCommit: e28141c test/integration/build-output/test/index.test.js
Expand output● Build Output › Basic Application Output › should not deviate from snapshot test/integration/script-loader/test/index.test.js
Expand output● Script Loader › priority eager |
Stats from current PRDefault Server Mode (Increase detected
|
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| buildDuration | 11s | 11.4s | |
| nodeModulesSize | 82.4 MB | 82.4 MB | -249 B |
Page Load Tests Overall increase ✓
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.334 | 2.468 | |
| / avg req/sec | 1071.13 | 1012.78 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.841 | 1.666 | -0.18 |
| /error-in-render avg req/sec | 1358.24 | 1500.43 | +142.19 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| 677f882d2ed8..8b6e.js gzip | 12.8 kB | 12.8 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-3c9ff84..1d7c.js gzip | 6.56 kB | 6.56 kB | ✓ |
| webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59 kB | 59 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-fca3d..2eb1.js gzip | 3.44 kB | 3.69 kB | |
| hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
| index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
| link-db223d9..dbd7.js gzip | 1.61 kB | 1.61 kB | ✓ |
| routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
| withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
| Overall change | 8.01 kB | 8.27 kB |
Client Build Manifests Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 321 B | 323 B | |
| Overall change | 321 B | 323 B |
Rendered Page Sizes
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| index.html gzip | 614 B | 614 B | ✓ |
| link.html gzip | 620 B | 620 B | ✓ |
| withRouter.html gzip | 608 B | 608 B | ✓ |
| Overall change | 1.84 kB | 1.84 kB | ✓ |
Diffs
Diff for _buildManifest.js
@@ -2,7 +2,7 @@ self.__BUILD_MANIFEST = {
__rewrites: [],
"/": ["static\u002Fchunks\u002Fpages\u002Findex-283eed3c1520dcc26e8d.js"],
"/_error": [
- "static\u002Fchunks\u002Fpages\u002F_error-9b57cae5694a39479222.js"
+ "static\u002Fchunks\u002Fpages\u002F_error-02dcb7995a984e881795.js"
],
"/hooks": [
"static\u002Fchunks\u002Fpages\u002Fhooks-bdd2cad07648acf22380.js"Diff for _error-9b57c..a39479222.js
@@ -535,8 +535,23 @@ Also adds support for deduplicated `key` properties
.map(function(c, i) {
var key = c.key || i;
- if (false) {
- var newProps;
+ if (true && !props.inAmpMode) {
+ if (
+ c.type === "link" &&
+ c.props["href"] && // TODO(prateekbh@): Replace this with const from `constants` when the tree shaking works.
+ ["https://fonts.googleapis.com/css"].some(function(url) {
+ return c.props["href"].startsWith(url);
+ })
+ ) {
+ var newProps = _objectSpread({}, c.props || {});
+
+ newProps["data-href"] = newProps["href"];
+ newProps["href"] = undefined;
+ return /*#__PURE__*/ _react["default"].cloneElement(
+ c,
+ newProps
+ );
+ }
}
return /*#__PURE__*/ _react["default"].cloneElement(c, {Serverless Mode (Increase detected ⚠️ )
General Overall decrease ✓
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| buildDuration | 13.3s | 13s | -276ms |
| nodeModulesSize | 82.4 MB | 82.4 MB | -249 B |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| 677f882d2ed8..8b6e.js gzip | 12.8 kB | 12.8 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-3c9ff84..1d7c.js gzip | 6.56 kB | 6.56 kB | ✓ |
| webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59 kB | 59 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-fca3d..2eb1.js gzip | 3.44 kB | N/A | N/A |
| hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
| index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
| link-db223d9..dbd7.js gzip | 1.61 kB | 1.61 kB | ✓ |
| routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
| withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
| _error-fbd76..16d8.js gzip | N/A | 3.69 kB | N/A |
| Overall change | 8.01 kB | 8.27 kB |
Client Build Manifests Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 321 B | 323 B | |
| Overall change | 321 B | 323 B |
Serverless bundles Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _error.js | 997 kB | 999 kB | |
| 404.html | 2.67 kB | 2.67 kB | ✓ |
| hooks.html | 1.92 kB | 1.92 kB | ✓ |
| index.js | 998 kB | 999 kB | |
| link.js | 1.05 MB | 1.05 MB | |
| routerDirect.js | 1.04 MB | 1.05 MB | |
| withRouter.js | 1.04 MB | 1.05 MB | |
| Overall change | 5.14 MB | 5.15 MB |
Stats from current PRDefault Server Mode (Increase detected
|
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| buildDuration | 10.6s | 10.1s | -484ms |
| nodeModulesSize | 82.4 MB | 82.4 MB | -249 B |
Page Load Tests Overall increase ✓
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.231 | 2.146 | -0.08 |
| / avg req/sec | 1120.74 | 1165.05 | +44.31 |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.553 | 1.486 | -0.07 |
| /error-in-render avg req/sec | 1609.83 | 1682.71 | +72.88 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| 677f882d2ed8..8b6e.js gzip | 12.8 kB | 12.8 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-3c9ff84..1d7c.js gzip | 6.56 kB | 6.56 kB | ✓ |
| webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59 kB | 59 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-fca3d..2eb1.js gzip | 3.44 kB | 3.69 kB | |
| hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
| index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
| link-db223d9..dbd7.js gzip | 1.61 kB | 1.61 kB | ✓ |
| routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
| withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
| Overall change | 8.01 kB | 8.27 kB |
Client Build Manifests Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 321 B | 323 B | |
| Overall change | 321 B | 323 B |
Rendered Page Sizes
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| index.html gzip | 614 B | 614 B | ✓ |
| link.html gzip | 620 B | 620 B | ✓ |
| withRouter.html gzip | 608 B | 608 B | ✓ |
| Overall change | 1.84 kB | 1.84 kB | ✓ |
Diffs
Diff for _buildManifest.js
@@ -2,7 +2,7 @@ self.__BUILD_MANIFEST = {
__rewrites: [],
"/": ["static\u002Fchunks\u002Fpages\u002Findex-283eed3c1520dcc26e8d.js"],
"/_error": [
- "static\u002Fchunks\u002Fpages\u002F_error-9b57cae5694a39479222.js"
+ "static\u002Fchunks\u002Fpages\u002F_error-02dcb7995a984e881795.js"
],
"/hooks": [
"static\u002Fchunks\u002Fpages\u002Fhooks-bdd2cad07648acf22380.js"Diff for _error-9b57c..a39479222.js
@@ -535,8 +535,23 @@ Also adds support for deduplicated `key` properties
.map(function(c, i) {
var key = c.key || i;
- if (false) {
- var newProps;
+ if (true && !props.inAmpMode) {
+ if (
+ c.type === "link" &&
+ c.props["href"] && // TODO(prateekbh@): Replace this with const from `constants` when the tree shaking works.
+ ["https://fonts.googleapis.com/css"].some(function(url) {
+ return c.props["href"].startsWith(url);
+ })
+ ) {
+ var newProps = _objectSpread({}, c.props || {});
+
+ newProps["data-href"] = newProps["href"];
+ newProps["href"] = undefined;
+ return /*#__PURE__*/ _react["default"].cloneElement(
+ c,
+ newProps
+ );
+ }
}
return /*#__PURE__*/ _react["default"].cloneElement(c, {Serverless Mode (Increase detected ⚠️ )
General Overall decrease ✓
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| buildDuration | 12s | 12s | -45ms |
| nodeModulesSize | 82.4 MB | 82.4 MB | -249 B |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| 677f882d2ed8..8b6e.js gzip | 12.8 kB | 12.8 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-3c9ff84..1d7c.js gzip | 6.56 kB | 6.56 kB | ✓ |
| webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59 kB | 59 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-fca3d..2eb1.js gzip | 3.44 kB | N/A | N/A |
| hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
| index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
| link-db223d9..dbd7.js gzip | 1.61 kB | 1.61 kB | ✓ |
| routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
| withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
| _error-fbd76..16d8.js gzip | N/A | 3.69 kB | N/A |
| Overall change | 8.01 kB | 8.27 kB |
Client Build Manifests Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 321 B | 323 B | |
| Overall change | 321 B | 323 B |
Serverless bundles Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _error.js | 997 kB | 999 kB | |
| 404.html | 2.67 kB | 2.67 kB | ✓ |
| hooks.html | 1.92 kB | 1.92 kB | ✓ |
| index.js | 998 kB | 999 kB | |
| link.js | 1.05 MB | 1.05 MB | |
| routerDirect.js | 1.04 MB | 1.05 MB | |
| withRouter.js | 1.04 MB | 1.05 MB | |
| Overall change | 5.14 MB | 5.15 MB |
Failing test suitesCommit: ca46378 test/integration/font-optimization/test/index.test.js
Expand output● Font optimization for SSR apps › should inline the google fonts for static pages ● Font optimization for SSR apps › should inline the google fonts for static pages with Next/Head ● Font optimization for SSR apps › should inline the google fonts for SSR pages ● Font optimization for emulated serverless apps › should inline the google fonts for static pages ● Font optimization for emulated serverless apps › should inline the google fonts for static pages with Next/Head ● Font optimization for emulated serverless apps › should inline the google fonts for SSR pages test/integration/script-loader/test/index.test.js
Expand output● Script Loader › priority eager |
Stats from current PRDefault Server Mode (Increase detected
|
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| buildDuration | 10.5s | 10.9s | |
| nodeModulesSize | 82.4 MB | 82.4 MB | -1.07 kB |
Page Load Tests Overall decrease ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.31 | 2.789 | |
| / avg req/sec | 1082.4 | 896.47 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.605 | 1.569 | -0.04 |
| /error-in-render avg req/sec | 1557.48 | 1592.92 | +35.44 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| 677f882d2ed8..8b6e.js gzip | 12.8 kB | 12.8 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-3c9ff84..1d7c.js gzip | 6.56 kB | 6.56 kB | ✓ |
| webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59 kB | 59 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-fca3d..2eb1.js gzip | 3.44 kB | 3.69 kB | |
| hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
| index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
| link-db223d9..dbd7.js gzip | 1.61 kB | 1.61 kB | ✓ |
| routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
| withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
| Overall change | 8.01 kB | 8.27 kB |
Client Build Manifests Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 321 B | 323 B | |
| Overall change | 321 B | 323 B |
Rendered Page Sizes
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| index.html gzip | 614 B | 614 B | ✓ |
| link.html gzip | 620 B | 620 B | ✓ |
| withRouter.html gzip | 608 B | 608 B | ✓ |
| Overall change | 1.84 kB | 1.84 kB | ✓ |
Diffs
Diff for _buildManifest.js
@@ -2,7 +2,7 @@ self.__BUILD_MANIFEST = {
__rewrites: [],
"/": ["static\u002Fchunks\u002Fpages\u002Findex-283eed3c1520dcc26e8d.js"],
"/_error": [
- "static\u002Fchunks\u002Fpages\u002F_error-9b57cae5694a39479222.js"
+ "static\u002Fchunks\u002Fpages\u002F_error-02dcb7995a984e881795.js"
],
"/hooks": [
"static\u002Fchunks\u002Fpages\u002Fhooks-bdd2cad07648acf22380.js"Diff for _error-9b57c..a39479222.js
@@ -535,8 +535,23 @@ Also adds support for deduplicated `key` properties
.map(function(c, i) {
var key = c.key || i;
- if (false) {
- var newProps;
+ if (true && !props.inAmpMode) {
+ if (
+ c.type === "link" &&
+ c.props["href"] && // TODO(prateekbh@): Replace this with const from `constants` when the tree shaking works.
+ ["https://fonts.googleapis.com/css"].some(function(url) {
+ return c.props["href"].startsWith(url);
+ })
+ ) {
+ var newProps = _objectSpread({}, c.props || {});
+
+ newProps["data-href"] = newProps["href"];
+ newProps["href"] = undefined;
+ return /*#__PURE__*/ _react["default"].cloneElement(
+ c,
+ newProps
+ );
+ }
}
return /*#__PURE__*/ _react["default"].cloneElement(c, {Serverless Mode (Increase detected ⚠️ )
General Overall decrease ✓
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| buildDuration | 12.7s | 12.8s | |
| nodeModulesSize | 82.4 MB | 82.4 MB | -1.07 kB |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| 677f882d2ed8..8b6e.js gzip | 12.8 kB | 12.8 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-3c9ff84..1d7c.js gzip | 6.56 kB | 6.56 kB | ✓ |
| webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59 kB | 59 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-fca3d..2eb1.js gzip | 3.44 kB | N/A | N/A |
| hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
| index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
| link-db223d9..dbd7.js gzip | 1.61 kB | 1.61 kB | ✓ |
| routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
| withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
| _error-fbd76..16d8.js gzip | N/A | 3.69 kB | N/A |
| Overall change | 8.01 kB | 8.27 kB |
Client Build Manifests Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 321 B | 323 B | |
| Overall change | 321 B | 323 B |
Serverless bundles Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _error.js | 997 kB | 998 kB | |
| 404.html | 2.67 kB | 2.67 kB | ✓ |
| hooks.html | 1.92 kB | 1.92 kB | ✓ |
| index.js | 998 kB | 999 kB | |
| link.js | 1.05 MB | 1.05 MB | |
| routerDirect.js | 1.04 MB | 1.05 MB | |
| withRouter.js | 1.04 MB | 1.05 MB | |
| Overall change | 5.14 MB | 5.15 MB |
Failing test suitesCommit: 372435b test/integration/font-optimization/test/index.test.js
Expand output● Font optimization for SSR apps › should inline the google fonts for static pages with Next/Head ● Font optimization for SSR apps › should inline the google fonts for SSR pages ● Font optimization for emulated serverless apps › should inline the google fonts for static pages with Next/Head ● Font optimization for emulated serverless apps › should inline the google fonts for SSR pages test/integration/script-loader/test/index.test.js
Expand output● Script Loader › priority eager |
Stats from current PRDefault Server Mode (Increase detected
|
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| buildDuration | 10.6s | 10.8s | |
| nodeModulesSize | 82.4 MB | 82.4 MB | -4.54 kB |
Page Load Tests Overall decrease ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.171 | 2.706 | |
| / avg req/sec | 1151.79 | 923.9 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.571 | 1.577 | |
| /error-in-render avg req/sec | 1591.59 | 1584.94 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| 677f882d2ed8..8b6e.js gzip | 12.8 kB | 12.8 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-3c9ff84..1d7c.js gzip | 6.56 kB | 6.56 kB | ✓ |
| webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59 kB | 59 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-fca3d..2eb1.js gzip | 3.44 kB | 3.69 kB | |
| hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
| index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
| link-db223d9..dbd7.js gzip | 1.61 kB | 1.61 kB | ✓ |
| routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
| withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
| Overall change | 8.01 kB | 8.27 kB |
Client Build Manifests Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 321 B | 322 B | |
| Overall change | 321 B | 322 B |
Rendered Page Sizes
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| index.html gzip | 614 B | 614 B | ✓ |
| link.html gzip | 620 B | 620 B | ✓ |
| withRouter.html gzip | 608 B | 608 B | ✓ |
| Overall change | 1.84 kB | 1.84 kB | ✓ |
Diffs
Diff for _buildManifest.js
@@ -2,7 +2,7 @@ self.__BUILD_MANIFEST = {
__rewrites: [],
"/": ["static\u002Fchunks\u002Fpages\u002Findex-283eed3c1520dcc26e8d.js"],
"/_error": [
- "static\u002Fchunks\u002Fpages\u002F_error-9b57cae5694a39479222.js"
+ "static\u002Fchunks\u002Fpages\u002F_error-fbaccf4d6b3c31a2915e.js"
],
"/hooks": [
"static\u002Fchunks\u002Fpages\u002Fhooks-bdd2cad07648acf22380.js"Diff for _error-9b57c..a39479222.js
@@ -535,8 +535,23 @@ Also adds support for deduplicated `key` properties
.map(function(c, i) {
var key = c.key || i;
- if (false) {
- var newProps;
+ if (true && !props.inAmpMode) {
+ if (
+ c.type === "link" &&
+ c.props["href"] && // TODO(prateekbh@): Replace this with const from `constants` when the tree shaking works.
+ ["https://fonts.googleapis.com/css"].some(function(url) {
+ return c.props["href"].startsWith(url);
+ })
+ ) {
+ var newProps = _objectSpread({}, c.props || {});
+
+ newProps["data-href"] = newProps["href"];
+ newProps["href"] = undefined;
+ return /*#__PURE__*/ _react["default"].cloneElement(
+ c,
+ newProps
+ );
+ }
}
return /*#__PURE__*/ _react["default"].cloneElement(c, {Serverless Mode (Increase detected ⚠️ )
General Overall decrease ✓
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| buildDuration | 12.5s | 12.7s | |
| nodeModulesSize | 82.4 MB | 82.4 MB | -4.54 kB |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| 677f882d2ed8..8b6e.js gzip | 12.8 kB | 12.8 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-3c9ff84..1d7c.js gzip | 6.56 kB | 6.56 kB | ✓ |
| webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59 kB | 59 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-fca3d..2eb1.js gzip | 3.44 kB | N/A | N/A |
| hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
| index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
| link-db223d9..dbd7.js gzip | 1.61 kB | 1.61 kB | ✓ |
| routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
| withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
| _error-01375..90b6.js gzip | N/A | 3.69 kB | N/A |
| Overall change | 8.01 kB | 8.27 kB |
Client Build Manifests Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 321 B | 322 B | |
| Overall change | 321 B | 322 B |
Serverless bundles Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _error.js | 997 kB | 998 kB | |
| 404.html | 2.67 kB | 2.67 kB | ✓ |
| hooks.html | 1.92 kB | 1.92 kB | ✓ |
| index.js | 998 kB | 999 kB | |
| link.js | 1.05 MB | 1.05 MB | |
| routerDirect.js | 1.04 MB | 1.05 MB | |
| withRouter.js | 1.04 MB | 1.05 MB | |
| Overall change | 5.14 MB | 5.15 MB |
Failing test suitesCommit: 8b1048d test/integration/font-optimization/test/index.test.js
Expand output● Font optimization for SSR apps › Font optimization for unreachable font definitions. › should fallback to normal stylesheet if the contents of the fonts are unreachable ● Font optimization for serverless apps › Font optimization for unreachable font definitions. › should fallback to normal stylesheet if the contents of the fonts are unreachable ● Font optimization for emulated serverless apps › Font optimization for unreachable font definitions. › should fallback to normal stylesheet if the contents of the fonts are unreachable |
Stats from current PRDefault Server Mode (Increase detected
|
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| buildDuration | 9.8s | 9.9s | |
| nodeModulesSize | 82.4 MB | 82.4 MB | -3.91 kB |
Page Load Tests Overall decrease ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.026 | 2.37 | |
| / avg req/sec | 1234.05 | 1054.93 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.193 | 1.226 | |
| /error-in-render avg req/sec | 2095.6 | 2039.92 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| 677f882d2ed8..8b6e.js gzip | 12.8 kB | 12.8 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-3c9ff84..1d7c.js gzip | 6.56 kB | 6.56 kB | ✓ |
| webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59 kB | 59 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-fca3d..2eb1.js gzip | 3.44 kB | 3.69 kB | |
| hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
| index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
| link-db223d9..dbd7.js gzip | 1.61 kB | 1.61 kB | ✓ |
| routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
| withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
| Overall change | 8.01 kB | 8.27 kB |
Client Build Manifests Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 321 B | 322 B | |
| Overall change | 321 B | 322 B |
Rendered Page Sizes
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| index.html gzip | 614 B | 614 B | ✓ |
| link.html gzip | 620 B | 620 B | ✓ |
| withRouter.html gzip | 608 B | 608 B | ✓ |
| Overall change | 1.84 kB | 1.84 kB | ✓ |
Diffs
Diff for _buildManifest.js
@@ -2,7 +2,7 @@ self.__BUILD_MANIFEST = {
__rewrites: [],
"/": ["static\u002Fchunks\u002Fpages\u002Findex-283eed3c1520dcc26e8d.js"],
"/_error": [
- "static\u002Fchunks\u002Fpages\u002F_error-9b57cae5694a39479222.js"
+ "static\u002Fchunks\u002Fpages\u002F_error-fbaccf4d6b3c31a2915e.js"
],
"/hooks": [
"static\u002Fchunks\u002Fpages\u002Fhooks-bdd2cad07648acf22380.js"Diff for _error-9b57c..a39479222.js
@@ -535,8 +535,23 @@ Also adds support for deduplicated `key` properties
.map(function(c, i) {
var key = c.key || i;
- if (false) {
- var newProps;
+ if (true && !props.inAmpMode) {
+ if (
+ c.type === "link" &&
+ c.props["href"] && // TODO(prateekbh@): Replace this with const from `constants` when the tree shaking works.
+ ["https://fonts.googleapis.com/css"].some(function(url) {
+ return c.props["href"].startsWith(url);
+ })
+ ) {
+ var newProps = _objectSpread({}, c.props || {});
+
+ newProps["data-href"] = newProps["href"];
+ newProps["href"] = undefined;
+ return /*#__PURE__*/ _react["default"].cloneElement(
+ c,
+ newProps
+ );
+ }
}
return /*#__PURE__*/ _react["default"].cloneElement(c, {Serverless Mode (Increase detected ⚠️ )
General Overall decrease ✓
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| buildDuration | 11.9s | 11.9s | -1ms |
| nodeModulesSize | 82.4 MB | 82.4 MB | -3.91 kB |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| 677f882d2ed8..8b6e.js gzip | 12.8 kB | 12.8 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-3c9ff84..1d7c.js gzip | 6.56 kB | 6.56 kB | ✓ |
| webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59 kB | 59 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-fca3d..2eb1.js gzip | 3.44 kB | N/A | N/A |
| hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
| index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
| link-db223d9..dbd7.js gzip | 1.61 kB | 1.61 kB | ✓ |
| routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
| withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
| _error-01375..90b6.js gzip | N/A | 3.69 kB | N/A |
| Overall change | 8.01 kB | 8.27 kB |
Client Build Manifests Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 321 B | 322 B | |
| Overall change | 321 B | 322 B |
Serverless bundles Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _error.js | 997 kB | 999 kB | |
| 404.html | 2.67 kB | 2.67 kB | ✓ |
| hooks.html | 1.92 kB | 1.92 kB | ✓ |
| index.js | 998 kB | 999 kB | |
| link.js | 1.05 MB | 1.05 MB | |
| routerDirect.js | 1.04 MB | 1.05 MB | |
| withRouter.js | 1.04 MB | 1.05 MB | |
| Overall change | 5.14 MB | 5.15 MB |
Failing test suitesCommit: b20c1d0 test/integration/font-optimization/test/index.test.js
Expand output● Font optimization for SSR apps › Font optimization for unreachable font definitions. › should fallback to normal stylesheet if the contents of the fonts are unreachable |
Stats from current PRDefault Server Mode (Increase detected
|
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| buildDuration | 8.9s | 8.8s | -93ms |
| nodeModulesSize | 82.4 MB | 82.4 MB | -3.91 kB |
Page Load Tests Overall decrease ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 1.791 | 2.144 | |
| / avg req/sec | 1396.26 | 1166 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.134 | 1.145 | |
| /error-in-render avg req/sec | 2203.93 | 2183.26 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| 677f882d2ed8..8b6e.js gzip | 12.8 kB | 12.8 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-3c9ff84..1d7c.js gzip | 6.56 kB | 6.56 kB | ✓ |
| webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59 kB | 59 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-fca3d..2eb1.js gzip | 3.44 kB | 3.69 kB | |
| hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
| index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
| link-db223d9..dbd7.js gzip | 1.61 kB | 1.61 kB | ✓ |
| routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
| withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
| Overall change | 8.01 kB | 8.27 kB |
Client Build Manifests Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 321 B | 322 B | |
| Overall change | 321 B | 322 B |
Rendered Page Sizes
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| index.html gzip | 614 B | 614 B | ✓ |
| link.html gzip | 620 B | 620 B | ✓ |
| withRouter.html gzip | 608 B | 608 B | ✓ |
| Overall change | 1.84 kB | 1.84 kB | ✓ |
Diffs
Diff for _buildManifest.js
@@ -2,7 +2,7 @@ self.__BUILD_MANIFEST = {
__rewrites: [],
"/": ["static\u002Fchunks\u002Fpages\u002Findex-283eed3c1520dcc26e8d.js"],
"/_error": [
- "static\u002Fchunks\u002Fpages\u002F_error-9b57cae5694a39479222.js"
+ "static\u002Fchunks\u002Fpages\u002F_error-fbaccf4d6b3c31a2915e.js"
],
"/hooks": [
"static\u002Fchunks\u002Fpages\u002Fhooks-bdd2cad07648acf22380.js"Diff for _error-9b57c..a39479222.js
@@ -535,8 +535,23 @@ Also adds support for deduplicated `key` properties
.map(function(c, i) {
var key = c.key || i;
- if (false) {
- var newProps;
+ if (true && !props.inAmpMode) {
+ if (
+ c.type === "link" &&
+ c.props["href"] && // TODO(prateekbh@): Replace this with const from `constants` when the tree shaking works.
+ ["https://fonts.googleapis.com/css"].some(function(url) {
+ return c.props["href"].startsWith(url);
+ })
+ ) {
+ var newProps = _objectSpread({}, c.props || {});
+
+ newProps["data-href"] = newProps["href"];
+ newProps["href"] = undefined;
+ return /*#__PURE__*/ _react["default"].cloneElement(
+ c,
+ newProps
+ );
+ }
}
return /*#__PURE__*/ _react["default"].cloneElement(c, {Serverless Mode (Increase detected ⚠️ )
General Overall decrease ✓
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| buildDuration | 10.5s | 10.4s | -58ms |
| nodeModulesSize | 82.4 MB | 82.4 MB | -3.91 kB |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| 677f882d2ed8..8b6e.js gzip | 12.8 kB | 12.8 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-3c9ff84..1d7c.js gzip | 6.56 kB | 6.56 kB | ✓ |
| webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59 kB | 59 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-fca3d..2eb1.js gzip | 3.44 kB | N/A | N/A |
| hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
| index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
| link-db223d9..dbd7.js gzip | 1.61 kB | 1.61 kB | ✓ |
| routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
| withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
| _error-01375..90b6.js gzip | N/A | 3.69 kB | N/A |
| Overall change | 8.01 kB | 8.27 kB |
Client Build Manifests Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 321 B | 322 B | |
| Overall change | 321 B | 322 B |
Serverless bundles Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _error.js | 997 kB | 999 kB | |
| 404.html | 2.67 kB | 2.67 kB | ✓ |
| hooks.html | 1.92 kB | 1.92 kB | ✓ |
| index.js | 998 kB | 999 kB | |
| link.js | 1.05 MB | 1.05 MB | |
| routerDirect.js | 1.04 MB | 1.05 MB | |
| withRouter.js | 1.04 MB | 1.05 MB | |
| Overall change | 5.14 MB | 5.15 MB |
Failing test suitesCommit: b1e309a test/integration/font-optimization/test/index.test.js
Expand output● Font optimization for SSR apps › Font optimization for unreachable font definitions. › should fallback to normal stylesheet if the contents of the fonts are unreachable |
Stats from current PRDefault Server Mode (Increase detected
|
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| buildDuration | 9.6s | 9.7s | |
| nodeModulesSize | 82.4 MB | 82.4 MB | -3.91 kB |
Page Load Tests Overall decrease ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 1.915 | 2.36 | |
| / avg req/sec | 1305.37 | 1059.32 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.169 | 1.209 | |
| /error-in-render avg req/sec | 2138.77 | 2068.13 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| 677f882d2ed8..8b6e.js gzip | 12.8 kB | 12.8 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-3c9ff84..1d7c.js gzip | 6.56 kB | 6.56 kB | ✓ |
| webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59 kB | 59 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-fca3d..2eb1.js gzip | 3.44 kB | 3.69 kB | |
| hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
| index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
| link-db223d9..dbd7.js gzip | 1.61 kB | 1.61 kB | ✓ |
| routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
| withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
| Overall change | 8.01 kB | 8.27 kB |
Client Build Manifests Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 321 B | 322 B | |
| Overall change | 321 B | 322 B |
Rendered Page Sizes
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| index.html gzip | 614 B | 614 B | ✓ |
| link.html gzip | 620 B | 620 B | ✓ |
| withRouter.html gzip | 608 B | 608 B | ✓ |
| Overall change | 1.84 kB | 1.84 kB | ✓ |
Diffs
Diff for _buildManifest.js
@@ -2,7 +2,7 @@ self.__BUILD_MANIFEST = {
__rewrites: [],
"/": ["static\u002Fchunks\u002Fpages\u002Findex-283eed3c1520dcc26e8d.js"],
"/_error": [
- "static\u002Fchunks\u002Fpages\u002F_error-9b57cae5694a39479222.js"
+ "static\u002Fchunks\u002Fpages\u002F_error-fbaccf4d6b3c31a2915e.js"
],
"/hooks": [
"static\u002Fchunks\u002Fpages\u002Fhooks-bdd2cad07648acf22380.js"Diff for _error-9b57c..a39479222.js
@@ -535,8 +535,23 @@ Also adds support for deduplicated `key` properties
.map(function(c, i) {
var key = c.key || i;
- if (false) {
- var newProps;
+ if (true && !props.inAmpMode) {
+ if (
+ c.type === "link" &&
+ c.props["href"] && // TODO(prateekbh@): Replace this with const from `constants` when the tree shaking works.
+ ["https://fonts.googleapis.com/css"].some(function(url) {
+ return c.props["href"].startsWith(url);
+ })
+ ) {
+ var newProps = _objectSpread({}, c.props || {});
+
+ newProps["data-href"] = newProps["href"];
+ newProps["href"] = undefined;
+ return /*#__PURE__*/ _react["default"].cloneElement(
+ c,
+ newProps
+ );
+ }
}
return /*#__PURE__*/ _react["default"].cloneElement(c, {Serverless Mode (Increase detected ⚠️ )
General Overall decrease ✓
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| buildDuration | 11.4s | 11.3s | -53ms |
| nodeModulesSize | 82.4 MB | 82.4 MB | -3.91 kB |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| 677f882d2ed8..8b6e.js gzip | 12.8 kB | 12.8 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-3c9ff84..1d7c.js gzip | 6.56 kB | 6.56 kB | ✓ |
| webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59 kB | 59 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-fca3d..2eb1.js gzip | 3.44 kB | N/A | N/A |
| hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
| index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
| link-db223d9..dbd7.js gzip | 1.61 kB | 1.61 kB | ✓ |
| routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
| withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
| _error-01375..90b6.js gzip | N/A | 3.69 kB | N/A |
| Overall change | 8.01 kB | 8.27 kB |
Client Build Manifests Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 321 B | 322 B | |
| Overall change | 321 B | 322 B |
Serverless bundles Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _error.js | 997 kB | 999 kB | |
| 404.html | 2.67 kB | 2.67 kB | ✓ |
| hooks.html | 1.92 kB | 1.92 kB | ✓ |
| index.js | 998 kB | 999 kB | |
| link.js | 1.05 MB | 1.05 MB | |
| routerDirect.js | 1.04 MB | 1.05 MB | |
| withRouter.js | 1.04 MB | 1.05 MB | |
| Overall change | 5.14 MB | 5.15 MB |
Stats from current PRDefault Server Mode (Increase detected
|
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| buildDuration | 9.9s | 9.7s | -186ms |
| nodeModulesSize | 82.4 MB | 82.4 MB | -3.91 kB |
Page Load Tests Overall decrease ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 1.991 | 2.326 | |
| / avg req/sec | 1255.86 | 1074.59 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.293 | 1.282 | -0.01 |
| /error-in-render avg req/sec | 1934.13 | 1950.81 | +16.68 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| 677f882d2ed8..8b6e.js gzip | 12.8 kB | 12.8 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-3c9ff84..1d7c.js gzip | 6.56 kB | 6.56 kB | ✓ |
| webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59 kB | 59 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-fca3d..2eb1.js gzip | 3.44 kB | 3.69 kB | |
| hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
| index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
| link-db223d9..dbd7.js gzip | 1.61 kB | 1.61 kB | ✓ |
| routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
| withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
| Overall change | 8.01 kB | 8.27 kB |
Client Build Manifests Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 321 B | 322 B | |
| Overall change | 321 B | 322 B |
Rendered Page Sizes
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| index.html gzip | 614 B | 614 B | ✓ |
| link.html gzip | 620 B | 620 B | ✓ |
| withRouter.html gzip | 608 B | 608 B | ✓ |
| Overall change | 1.84 kB | 1.84 kB | ✓ |
Diffs
Diff for _buildManifest.js
@@ -2,7 +2,7 @@ self.__BUILD_MANIFEST = {
__rewrites: [],
"/": ["static\u002Fchunks\u002Fpages\u002Findex-283eed3c1520dcc26e8d.js"],
"/_error": [
- "static\u002Fchunks\u002Fpages\u002F_error-9b57cae5694a39479222.js"
+ "static\u002Fchunks\u002Fpages\u002F_error-fbaccf4d6b3c31a2915e.js"
],
"/hooks": [
"static\u002Fchunks\u002Fpages\u002Fhooks-bdd2cad07648acf22380.js"Diff for _error-9b57c..a39479222.js
@@ -535,8 +535,23 @@ Also adds support for deduplicated `key` properties
.map(function(c, i) {
var key = c.key || i;
- if (false) {
- var newProps;
+ if (true && !props.inAmpMode) {
+ if (
+ c.type === "link" &&
+ c.props["href"] && // TODO(prateekbh@): Replace this with const from `constants` when the tree shaking works.
+ ["https://fonts.googleapis.com/css"].some(function(url) {
+ return c.props["href"].startsWith(url);
+ })
+ ) {
+ var newProps = _objectSpread({}, c.props || {});
+
+ newProps["data-href"] = newProps["href"];
+ newProps["href"] = undefined;
+ return /*#__PURE__*/ _react["default"].cloneElement(
+ c,
+ newProps
+ );
+ }
}
return /*#__PURE__*/ _react["default"].cloneElement(c, {Serverless Mode (Increase detected ⚠️ )
General Overall decrease ✓
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| buildDuration | 11.8s | 11.8s | |
| nodeModulesSize | 82.4 MB | 82.4 MB | -3.91 kB |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| 677f882d2ed8..8b6e.js gzip | 12.8 kB | 12.8 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-3c9ff84..1d7c.js gzip | 6.56 kB | 6.56 kB | ✓ |
| webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59 kB | 59 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-fca3d..2eb1.js gzip | 3.44 kB | N/A | N/A |
| hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
| index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
| link-db223d9..dbd7.js gzip | 1.61 kB | 1.61 kB | ✓ |
| routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
| withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
| _error-01375..90b6.js gzip | N/A | 3.69 kB | N/A |
| Overall change | 8.01 kB | 8.27 kB |
Client Build Manifests Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 321 B | 322 B | |
| Overall change | 321 B | 322 B |
Serverless bundles Overall increase ⚠️
| vercel/next.js canary | azukaru/next.js font-redo | Change | |
|---|---|---|---|
| _error.js | 997 kB | 999 kB | |
| 404.html | 2.67 kB | 2.67 kB | ✓ |
| hooks.html | 1.92 kB | 1.92 kB | ✓ |
| index.js | 998 kB | 999 kB | |
| link.js | 1.05 MB | 1.05 MB | |
| routerDirect.js | 1.04 MB | 1.05 MB | |
| withRouter.js | 1.04 MB | 1.05 MB | |
| Overall change | 5.14 MB | 5.15 MB |
prateekbh
changed the title
timneutkens
approved these changes
Dec 4, 2020
|
Unfortunately, this optimization doesn't work when fonts are injected on the fly with https://gist.github.com/kripod/52c0f37ad6c4d5e84b4e3a7bc976f50b Usage example: <GoogleFontsSheet
fonts={{
"Source Sans Pro": [
{ wght: 400 },
{ wght: 400, ital: 1 },
{ wght: 700 },
{ wght: 700, ital: 1 },
],
"Playfair Display": [{ wght: 700 }],
}}
/>While the initially loaded font works fine, when props change, fonts aren't loaded anymore. This could possibly be fixed by allowing the runtime injection of Google Fonts |
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 8, 2020
Noticed Azure tests have started failing after #19758 due to the middleware taking longer than the allotted threshold which adds unexpected logs to stderr. This attempts to resolve these test failures by increasing the allotted time for the middleware when running on Azure. x-ref: https://dev.azure.com/nextjs/next.js/_build/results?buildId=22617&view=logs&jobId=5ee44de4-e310-59d9-0ba5-4a271a649fb0&j=5ee44de4-e310-59d9-0ba5-4a271a649fb0&t=af3fb693-3771-5a1a-ec97-2ba4cc77f25c x-ref: https://dev.azure.com/nextjs/next.js/_build/results?buildId=22619&view=logs&jobId=5ee44de4-e310-59d9-0ba5-4a271a649fb0&j=5ee44de4-e310-59d9-0ba5-4a271a649fb0&t=af3fb693-3771-5a1a-ec97-2ba4cc77f25c
|
I've just opened #20134 to track the issue described in my previous comment. Thank you in advance for looking into it before rolling out font optimizations in a stable release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.