Upgrade Emotion example to React 17 and Emotion 11 and use automatic JSX runtime #18620

karlhorky · 2020-11-01T14:16:17Z

~~‼️ Blocked on #18096~~

Probably resolved here: #18096 (comment)

Ref: emotion-js/emotion#2062
Ref: emotion-js/emotion#2041 (comment)

Example upgrade here: upleveled/next-js-example-sep-2020@f46407e

ijjk · 2020-11-01T14:26:11Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	karlhorky/next.js patch-1	Change
buildDuration	12.8s	13s	⚠️ +188ms
nodeModulesSize	90.1 MB	90.1 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	karlhorky/next.js patch-1	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.517	2.448	-0.07
/ avg req/sec	993.22	1021.31	+28.09
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.322	1.309	-0.01
/error-in-render avg req/sec	1890.42	1909.96	+19.54

Client Bundles (main, webpack, commons)

	vercel/next.js canary	karlhorky/next.js patch-1	Change
677f882d2ed8..3aa9.js gzip	11.3 kB	11.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-a9d3c03..afc6.js gzip	7.35 kB	7.35 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	karlhorky/next.js patch-1	Change
677f882d2ed8..dule.js gzip	7.03 kB	7.03 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-3914a19..dule.js gzip	6.35 kB	6.35 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	karlhorky/next.js patch-1	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-e71be6d..3531.js gzip	1.34 kB	1.34 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-6d15176..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.41 kB	5.41 kB	✓

Client Build Manifests

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	karlhorky/next.js patch-1	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	996 B	996 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode

General

	vercel/next.js canary	karlhorky/next.js patch-1	Change
buildDuration	15s	14.9s	-10ms
nodeModulesSize	90.1 MB	90.1 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	karlhorky/next.js patch-1	Change
677f882d2ed8..3aa9.js gzip	11.3 kB	11.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-a9d3c03..afc6.js gzip	7.35 kB	7.35 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.3 kB	58.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	karlhorky/next.js patch-1	Change
677f882d2ed8..dule.js gzip	7.03 kB	7.03 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-3914a19..dule.js gzip	6.35 kB	6.35 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.1 kB	53.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	karlhorky/next.js patch-1	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-e71be6d..3531.js gzip	1.34 kB	1.34 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.75 kB	7.75 kB	✓

Client Pages Modern

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-6d15176..dule.js gzip	1.31 kB	1.31 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.41 kB	5.41 kB	✓

Client Build Manifests

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_error.js	1.06 MB	1.06 MB	✓
404.html	4.73 kB	4.73 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	✓
link.js	1.11 MB	1.11 MB	✓
routerDirect.js	1.1 MB	1.1 MB	✓
withRouter.js	1.1 MB	1.1 MB	✓
Overall change	5.43 MB	5.43 MB	✓

Commit: 8a113bc

karlhorky · 2020-11-01T14:36:53Z

Hmm... may want to hold off on this until this _jsxs is not defined error is resolved:

#18096 (comment)

Also in Emotion repo: emotion-js/emotion#2064

lfades

@karlhorky 👋 I'll request changes per your comments. Let me know when this is ready to go and I'll review it 🕵️

See #18096 (comment)

vercel · 2020-11-18T18:25:36Z

@karlhorky is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

karlhorky · 2020-11-18T18:30:39Z

Ok, @lfades I have asked #18096 (comment), but I think this is the version of configuration and setup that is currently recommended.

Let's wait to see how I get answered over there, but I think unless there are big surprises this should be good to go.

ijjk · 2020-11-18T18:36:21Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	karlhorky/next.js patch-1	Change
buildDuration	14.9s	14.9s	⚠️ +44ms
nodeModulesSize	85 MB	85 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	karlhorky/next.js patch-1	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.767	2.684	-0.08
/ avg req/sec	903.65	931.42	+27.77
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.637	1.657	⚠️ +0.02
/error-in-render avg req/sec	1527.13	1509.17	⚠️ -17.96

Client Bundles (main, webpack, commons)

	vercel/next.js canary	karlhorky/next.js patch-1	Change
677f882d2ed8..776c.js gzip	12.7 kB	12.7 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-f1a49fb..e45e.js gzip	6.52 kB	6.52 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.9 kB	58.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	karlhorky/next.js patch-1	Change
677f882d2ed8..dule.js gzip	8.26 kB	8.26 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-28351af..dule.js gzip	5.63 kB	5.63 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.6 kB	53.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	karlhorky/next.js patch-1	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_app-3b0cf13..85f8.js gzip	1.28 kB	1.28 kB	✓
_error-6f635..c393.js gzip	3.44 kB	3.44 kB	✓
hooks-d4ffc3..9e0f.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-b618194..5477.js gzip	1.61 kB	1.61 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	8.01 kB	8.01 kB	✓

Client Pages Modern

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-f2fcc..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-9741e7f..dule.js gzip	1.55 kB	1.55 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.64 kB	5.64 kB	✓

Client Build Manifests

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_buildManifest.js gzip	321 B	321 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	650 B	650 B	✓

Rendered Page Sizes

	vercel/next.js canary	karlhorky/next.js patch-1	Change
index.html gzip	966 B	966 B	✓
link.html gzip	974 B	974 B	✓
withRouter.html gzip	959 B	959 B	✓
Overall change	2.9 kB	2.9 kB	✓

Serverless Mode

General

	vercel/next.js canary	karlhorky/next.js patch-1	Change
buildDuration	16.9s	17s	⚠️ +120ms
nodeModulesSize	85 MB	85 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	karlhorky/next.js patch-1	Change
677f882d2ed8..776c.js gzip	12.7 kB	12.7 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-f1a49fb..e45e.js gzip	6.52 kB	6.52 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.9 kB	58.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	karlhorky/next.js patch-1	Change
677f882d2ed8..dule.js gzip	8.26 kB	8.26 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-28351af..dule.js gzip	5.63 kB	5.63 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.6 kB	53.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	karlhorky/next.js patch-1	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_app-3b0cf13..85f8.js gzip	1.28 kB	1.28 kB	✓
_error-6f635..c393.js gzip	3.44 kB	3.44 kB	✓
hooks-d4ffc3..9e0f.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-b618194..5477.js gzip	1.61 kB	1.61 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	8.01 kB	8.01 kB	✓

Client Pages Modern

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-f2fcc..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-9741e7f..dule.js gzip	1.55 kB	1.55 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.64 kB	5.64 kB	✓

Client Build Manifests

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_buildManifest.js gzip	321 B	321 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	650 B	650 B	✓

Serverless bundles

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_error.js	918 kB	918 kB	✓
404.html	4.61 kB	4.61 kB	✓
hooks.html	3.86 kB	3.86 kB	✓
index.js	918 kB	918 kB	✓
link.js	977 kB	977 kB	✓
routerDirect.js	969 kB	969 kB	✓
withRouter.js	969 kB	969 kB	✓
Overall change	4.76 MB	4.76 MB	✓

Commit: 681a441

ijjk · 2020-11-18T18:37:08Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	karlhorky/next.js patch-1	Change
buildDuration	12.3s	12.6s	⚠️ +274ms
nodeModulesSize	85 MB	85 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	karlhorky/next.js patch-1	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.229	2.459	⚠️ +0.23
/ avg req/sec	1121.54	1016.52	⚠️ -105.02
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.234	1.266	⚠️ +0.03
/error-in-render avg req/sec	2026.72	1974.88	⚠️ -51.84

Client Bundles (main, webpack, commons)

	vercel/next.js canary	karlhorky/next.js patch-1	Change
677f882d2ed8..776c.js gzip	12.7 kB	12.7 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-f1a49fb..e45e.js gzip	6.52 kB	6.52 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.9 kB	58.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	karlhorky/next.js patch-1	Change
677f882d2ed8..dule.js gzip	8.26 kB	8.26 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-28351af..dule.js gzip	5.63 kB	5.63 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.6 kB	53.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	karlhorky/next.js patch-1	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_app-3b0cf13..85f8.js gzip	1.28 kB	1.28 kB	✓
_error-6f635..c393.js gzip	3.44 kB	3.44 kB	✓
hooks-d4ffc3..9e0f.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-b618194..5477.js gzip	1.61 kB	1.61 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	8.01 kB	8.01 kB	✓

Client Pages Modern

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-f2fcc..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-9741e7f..dule.js gzip	1.55 kB	1.55 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.64 kB	5.64 kB	✓

Client Build Manifests

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_buildManifest.js gzip	321 B	321 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	650 B	650 B	✓

Rendered Page Sizes

	vercel/next.js canary	karlhorky/next.js patch-1	Change
index.html gzip	966 B	966 B	✓
link.html gzip	974 B	974 B	✓
withRouter.html gzip	959 B	959 B	✓
Overall change	2.9 kB	2.9 kB	✓

Serverless Mode

General

	vercel/next.js canary	karlhorky/next.js patch-1	Change
buildDuration	15s	14.9s	-16ms
nodeModulesSize	85 MB	85 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	karlhorky/next.js patch-1	Change
677f882d2ed8..776c.js gzip	12.7 kB	12.7 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-f1a49fb..e45e.js gzip	6.52 kB	6.52 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.9 kB	58.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	karlhorky/next.js patch-1	Change
677f882d2ed8..dule.js gzip	8.26 kB	8.26 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-28351af..dule.js gzip	5.63 kB	5.63 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	53.6 kB	53.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	karlhorky/next.js patch-1	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_app-3b0cf13..85f8.js gzip	1.28 kB	1.28 kB	✓
_error-6f635..c393.js gzip	3.44 kB	3.44 kB	✓
hooks-d4ffc3..9e0f.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-b618194..5477.js gzip	1.61 kB	1.61 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	8.01 kB	8.01 kB	✓

Client Pages Modern

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-f2fcc..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-9741e7f..dule.js gzip	1.55 kB	1.55 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.64 kB	5.64 kB	✓

Client Build Manifests

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_buildManifest.js gzip	321 B	321 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	650 B	650 B	✓

Serverless bundles

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_error.js	918 kB	918 kB	✓
404.html	4.61 kB	4.61 kB	✓
hooks.html	3.86 kB	3.86 kB	✓
index.js	918 kB	918 kB	✓
link.js	977 kB	977 kB	✓
routerDirect.js	969 kB	969 kB	✓
withRouter.js	969 kB	969 kB	✓
Overall change	4.76 MB	4.76 MB	✓

Commit: d8bf38d

ijjk · 2020-11-18T18:38:05Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	karlhorky/next.js patch-1	Change
buildDuration	9.9s	10.1s	⚠️ +177ms
nodeModulesSize	84.9 MB	84.9 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	karlhorky/next.js patch-1	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.247	2.24	-0.01
/ avg req/sec	1112.5	1115.92	+3.42
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.295	1.281	-0.01
/error-in-render avg req/sec	1931.13	1951.39	+20.26

Client Bundles (main, webpack, commons)

	vercel/next.js canary	karlhorky/next.js patch-1	Change
677f882d2ed8..4972.js gzip	12.7 kB	12.7 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-f1a49fb..e45e.js gzip	6.52 kB	6.52 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.9 kB	58.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	karlhorky/next.js patch-1	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_app-3b0cf13..85f8.js gzip	1.28 kB	1.28 kB	✓
_error-6f635..c393.js gzip	3.44 kB	3.44 kB	✓
hooks-d4ffc3..9e0f.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-b618194..5477.js gzip	1.61 kB	1.61 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	8.01 kB	8.01 kB	✓

Client Build Manifests

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	karlhorky/next.js patch-1	Change
index.html gzip	613 B	613 B	✓
link.html gzip	621 B	621 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	karlhorky/next.js patch-1	Change
buildDuration	11.5s	11.6s	⚠️ +80ms
nodeModulesSize	84.9 MB	84.9 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	karlhorky/next.js patch-1	Change
677f882d2ed8..4972.js gzip	12.7 kB	12.7 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-f1a49fb..e45e.js gzip	6.52 kB	6.52 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.9 kB	58.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	karlhorky/next.js patch-1	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_app-3b0cf13..85f8.js gzip	1.28 kB	1.28 kB	✓
_error-6f635..c393.js gzip	3.44 kB	3.44 kB	✓
hooks-d4ffc3..9e0f.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-b618194..5477.js gzip	1.61 kB	1.61 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	8.01 kB	8.01 kB	✓

Client Build Manifests

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_error.js	914 kB	914 kB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	915 kB	915 kB	✓
link.js	973 kB	973 kB	✓
routerDirect.js	966 kB	966 kB	✓
withRouter.js	966 kB	966 kB	✓
Overall change	4.74 MB	4.74 MB	✓

Commit: fa629d7

examples/with-emotion/package.json

ijjk · 2020-11-18T18:58:45Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	karlhorky/next.js patch-1	Change
buildDuration	10.9s	11s	⚠️ +105ms
nodeModulesSize	84.9 MB	84.9 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	karlhorky/next.js patch-1	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.605	2.54	-0.06
/ avg req/sec	959.57	984.26	+24.69
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.667	1.619	-0.05
/error-in-render avg req/sec	1499.51	1544.59	+45.08

Client Bundles (main, webpack, commons)

	vercel/next.js canary	karlhorky/next.js patch-1	Change
677f882d2ed8..4972.js gzip	12.7 kB	12.7 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-f1a49fb..e45e.js gzip	6.52 kB	6.52 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.9 kB	58.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	karlhorky/next.js patch-1	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_app-3b0cf13..85f8.js gzip	1.28 kB	1.28 kB	✓
_error-6f635..c393.js gzip	3.44 kB	3.44 kB	✓
hooks-d4ffc3..9e0f.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-b618194..5477.js gzip	1.61 kB	1.61 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	8.01 kB	8.01 kB	✓

Client Build Manifests

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	karlhorky/next.js patch-1	Change
index.html gzip	613 B	613 B	✓
link.html gzip	621 B	621 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	karlhorky/next.js patch-1	Change
buildDuration	12.8s	12.9s	⚠️ +126ms
nodeModulesSize	84.9 MB	84.9 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	karlhorky/next.js patch-1	Change
677f882d2ed8..4972.js gzip	12.7 kB	12.7 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-f1a49fb..e45e.js gzip	6.52 kB	6.52 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.9 kB	58.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	karlhorky/next.js patch-1	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_app-3b0cf13..85f8.js gzip	1.28 kB	1.28 kB	✓
_error-6f635..c393.js gzip	3.44 kB	3.44 kB	✓
hooks-d4ffc3..9e0f.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-b618194..5477.js gzip	1.61 kB	1.61 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	8.01 kB	8.01 kB	✓

Client Build Manifests

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_error.js	914 kB	914 kB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	915 kB	915 kB	✓
link.js	973 kB	973 kB	✓
routerDirect.js	966 kB	966 kB	✓
withRouter.js	966 kB	966 kB	✓
Overall change	4.74 MB	4.74 MB	✓

Commit: 3e90856

karlhorky · 2020-11-18T22:49:16Z

Ok @lfades, looks like we have a thumbs-up on this setup: #18096 (comment)

Per #19233 (comment)

karlhorky · 2020-11-19T12:52:40Z

@lfades I've also removed the with-emotion-11 example in 32a668c, per #19233 (comment)

ijjk · 2020-11-19T13:00:10Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	karlhorky/next.js patch-1	Change
buildDuration	10.4s	10.1s	-284ms
nodeModulesSize	84.9 MB	84.9 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	karlhorky/next.js patch-1	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.266	2.25	-0.02
/ avg req/sec	1103.27	1111.34	+8.07
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.254	1.273	⚠️ +0.02
/error-in-render avg req/sec	1993.03	1963.75	⚠️ -29.28

Client Bundles (main, webpack, commons)

	vercel/next.js canary	karlhorky/next.js patch-1	Change
677f882d2ed8..4972.js gzip	12.7 kB	12.7 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-f1a49fb..e45e.js gzip	6.52 kB	6.52 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.9 kB	58.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	karlhorky/next.js patch-1	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_app-3b0cf13..85f8.js gzip	1.28 kB	1.28 kB	✓
_error-6f635..c393.js gzip	3.44 kB	3.44 kB	✓
hooks-d4ffc3..9e0f.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-b618194..5477.js gzip	1.61 kB	1.61 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	8.01 kB	8.01 kB	✓

Client Build Manifests

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	karlhorky/next.js patch-1	Change
index.html gzip	613 B	613 B	✓
link.html gzip	621 B	621 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	karlhorky/next.js patch-1	Change
buildDuration	12.2s	11.7s	-441ms
nodeModulesSize	84.9 MB	84.9 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	karlhorky/next.js patch-1	Change
677f882d2ed8..4972.js gzip	12.7 kB	12.7 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-f1a49fb..e45e.js gzip	6.52 kB	6.52 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.9 kB	58.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	karlhorky/next.js patch-1	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_app-3b0cf13..85f8.js gzip	1.28 kB	1.28 kB	✓
_error-6f635..c393.js gzip	3.44 kB	3.44 kB	✓
hooks-d4ffc3..9e0f.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-b618194..5477.js gzip	1.61 kB	1.61 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	8.01 kB	8.01 kB	✓

Client Build Manifests

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	karlhorky/next.js patch-1	Change
_error.js	914 kB	914 kB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	915 kB	915 kB	✓
link.js	973 kB	973 kB	✓
routerDirect.js	966 kB	966 kB	✓
withRouter.js	966 kB	966 kB	✓
Overall change	4.74 MB	4.74 MB	✓

Commit: 32a668c

vercel · 2020-11-19T22:46:46Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/nextjs-examples-image-component/esejtio5i
✅ Preview: https://nextjs-examples-image-component-git-patch-1.vercel.vercel.app

lfades

Added some minor updates and it looks good to me! Thank you @karlhorky 💯 🔥

karlhorky · 2020-11-20T09:54:09Z

Great, glad to help! Thanks for your patience and the merge @lfades !

…JSX runtime (vercel#18620) ~~‼️ **Blocked** on vercel#18096 Probably resolved here: vercel#18096 (comment) Ref: emotion-js/emotion#2062 Ref: emotion-js/emotion#2041 (comment) Example upgrade here: upleveled/next-js-example-sep-2020@f46407e

karlhorky added 2 commits November 1, 2020 15:09

Use automatic JSX runtime

944b94a

Upgrade React to 17 and Emotion packages to 10.1.0

8a113bc

karlhorky requested review from chibicode, ijjk, lfades, Timer and timneutkens as code owners November 1, 2020 14:16

ijjk added the examples Issue was opened via the examples template. label Nov 1, 2020

karlhorky mentioned this pull request Nov 1, 2020

Babel CSS Prop Preset: _jsxs is not defined emotion-js/emotion#2064

Closed

lfades requested changes Nov 12, 2020

View reviewed changes

karlhorky mentioned this pull request Nov 18, 2020

Update with-emotion-11 example to use stable version #19233

Closed

2 tasks

karlhorky changed the title ~~Upgrade Emotion example to React 17 and use automatic JSX runtime~~ Upgrade Emotion example to React 17 and Emotion 11 and use automatic JSX runtime Nov 18, 2020

karlhorky mentioned this pull request Nov 18, 2020

"React is not defined" when using a custom _app.tsx and .babelrc using React 17 #18096

Closed

Upgrade to new configuration

681a441

See #18096 (comment)

karlhorky added 2 commits November 18, 2020 19:27

Upgrade versions

d8bf38d

Switch to @emotion/react

fa629d7

belgattitude reviewed Nov 18, 2020

View reviewed changes

examples/with-emotion/package.json Outdated Show resolved Hide resolved

Fix dependency

3e90856

Remove old example

32a668c

Per #19233 (comment)

lfades added 2 commits November 19, 2020 17:38

Updated package.json

28126ab

Updated readme

9e37eb3

vercel bot temporarily deployed to Preview November 19, 2020 22:46 Inactive

lfades approved these changes Nov 19, 2020

View reviewed changes

Merge branch 'canary' into patch-1

0178414

vercel bot temporarily deployed to Preview November 19, 2020 22:49 Inactive

kodiakhq bot merged commit 65db069 into vercel:canary Nov 19, 2020

karlhorky deleted the patch-1 branch November 20, 2020 09:54

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade Emotion example to React 17 and Emotion 11 and use automatic JSX runtime #18620

Upgrade Emotion example to React 17 and Emotion 11 and use automatic JSX runtime #18620

karlhorky commented Nov 1, 2020 •

edited

Loading

ijjk commented Nov 1, 2020

karlhorky commented Nov 1, 2020 •

edited

Loading

lfades left a comment

vercel bot commented Nov 18, 2020

karlhorky commented Nov 18, 2020 •

edited

Loading

ijjk commented Nov 18, 2020

ijjk commented Nov 18, 2020

ijjk commented Nov 18, 2020

ijjk commented Nov 18, 2020

karlhorky commented Nov 18, 2020 •

edited

Loading

karlhorky commented Nov 19, 2020

ijjk commented Nov 19, 2020

vercel bot commented Nov 19, 2020 •

edited

Loading

lfades left a comment

karlhorky commented Nov 20, 2020

Upgrade Emotion example to React 17 and Emotion 11 and use automatic JSX runtime #18620

Upgrade Emotion example to React 17 and Emotion 11 and use automatic JSX runtime #18620

Conversation

karlhorky commented Nov 1, 2020 • edited Loading

ijjk commented Nov 1, 2020

Stats from current PR

karlhorky commented Nov 1, 2020 • edited Loading

lfades left a comment

Choose a reason for hiding this comment

vercel bot commented Nov 18, 2020

karlhorky commented Nov 18, 2020 • edited Loading

ijjk commented Nov 18, 2020

Stats from current PR

ijjk commented Nov 18, 2020

Stats from current PR

ijjk commented Nov 18, 2020

Stats from current PR

ijjk commented Nov 18, 2020

Stats from current PR

karlhorky commented Nov 18, 2020 • edited Loading

karlhorky commented Nov 19, 2020

ijjk commented Nov 19, 2020

Stats from current PR

vercel bot commented Nov 19, 2020 • edited Loading

lfades left a comment

Choose a reason for hiding this comment

karlhorky commented Nov 20, 2020

karlhorky commented Nov 1, 2020 •

edited

Loading

karlhorky commented Nov 1, 2020 •

edited

Loading

karlhorky commented Nov 18, 2020 •

edited

Loading

karlhorky commented Nov 18, 2020 •

edited

Loading

vercel bot commented Nov 19, 2020 •

edited

Loading