change anonymous functions to named in docs examples #17510

Jashnm · 2020-10-01T04:25:30Z

ijjk · 2020-10-01T04:36:29Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
buildDuration	14.1s	14.4s	⚠️ +284ms
nodeModulesSize	62.9 MB	62.9 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.647	2.681	⚠️ +0.03
/ avg req/sec	944.59	932.66	⚠️ -11.93
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.653	1.566	-0.09
/error-in-render avg req/sec	1512.7	1596.15	+83.45

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-d493e7d..42f5.js gzip	7.17 kB	7.17 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.8 kB	57.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-f8905d4..dule.js gzip	6.24 kB	6.24 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	996 B	996 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode

General

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
buildDuration	16.2s	15.9s	-283ms
nodeModulesSize	62.9 MB	62.9 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-d493e7d..42f5.js gzip	7.17 kB	7.17 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.8 kB	57.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-f8905d4..dule.js gzip	6.24 kB	6.24 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
_error.js	1.05 MB	1.05 MB	✓
404.html	4.34 kB	4.34 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.05 MB	1.05 MB	✓
link.js	1.1 MB	1.1 MB	✓
routerDirect.js	1.09 MB	1.09 MB	✓
withRouter.js	1.09 MB	1.09 MB	✓
Overall change	5.4 MB	5.4 MB	✓

Commit: f10ebd6

ijjk · 2020-10-02T17:19:15Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
buildDuration	12.5s	12.4s	-17ms
nodeModulesSize	63.1 MB	63.1 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.279	2.441	⚠️ +0.16
/ avg req/sec	1096.86	1024.36	⚠️ -72.5
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.454	1.609	⚠️ +0.16
/error-in-render avg req/sec	1719.05	1553.85	⚠️ -165.2

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-d493e7d..42f5.js gzip	7.17 kB	7.17 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.8 kB	57.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-f8905d4..dule.js gzip	6.24 kB	6.24 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	996 B	996 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode

General

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
buildDuration	13.8s	13.9s	⚠️ +101ms
nodeModulesSize	63.1 MB	63.1 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-d493e7d..42f5.js gzip	7.17 kB	7.17 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.8 kB	57.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-f8905d4..dule.js gzip	6.24 kB	6.24 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
_error.js	1.05 MB	1.05 MB	✓
404.html	4.34 kB	4.34 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.05 MB	1.05 MB	✓
link.js	1.1 MB	1.1 MB	✓
routerDirect.js	1.09 MB	1.09 MB	✓
withRouter.js	1.09 MB	1.09 MB	✓
Overall change	5.4 MB	5.4 MB	✓

Commit: 810b8ed

lfades

Same review as here: #17549 (review)

Although I would prefer for all the api functions to be called handler!

ijjk · 2020-10-05T08:59:54Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
buildDuration	11.4s	11.6s	⚠️ +117ms
nodeModulesSize	63.2 MB	63.2 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.141	2.134	-0.01
/ avg req/sec	1167.45	1171.65	+4.2
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.118	1.068	-0.05
/error-in-render avg req/sec	2237	2339.8	+102.8

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-d493e7d..42f5.js gzip	7.17 kB	7.17 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.8 kB	57.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-f8905d4..dule.js gzip	6.24 kB	6.24 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	996 B	996 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode

General

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
buildDuration	12.9s	12.8s	-137ms
nodeModulesSize	63.2 MB	63.2 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-d493e7d..42f5.js gzip	7.17 kB	7.17 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.8 kB	57.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-f8905d4..dule.js gzip	6.24 kB	6.24 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
_error.js	1.05 MB	1.05 MB	✓
404.html	4.34 kB	4.34 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.05 MB	1.05 MB	✓
link.js	1.1 MB	1.1 MB	✓
routerDirect.js	1.09 MB	1.09 MB	✓
withRouter.js	1.09 MB	1.09 MB	✓
Overall change	5.4 MB	5.4 MB	✓

Commit: 4d82ef9

Jashnm · 2020-10-05T09:00:04Z

Same review as here: #17549 (review)

Although I would prefer for all the api functions to be called handler!

For simplicity, I renamed the functions to handler

lfades

Thank you!

ijjk · 2020-10-05T21:05:58Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
buildDuration	14.1s	14.4s	⚠️ +326ms
nodeModulesSize	63.2 MB	63.2 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.631	2.745	⚠️ +0.11
/ avg req/sec	950.27	910.69	⚠️ -39.58
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.605	1.681	⚠️ +0.08
/error-in-render avg req/sec	1557.97	1487.62	⚠️ -70.35

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-d493e7d..42f5.js gzip	7.17 kB	7.17 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.8 kB	57.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-f8905d4..dule.js gzip	6.24 kB	6.24 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	996 B	996 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode

General

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
buildDuration	15.5s	15.6s	⚠️ +118ms
nodeModulesSize	63.2 MB	63.2 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-d493e7d..42f5.js gzip	7.17 kB	7.17 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.8 kB	57.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-f8905d4..dule.js gzip	6.24 kB	6.24 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles

	vercel/next.js canary	Jashnm/next.js named_func_docs	Change
_error.js	1.05 MB	1.05 MB	✓
404.html	4.34 kB	4.34 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.05 MB	1.05 MB	✓
link.js	1.1 MB	1.1 MB	✓
routerDirect.js	1.09 MB	1.09 MB	✓
withRouter.js	1.09 MB	1.09 MB	✓
Overall change	5.4 MB	5.4 MB	✓

Commit: 3a63cd8

Jashnm requested review from chibicode, ijjk, lfades, Timer and timneutkens as code owners October 1, 2020 04:25

ijjk added the type: documentation label Oct 1, 2020

awareness481 mentioned this pull request Oct 2, 2020

Gave names to anonymous functions in the docs. Tried to be as semantic as possible. #17549

Closed

lfades requested changes Oct 5, 2020

View reviewed changes

Jashnm added 2 commits October 5, 2020 14:02

change anonymous functions to named in docs examples

9399f7f

change anonymous functions to named in docs example

4d82ef9

Jashnm force-pushed the named_func_docs branch from 810b8ed to 4d82ef9 Compare October 5, 2020 08:50

Jashnm requested a review from lfades October 5, 2020 08:58

lfades approved these changes Oct 5, 2020

View reviewed changes

Merge branch 'canary' into named_func_docs

3a63cd8

kodiakhq bot merged commit 7dec911 into vercel:canary Oct 5, 2020

ijjk added the hacktoberfest-accepted label Oct 12, 2020

dependabot bot mentioned this pull request Mar 18, 2021

build(deps): bump next from 9.5.0 to 9.5.4 BrasilAPI/BrasilAPI#281

Closed

This was referenced Apr 15, 2021

[Snyk] Security upgrade next from 9.4.1 to 9.5.4 Jcrowell74/next.js#70

Open

[Snyk] Security upgrade next from 9.4.4 to 9.5.4 Jcrowell74/next.js#71

Open

[Snyk] Security upgrade next from 9.4.4 to 9.5.4 Jcrowell74/next.js#73

Open

snyk-bot mentioned this pull request Apr 25, 2021

[Snyk] Security upgrade next from 9.4.1 to 9.5.4 majacQ/next.js#36

Merged

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

change anonymous functions to named in docs examples #17510

change anonymous functions to named in docs examples #17510

Jashnm commented Oct 1, 2020 •

edited by lfades

Loading

ijjk commented Oct 1, 2020

ijjk commented Oct 2, 2020

lfades left a comment

ijjk commented Oct 5, 2020

Jashnm commented Oct 5, 2020 •

edited

Loading

lfades left a comment

ijjk commented Oct 5, 2020

change anonymous functions to named in docs examples #17510

change anonymous functions to named in docs examples #17510

Conversation

Jashnm commented Oct 1, 2020 • edited by lfades Loading

ijjk commented Oct 1, 2020

Stats from current PR

ijjk commented Oct 2, 2020

Stats from current PR

lfades left a comment

Choose a reason for hiding this comment

ijjk commented Oct 5, 2020

Stats from current PR

Jashnm commented Oct 5, 2020 • edited Loading

lfades left a comment

Choose a reason for hiding this comment

ijjk commented Oct 5, 2020

Stats from current PR

Jashnm commented Oct 1, 2020 •

edited by lfades

Loading

Jashnm commented Oct 5, 2020 •

edited

Loading