Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Example] With TS Eslint Jest - unnecessary package #17170

Merged
merged 3 commits into from
Sep 21, 2020
Merged

[Example] With TS Eslint Jest - unnecessary package #17170

merged 3 commits into from
Sep 21, 2020

Conversation

devinekadeni
Copy link
Contributor

As mentioned in here, the package has been deprecated and not necessary to be installed.
By removing this from package.json will give other devs have more understanding when learning typescript with eslint and jest about what need to be installed on the project.

@devinekadeni
chore: Remove unused library @types/testing-library__react
d533e61 
as mentioned in [here](https://www.npmjs.com/package/@types/testing-library__react) the package has been deprecated and not necessary to be installed.
By removing this from package.json will give other devs have more understanding when learning typescript with eslint and jest
@ijjk ijjk added the examples Issue/PR related to examples label Sep 17, 2020
@ijjk
Copy link
Member

ijjk commented Sep 17, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
buildDuration 13.8s 13.3s -553ms
nodeModulesSize 62.9 MB 62.9 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.561 2.503 -0.06
/ avg req/sec 976.05 998.76 +22.71
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.518 1.447 -0.07
/error-in-render avg req/sec 1647.24 1727.12 +79.88
Client Bundles (main, webpack, commons)
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
677f882d2ed8..9339.js gzip 10.9 kB 10.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-772ea11..1d22.js gzip 7.16 kB 7.16 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.8 kB 57.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-911f3f8..dule.js gzip 6.23 kB 6.23 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 997 B 997 B ✓
Overall change 3.01 kB 3.01 kB ✓
Serverless Mode
General
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
buildDuration 15.7s 15s -657ms
nodeModulesSize 62.9 MB 62.9 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
677f882d2ed8..9339.js gzip 10.9 kB 10.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-772ea11..1d22.js gzip 7.16 kB 7.16 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.8 kB 57.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-911f3f8..dule.js gzip 6.23 kB 6.23 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
_error.js 1.04 MB 1.04 MB ✓
404.html 4.34 kB 4.34 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.04 MB 1.04 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.08 MB 1.08 MB ✓
withRouter.js 1.08 MB 1.08 MB ✓
Overall change 5.31 MB 5.31 MB ✓
Commit: d533e61

@ijjk
Copy link
Member

ijjk commented Sep 20, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
buildDuration 13.5s 14s ⚠️ +506ms
nodeModulesSize 62.9 MB 62.9 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.574 2.482 -0.09
/ avg req/sec 971.31 1007.12 +35.81
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.518 1.508 -0.01
/error-in-render avg req/sec 1646.64 1657.97 +11.33
Client Bundles (main, webpack, commons)
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
677f882d2ed8..9339.js gzip 10.9 kB 10.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-772ea11..1d22.js gzip 7.16 kB 7.16 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.8 kB 57.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-911f3f8..dule.js gzip 6.23 kB 6.23 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 997 B 997 B ✓
Overall change 3.01 kB 3.01 kB ✓
Serverless Mode
General
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
buildDuration 14.6s 14.9s ⚠️ +287ms
nodeModulesSize 62.9 MB 62.9 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
677f882d2ed8..9339.js gzip 10.9 kB 10.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-772ea11..1d22.js gzip 7.16 kB 7.16 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.8 kB 57.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-911f3f8..dule.js gzip 6.23 kB 6.23 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
_error.js 1.04 MB 1.04 MB ✓
404.html 4.34 kB 4.34 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.04 MB 1.04 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.08 MB 1.08 MB ✓
withRouter.js 1.08 MB 1.08 MB ✓
Overall change 5.31 MB 5.31 MB ✓
Commit: 44f2ba8

lfades
lfades approved these changes Sep 21, 2020
View reviewed changes
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@ijjk
Copy link
Member

ijjk commented Sep 21, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
buildDuration 12.4s 12.7s ⚠️ +308ms
nodeModulesSize 62.9 MB 62.9 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.585 2.482 -0.1
/ avg req/sec 967.02 1007.08 +40.06
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.587 1.454 -0.13
/error-in-render avg req/sec 1575.72 1719.02 +143.3
Client Bundles (main, webpack, commons)
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
677f882d2ed8..9339.js gzip 10.9 kB 10.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-772ea11..1d22.js gzip 7.16 kB 7.16 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.8 kB 57.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-911f3f8..dule.js gzip 6.23 kB 6.23 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 997 B 997 B ✓
Overall change 3.01 kB 3.01 kB ✓
Serverless Mode
General
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
buildDuration 14.3s 14s -366ms
nodeModulesSize 62.9 MB 62.9 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
677f882d2ed8..9339.js gzip 10.9 kB 10.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-772ea11..1d22.js gzip 7.16 kB 7.16 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.8 kB 57.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-911f3f8..dule.js gzip 6.23 kB 6.23 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary devinekadeni/next.js example/with-typescript-eslint-jest Change
_error.js 1.04 MB 1.04 MB ✓
404.html 4.34 kB 4.34 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.04 MB 1.04 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.08 MB 1.08 MB ✓
withRouter.js 1.08 MB 1.08 MB ✓
Overall change 5.31 MB 5.31 MB ✓
Commit: 8009235

@kodiakhq kodiakhq bot merged commit 4f1ccda into vercel:canary Sep 21, 2020
@devinekadeni devinekadeni deleted the example/with-typescript-eslint-jest branch September 21, 2020 04:17
HitoriSensei pushed a commit to HitoriSensei/next.js that referenced this pull request Sep 26, 2020
@devinekadeni
[Example] With TS Eslint Jest - unnecessary package (vercel#17170)
b8f0b48 
As mentioned in [here](https://www.npmjs.com/package/@types/testing-library__react), the package has been deprecated and not necessary to be installed.
By removing this from `package.json` will give other devs have more understanding when learning typescript with eslint and jest about what need to be installed on the project.
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lfades lfades lfades approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devinekadeni @ijjk @lfades