Use babel 7 jsx syntax #17043

TrySound · 2020-09-12T15:23:44Z

For some reason babel-plugin-syntax-jsx of babel 6 was used instead of
babel 7 version.

For some reason babel-plugin-syntax-jsx of babel 6 was used instead of babel 7 version.

ijjk · 2020-09-12T15:32:36Z

Failing test suites

Commit: b5723fe

test/integration/build-warnings/test/index.test.js

Build warnings > should not shown warning about minification withou any modification
Build warnings > should shown warning about minification for minimize
Build warnings > should shown warning about minification for minimizer

Expand output

● Build warnings › should not shown warning about minification withou any modification

expect(received).not.toContain(expected) // indexOf

Expected substring: not "optimization has been disabled"
Received string:        "warn  - Production code optimization has been disabled in your project. Read more: https://err.sh/vercel/next.js/minification-disabled
"

  11 |   it('should not shown warning about minification withou any modification', async () => {
  12 |     const { stderr } = await nextBuild(appDir, undefined, { stderr: true })
> 13 |     expect(stderr).not.toContain('optimization has been disabled')
     |                        ^
  14 |   })
  15 | 
  16 |   it('should shown warning about minification for minimize', async () => {

  at Object.<anonymous> (integration/build-warnings/test/index.test.js:13:24)

● Build warnings › should shown warning about minification for minimize

Failed to replace content.

Pattern: true

Content: module.exports = {
  webpack: (config) => {
    config.optimization.minimizer = []
    return config
  },
}

  407 |     } else if (typeof pattern === 'string') {
  408 |       if (!currentContent.includes(pattern)) {
> 409 |         throw new Error(
      |               ^
  410 |           `Failed to replace content.\n\nPattern: ${pattern}\n\nContent: ${currentContent}`
  411 |         )
  412 |       }

  at File.replace (lib/next-test-utils.js:409:15)
  at Object.<anonymous> (integration/build-warnings/test/index.test.js:21:16)

● Build warnings › should shown warning about minification for minimizer

Failed to replace content.

Pattern: config.optimization.minimize = true

Content: module.exports = {
  webpack: (config) => {
    config.optimization.minimizer = []
    return config
  },
}

  407 |     } else if (typeof pattern === 'string') {
  408 |       if (!currentContent.includes(pattern)) {
> 409 |         throw new Error(
      |               ^
  410 |           `Failed to replace content.\n\nPattern: ${pattern}\n\nContent: ${currentContent}`
  411 |         )
  412 |       }

  at File.replace (lib/next-test-utils.js:409:15)
  at Object.<anonymous> (integration/build-warnings/test/index.test.js:35:16)

ijjk · 2020-09-12T15:33:36Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
buildDuration	13s	13s	⚠️ +19ms
nodeModulesSize	60 MB	60 MB	⚠️ +326 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.341	2.31	-0.03
/ avg req/sec	1068	1082.06	+14.06
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.216	1.278	⚠️ +0.06
/error-in-render avg req/sec	2056.7	1956.42	⚠️ -100.28

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-3d83558..e210.js gzip	7.02 kB	7.02 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.6 kB	57.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-0a101e0..dule.js gzip	6.09 kB	6.09 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.6 kB	52.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	996 B	996 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
buildDuration	14.7s	14.5s	-248ms
nodeModulesSize	60 MB	60 MB	⚠️ +326 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-3d83558..e210.js gzip	7.02 kB	7.02 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.6 kB	57.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-0a101e0..dule.js gzip	6.09 kB	6.09 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.6 kB	52.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
_error.js	1.03 MB	1.03 MB	✓
404.html	4.34 kB	4.34 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.04 MB	1.04 MB	✓
link.js	1.08 MB	1.08 MB	✓
routerDirect.js	1.07 MB	1.07 MB	✓
withRouter.js	1.07 MB	1.07 MB	✓
Overall change	5.31 MB	5.31 MB	✓

Commit: b5723fe

ijjk · 2020-09-12T15:34:14Z

Failing test suites

Commit: 82129e9

test/integration/build-warnings/test/index.test.js

Build warnings > should not shown warning about minification withou any modification
Build warnings > should shown warning about minification for minimize
Build warnings > should shown warning about minification for minimizer

Expand output

● Build warnings › should not shown warning about minification withou any modification

expect(received).not.toContain(expected) // indexOf

Expected substring: not "optimization has been disabled"
Received string:        "warn  - Production code optimization has been disabled in your project. Read more: https://err.sh/vercel/next.js/minification-disabled
"

  11 |   it('should not shown warning about minification withou any modification', async () => {
  12 |     const { stderr } = await nextBuild(appDir, undefined, { stderr: true })
> 13 |     expect(stderr).not.toContain('optimization has been disabled')
     |                        ^
  14 |   })
  15 | 
  16 |   it('should shown warning about minification for minimize', async () => {

  at Object.<anonymous> (integration/build-warnings/test/index.test.js:13:24)

● Build warnings › should shown warning about minification for minimize

Failed to replace content.

Pattern: true

Content: module.exports = {
  webpack: (config) => {
    config.optimization.minimizer = []
    return config
  },
}

  407 |     } else if (typeof pattern === 'string') {
  408 |       if (!currentContent.includes(pattern)) {
> 409 |         throw new Error(
      |               ^
  410 |           `Failed to replace content.\n\nPattern: ${pattern}\n\nContent: ${currentContent}`
  411 |         )
  412 |       }

  at File.replace (lib/next-test-utils.js:409:15)
  at Object.<anonymous> (integration/build-warnings/test/index.test.js:21:16)

● Build warnings › should shown warning about minification for minimizer

Failed to replace content.

Pattern: config.optimization.minimize = true

Content: module.exports = {
  webpack: (config) => {
    config.optimization.minimizer = []
    return config
  },
}

  407 |     } else if (typeof pattern === 'string') {
  408 |       if (!currentContent.includes(pattern)) {
> 409 |         throw new Error(
      |               ^
  410 |           `Failed to replace content.\n\nPattern: ${pattern}\n\nContent: ${currentContent}`
  411 |         )
  412 |       }

  at File.replace (lib/next-test-utils.js:409:15)
  at Object.<anonymous> (integration/build-warnings/test/index.test.js:35:16)

ijjk · 2020-09-12T15:34:15Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
buildDuration	14.1s	14s	-74ms
nodeModulesSize	60 MB	60 MB	⚠️ +326 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.587	2.608	⚠️ +0.02
/ avg req/sec	966.39	958.74	⚠️ -7.65
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.562	1.578	⚠️ +0.02
/error-in-render avg req/sec	1600.03	1584.11	⚠️ -15.92

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-3d83558..e210.js gzip	7.02 kB	7.02 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.6 kB	57.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-0a101e0..dule.js gzip	6.09 kB	6.09 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.6 kB	52.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	996 B	996 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
buildDuration	14.9s	15.6s	⚠️ +659ms
nodeModulesSize	60 MB	60 MB	⚠️ +326 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-3d83558..e210.js gzip	7.02 kB	7.02 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.6 kB	57.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-0a101e0..dule.js gzip	6.09 kB	6.09 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.6 kB	52.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
_error.js	1.03 MB	1.03 MB	✓
404.html	4.34 kB	4.34 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.04 MB	1.04 MB	✓
link.js	1.08 MB	1.08 MB	✓
routerDirect.js	1.07 MB	1.07 MB	✓
withRouter.js	1.07 MB	1.07 MB	✓
Overall change	5.31 MB	5.31 MB	✓

Commit: 82129e9

ijjk · 2020-09-12T15:43:52Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
buildDuration	11.4s	11.3s	-74ms
nodeModulesSize	60 MB	60 MB	⚠️ +326 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.97	1.997	⚠️ +0.03
/ avg req/sec	1269.19	1252.09	⚠️ -17.1
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.109	1.107	0
/error-in-render avg req/sec	2254.79	2258.76	+3.97

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-3d83558..e210.js gzip	7.02 kB	7.02 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.6 kB	57.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-0a101e0..dule.js gzip	6.09 kB	6.09 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.6 kB	52.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	996 B	996 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
buildDuration	12.8s	12.3s	-481ms
nodeModulesSize	60 MB	60 MB	⚠️ +326 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-3d83558..e210.js gzip	7.02 kB	7.02 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.6 kB	57.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-0a101e0..dule.js gzip	6.09 kB	6.09 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.6 kB	52.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
_error.js	1.03 MB	1.03 MB	✓
404.html	4.34 kB	4.34 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.04 MB	1.04 MB	✓
link.js	1.08 MB	1.08 MB	✓
routerDirect.js	1.07 MB	1.07 MB	✓
withRouter.js	1.07 MB	1.07 MB	✓
Overall change	5.31 MB	5.31 MB	✓

Commit: 07ccf04

ijjk · 2020-09-12T18:11:43Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
buildDuration	13.5s	13s	-540ms
nodeModulesSize	60 MB	60 MB	⚠️ +326 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.374	2.263	-0.11
/ avg req/sec	1052.88	1104.94	+52.06
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.312	1.331	⚠️ +0.02
/error-in-render avg req/sec	1905.36	1878.9	⚠️ -26.46

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-3d83558..e210.js gzip	7.02 kB	7.02 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.6 kB	57.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-0a101e0..dule.js gzip	6.09 kB	6.09 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.6 kB	52.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	996 B	996 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
buildDuration	14.4s	14.5s	⚠️ +77ms
nodeModulesSize	60 MB	60 MB	⚠️ +326 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-3d83558..e210.js gzip	7.02 kB	7.02 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.6 kB	57.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-0a101e0..dule.js gzip	6.09 kB	6.09 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.6 kB	52.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
_error.js	1.03 MB	1.03 MB	✓
404.html	4.34 kB	4.34 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.04 MB	1.04 MB	✓
link.js	1.08 MB	1.08 MB	✓
routerDirect.js	1.07 MB	1.07 MB	✓
withRouter.js	1.07 MB	1.07 MB	✓
Overall change	5.31 MB	5.31 MB	✓

Commit: 6d34be3

timneutkens · 2020-09-13T12:44:42Z

Thanks! Seems to be a leftover from a long time ago.

ijjk · 2020-09-13T13:16:40Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
buildDuration	13.7s	12.8s	-815ms
nodeModulesSize	60 MB	60 MB	⚠️ +326 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.385	2.362	-0.02
/ avg req/sec	1048.04	1058.46	+10.42
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.415	1.328	-0.09
/error-in-render avg req/sec	1766.26	1883.03	+116.77

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-3d83558..e210.js gzip	7.02 kB	7.02 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.6 kB	57.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-0a101e0..dule.js gzip	6.09 kB	6.09 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.6 kB	52.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	996 B	996 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
buildDuration	14.3s	14.4s	⚠️ +58ms
nodeModulesSize	60 MB	60 MB	⚠️ +326 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-3d83558..e210.js gzip	7.02 kB	7.02 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.6 kB	57.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-0a101e0..dule.js gzip	6.09 kB	6.09 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.6 kB	52.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles

	vercel/next.js canary	TrySound/next.js babel-jsx	Change
_error.js	1.03 MB	1.03 MB	✓
404.html	4.34 kB	4.34 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.04 MB	1.04 MB	✓
link.js	1.08 MB	1.08 MB	✓
routerDirect.js	1.07 MB	1.07 MB	✓
withRouter.js	1.07 MB	1.07 MB	✓
Overall change	5.31 MB	5.31 MB	✓

Commit: 340136f

TrySound · 2020-09-13T13:19:08Z

@timneutkens I found same with styled-jsx and saw babel 6 tests. Maybe it's time to drop old babel support and refresh the package?

For some reason babel-plugin-syntax-jsx of babel 6 was used instead of babel 7 version.

Use babel 7 jsx syntax

82129e9

For some reason babel-plugin-syntax-jsx of babel 6 was used instead of babel 7 version.

TrySound requested review from ijjk, lfades, Timer and timneutkens as code owners September 12, 2020 15:23

ijjk added the type: next label Sep 12, 2020

Merge branch 'canary' into babel-jsx

b5723fe

Revert change made by test

07ccf04

Merge branch 'canary' into babel-jsx

6d34be3

timneutkens approved these changes Sep 13, 2020

View reviewed changes

Merge branch 'canary' into babel-jsx

340136f

kodiakhq bot merged commit 9959d7e into vercel:canary Sep 13, 2020

HitoriSensei pushed a commit to HitoriSensei/next.js that referenced this pull request Sep 26, 2020

Use babel 7 jsx syntax (vercel#17043)

1bbffc1

For some reason babel-plugin-syntax-jsx of babel 6 was used instead of babel 7 version.

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use babel 7 jsx syntax #17043

Use babel 7 jsx syntax #17043

TrySound commented Sep 12, 2020

ijjk commented Sep 12, 2020

ijjk commented Sep 12, 2020

ijjk commented Sep 12, 2020

ijjk commented Sep 12, 2020

ijjk commented Sep 12, 2020

ijjk commented Sep 12, 2020

timneutkens commented Sep 13, 2020

ijjk commented Sep 13, 2020

TrySound commented Sep 13, 2020

Use babel 7 jsx syntax #17043

Use babel 7 jsx syntax #17043

Conversation

TrySound commented Sep 12, 2020

ijjk commented Sep 12, 2020

Failing test suites

ijjk commented Sep 12, 2020

Stats from current PR

ijjk commented Sep 12, 2020

Failing test suites

ijjk commented Sep 12, 2020

Stats from current PR

ijjk commented Sep 12, 2020

Stats from current PR

ijjk commented Sep 12, 2020

Stats from current PR

timneutkens commented Sep 13, 2020

ijjk commented Sep 13, 2020

Stats from current PR

TrySound commented Sep 13, 2020