Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to check for overlay in client nav tests #17002

Merged
merged 1 commit into from
Sep 11, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Sep 10, 2020

Closes: #14433

@ijjk
Copy link
Member Author

ijjk commented Sep 10, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js test/update-err-tests Change
buildDuration 13.6s 13.5s -93ms
nodeModulesSize 57 MB 57 MB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js test/update-err-tests Change
/ failed reqs 0 0
/ total time (seconds) 2.459 2.525 ⚠️ +0.07
/ avg req/sec 1016.77 990.18 ⚠️ -26.59
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.61 1.476 -0.13
/error-in-render avg req/sec 1553.26 1693.32 +140.06
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js test/update-err-tests Change
677f882d2ed8..68c9.js gzip 10.9 kB 10.9 kB
framework.HASH.js gzip 39 kB 39 kB
main-7ae8495..db56.js gzip 7 kB 7 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.6 kB 57.6 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js test/update-err-tests Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-5a735ed..dule.js gzip 6.07 kB 6.07 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.6 kB 52.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js test/update-err-tests Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js test/update-err-tests Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary ijjk/next.js test/update-err-tests Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js test/update-err-tests Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 651 B 651 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js test/update-err-tests Change
index.html gzip 1 kB 1 kB
link.html gzip 1.01 kB 1.01 kB
withRouter.html gzip 994 B 994 B
Overall change 3 kB 3 kB

Serverless Mode
General
vercel/next.js canary ijjk/next.js test/update-err-tests Change
buildDuration 15.5s 15.6s ⚠️ +90ms
nodeModulesSize 57 MB 57 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js test/update-err-tests Change
677f882d2ed8..68c9.js gzip 10.9 kB 10.9 kB
framework.HASH.js gzip 39 kB 39 kB
main-7ae8495..db56.js gzip 7 kB 7 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.6 kB 57.6 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js test/update-err-tests Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-5a735ed..dule.js gzip 6.07 kB 6.07 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.6 kB 52.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js test/update-err-tests Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js test/update-err-tests Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary ijjk/next.js test/update-err-tests Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js test/update-err-tests Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 651 B 651 B
Serverless bundles
vercel/next.js canary ijjk/next.js test/update-err-tests Change
_error.js 1.03 MB 1.03 MB
404.html 4.34 kB 4.34 kB
hooks.html 3.92 kB 3.92 kB
index.js 1.04 MB 1.04 MB
link.js 1.08 MB 1.08 MB
routerDirect.js 1.07 MB 1.07 MB
withRouter.js 1.07 MB 1.07 MB
Overall change 5.31 MB 5.31 MB
Commit: 81a8d76

@kodiakhq kodiakhq bot merged commit 8ecc359 into vercel:canary Sep 11, 2020
@Timer Timer deleted the test/update-err-tests branch September 11, 2020 15:29
HitoriSensei pushed a commit to HitoriSensei/next.js that referenced this pull request Sep 26, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update client-nav rendering suite
2 participants