Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update next-google-analytics to work with .env files #16529

Merged
merged 6 commits into from
Aug 25, 2020
Merged

Update next-google-analytics to work with .env files #16529

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e9ef315
Make ga client work with .env vars
jaredpalmer Aug 24, 2020
02519a5
Update document-head-tags-server.js
jaredpalmer Aug 24, 2020
dd3bf95
Change required env name in pkg.json
jaredpalmer Aug 24, 2020
58452d0
Fix linter errors
jaredpalmer Aug 24, 2020
c27d216
Remove old references cuz only one is requirable
jaredpalmer Aug 24, 2020
571ef8e
Merge branch 'canary' into patch-2
kodiakhq[bot] Aug 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/next-plugin-google-analytics/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"nextjs": {
"name": "Google Analytics",
"required-env": [
"GA_TRACKING_ID"
"NEXT_PUBLIC_GA_TRACKING_ID"
]
},
"peerDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions packages/next-plugin-google-analytics/src/document-head-tags-server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@ export default async function headTags() {
<>
<script
async
src={`https://www.googletagmanager.com/gtag/js?id=${process.env.GA_TRACKING_ID}`}
src={`https://www.googletagmanager.com/gtag/js?id=${process.env.NEXT_PUBLIC_GA_TRACKING_ID}`}
/>
<script
dangerouslySetInnerHTML={{
__html: `
window.dataLayer = window.dataLayer || [];
function gtag(){dataLayer.push(arguments);}
gtag('js', new Date());
gtag('config', '${process.env.GA_TRACKING_ID}');
gtag('config', '${process.env.NEXT_PUBLIC_GA_TRACKING_ID}');
`,
}}
/>
Expand Down
2 changes: 1 addition & 1 deletion packages/next-plugin-google-analytics/src/on-init-client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
export default async function initClient({ router }) {
router.events.on('routeChangeComplete', (url) => {
setTimeout(() => {
window.gtag('config', process.env.GA_TRACKING_ID, {
window.gtag('config', process.env.NEXT_PUBLIC_GA_TRACKING_ID, {
page_location: url,
page_title: document.title,
})
Expand Down