Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix route in custom-server-koa example #14080

Merged
merged 4 commits into from
Jun 11, 2020
Merged

Fix route in custom-server-koa example #14080

merged 4 commits into from
Jun 11, 2020

Conversation

HyunSangHan
Copy link
Contributor

@HyunSangHan HyunSangHan commented Jun 11, 2020 •
edited
Loading

Links of the example about custom-server-koa were wrong, so I fixed them.

@ijjk ijjk added the examples Issue was opened via the examples template. label Jun 11, 2020
@ijjk
Copy link
Member

ijjk commented Jun 11, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
buildDuration 12.9s 12.7s -119ms
nodeModulesSize 64.9 MB 64.9 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.132 2.118 -0.01
/ avg req/sec 1172.74 1180.58 ⚠️ +7.84
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.244 1.312 ⚠️ +0.07
/error-in-render avg req/sec 2010.28 1904.93 -105.35
Client Bundles (main, webpack, commons)
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..0538.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
hooks.js gzip 881 B 881 B ✓
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
index.module.js gzip 223 B 223 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
_app.module.js gzip 604 B 604 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
_buildManifest.js gzip 270 B 270 B ✓
_buildManife..dule.js gzip 275 B 275 B ✓
Overall change 545 B 545 B ✓
Rendered Page Sizes
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
index.html gzip 954 B 954 B ✓
link.html gzip 961 B 961 B ✓
withRouter.html gzip 947 B 947 B ✓
Overall change 2.86 kB 2.86 kB ✓
Serverless Mode
General
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
buildDuration 13.9s 13.7s -181ms
nodeModulesSize 64.9 MB 64.9 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..0538.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
hooks.js gzip 881 B 881 B ✓
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
index.module.js gzip 223 B 223 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
_app.module.js gzip 604 B 604 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
_buildManifest.js gzip 270 B 270 B ✓
_buildManife..dule.js gzip 275 B 275 B ✓
Overall change 545 B 545 B ✓
Serverless bundles
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
_error.js 875 kB 875 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 875 kB 875 kB ✓
link.js 913 kB 913 kB ✓
routerDirect.js 905 kB 905 kB ✓
withRouter.js 905 kB 905 kB ✓
Overall change 4.48 MB 4.48 MB ✓

lfades
lfades approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ijjk
Copy link
Member

ijjk commented Jun 11, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
buildDuration 11.9s 12s ⚠️ +85ms
nodeModulesSize 64.9 MB 64.9 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.015 1.982 -0.03
/ avg req/sec 1240.68 1261.59 ⚠️ +20.91
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.199 1.129 -0.07
/error-in-render avg req/sec 2084.58 2213.85 ⚠️ +129.27
Client Bundles (main, webpack, commons)
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..0538.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
hooks.js gzip 881 B 881 B ✓
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
index.module.js gzip 223 B 223 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
_app.module.js gzip 604 B 604 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
_buildManifest.js gzip 270 B 270 B ✓
_buildManife..dule.js gzip 275 B 275 B ✓
Overall change 545 B 545 B ✓
Rendered Page Sizes
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
index.html gzip 954 B 954 B ✓
link.html gzip 961 B 961 B ✓
withRouter.html gzip 947 B 947 B ✓
Overall change 2.86 kB 2.86 kB ✓
Serverless Mode
General
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
buildDuration 13.1s 12.8s -230ms
nodeModulesSize 64.9 MB 64.9 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..0538.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
hooks.js gzip 881 B 881 B ✓
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
index.module.js gzip 223 B 223 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
_app.module.js gzip 604 B 604 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
_buildManifest.js gzip 270 B 270 B ✓
_buildManife..dule.js gzip 275 B 275 B ✓
Overall change 545 B 545 B ✓
Serverless bundles
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
_error.js 875 kB 875 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 875 kB 875 kB ✓
link.js 913 kB 913 kB ✓
routerDirect.js 905 kB 905 kB ✓
withRouter.js 905 kB 905 kB ✓
Overall change 4.48 MB 4.48 MB ✓

@ijjk
Copy link
Member

ijjk commented Jun 11, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
buildDuration 13.5s 13.2s -236ms
nodeModulesSize 64.9 MB 64.9 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.304 2.305 0
/ avg req/sec 1085.17 1084.6 -0.57
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.498 1.525 ⚠️ +0.03
/error-in-render avg req/sec 1669.15 1638.83 -30.32
Client Bundles (main, webpack, commons)
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..0538.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
hooks.js gzip 881 B 881 B ✓
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
index.module.js gzip 223 B 223 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
_app.module.js gzip 604 B 604 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
_buildManifest.js gzip 270 B 270 B ✓
_buildManife..dule.js gzip 275 B 275 B ✓
Overall change 545 B 545 B ✓
Rendered Page Sizes
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
index.html gzip 954 B 954 B ✓
link.html gzip 961 B 961 B ✓
withRouter.html gzip 947 B 947 B ✓
Overall change 2.86 kB 2.86 kB ✓
Serverless Mode
General
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
buildDuration 14.9s 14.9s ✓
nodeModulesSize 64.9 MB 64.9 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..0538.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
hooks.js gzip 881 B 881 B ✓
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
index.module.js gzip 223 B 223 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
_app.module.js gzip 604 B 604 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
_buildManifest.js gzip 270 B 270 B ✓
_buildManife..dule.js gzip 275 B 275 B ✓
Overall change 545 B 545 B ✓
Serverless bundles
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
_error.js 875 kB 875 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 875 kB 875 kB ✓
link.js 913 kB 913 kB ✓
routerDirect.js 905 kB 905 kB ✓
withRouter.js 905 kB 905 kB ✓
Overall change 4.48 MB 4.48 MB ✓

@ijjk
Copy link
Member

ijjk commented Jun 11, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
buildDuration 12.2s 12.4s ⚠️ +211ms
nodeModulesSize 64.9 MB 64.9 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.185 2.035 -0.15
/ avg req/sec 1144.06 1228.44 ⚠️ +84.38
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.39 1.399 ⚠️ +0.01
/error-in-render avg req/sec 1798.82 1786.8 -12.02
Client Bundles (main, webpack, commons)
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..0538.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
hooks.js gzip 881 B 881 B ✓
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
index.module.js gzip 223 B 223 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
_app.module.js gzip 604 B 604 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
_buildManifest.js gzip 270 B 270 B ✓
_buildManife..dule.js gzip 275 B 275 B ✓
Overall change 545 B 545 B ✓
Rendered Page Sizes
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
index.html gzip 954 B 954 B ✓
link.html gzip 961 B 961 B ✓
withRouter.html gzip 947 B 947 B ✓
Overall change 2.86 kB 2.86 kB ✓
Serverless Mode
General
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
buildDuration 13.6s 13.3s -291ms
nodeModulesSize 64.9 MB 64.9 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..0538.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
hooks.js gzip 881 B 881 B ✓
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
index.module.js gzip 223 B 223 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
_app.module.js gzip 604 B 604 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
_buildManifest.js gzip 270 B 270 B ✓
_buildManife..dule.js gzip 275 B 275 B ✓
Overall change 545 B 545 B ✓
Serverless bundles
vercel/next.js canary HyunSangHan/next.js fix-example-custom-server-koa Change
_error.js 875 kB 875 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 875 kB 875 kB ✓
link.js 913 kB 913 kB ✓
routerDirect.js 905 kB 905 kB ✓
withRouter.js 905 kB 905 kB ✓
Overall change 4.48 MB 4.48 MB ✓

@kodiakhq kodiakhq bot merged commit 7e1d174 into vercel:canary Jun 11, 2020
darshkpatel pushed a commit to MLH-Fellowship/next.js that referenced this pull request Jun 12, 2020
@HyunSangHan @darshkpatel
Fix route in custom-server-koa example (vercel#14080)
a26d523 
Links of the example about `custom-server-koa` were wrong, so I fixed them.
@HyunSangHan HyunSangHan deleted the fix-example-custom-server-koa branch June 13, 2020 01:07
@ndom91 ndom91 mentioned this pull request Jun 22, 2020
Closed
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@HyunSangHan @rokinsky
Fix route in custom-server-koa example (vercel#14080)
43bc56b 
Links of the example about `custom-server-koa` were wrong, so I fixed them.
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lfades lfades lfades approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HyunSangHan @ijjk @lfades