Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor change in hello-world/package.json #11830

Merged

Conversation

liulanz
Copy link
Contributor

@liulanz liulanz commented Apr 11, 2020

The "name" field in package.json doesn't match the example name.

@liulanz liulanz requested review from lfades and Timer as code owners April 11, 2020 17:19
@timneutkens timneutkens merged commit 287961e into vercel:canary Apr 11, 2020
@jamesmosier
Copy link
Contributor

FWIW I had a recent PR to change this to prefix it with nextjs- because codesandbox uses that for the name it displays as the official template. I felt it made it easier for newer users to find this template when searching the codesandbox templates.

#11550

@timneutkens
Copy link
Member

timneutkens commented Apr 14, 2020

@jamesmosier good catch, I forgot we did it because of that 👍 Reverted this PR.

liulanz added a commit to hunter-college-ossd-spr-2020/next.js that referenced this pull request Apr 14, 2020
@liulanz liulanz deleted the hello-word-package branch April 14, 2020 10:29
@liulanz
Copy link
Contributor Author

liulanz commented Apr 14, 2020

Thank you for pointing that out. I'm sorry for this unnecessary PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants