-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw when parsedUrl is not provided #1015
Conversation
cc @arunoda |
We should parse this. But we should throw if the user provided something other than a parsedUrl as the third argument. |
@arunoda This throws in all cases where |
If the parsedUrl is undefined or null, I need to do parse the URL ourselves. |
@arunoda fixed 🙌 |
server/index.js
Outdated
this.http = http.createServer(this.getRequestHandler()) | ||
const handle = this.getRequestHandler() | ||
this.http = http.createServer((req, res) => { | ||
const parsedUrl = parse(req.url, true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't need this line.
Thanks @timneutkens |
Fixes #990