Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible CDN cache corruption due to missing Next-Url in http vary #52745

Closed
1 task done
AkifumiSato opened this issue Jul 16, 2023 · 1 comment · Fixed by #52746
Closed
1 task done

Possible CDN cache corruption due to missing Next-Url in http vary #52745

AkifumiSato opened this issue Jul 16, 2023 · 1 comment · Fixed by #52746
Labels
bug Issue was opened via the bug report template. locked

Comments

@AkifumiSato
Copy link
Contributor

AkifumiSato commented Jul 16, 2023 •
edited
Loading

Verify canary release

  • I verified that the issue exists in the latest Next.js canary release

Provide environment information

Not environmentally dependent.

Which area(s) of Next.js are affected? (leave empty if unsure)

App Router

Link to the code that reproduces this issue or a replay of the bug

https://github.com/AkifumiSato/http-vary-has-not-next-url

To Reproduce

See response header in flight.

Describe the Bug

The Vary header must contain the header name that determines the use of cache.
The function of intercepting-routes changes the contents of the flight to be returned based on the Next-Url, but is not described in the http-vary.
This may cause unexpected caching behavior by the CDN.

Expected Behavior

Vary header Next-Url must be listed.

Which browser are you using? (if relevant)

No response

How are you deploying your application? (if relevant)

No response
@AkifumiSato AkifumiSato added the bug Issue was opened via the bug report template. label Jul 16, 2023
@AkifumiSato AkifumiSato changed the title Need Next-Url in http vary Possible CDN cache corruption due to missing Next-Url in http vary Jul 16, 2023
@AkifumiSato AkifumiSato mentioned this issue Jul 16, 2023
Merged
@kodiakhq kodiakhq bot closed this as completed in #52746 Jul 22, 2023
kodiakhq bot pushed a commit that referenced this issue Jul 22, 2023
@AkifumiSato @huozhi
fix: Add Next-Url to http vary in consideration of intercept routes. (
1494283 
#52746)

### Why

We calculate the “next url” depending on the router state and the previous router state so that when you navigate to a route, the proxy matches with that header and returns you the intercepted route if matching

### What 
- Fixes #52745




Co-authored-by: Jiachi Liu <[email protected]>
@github-actions
Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Issue was opened via the bug report template. locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Add Next-Url to http vary in consideration of intercept routes. AkifumiSato/next.js
1 participant
@AkifumiSato