Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: The example of open-graph image using external data to generate the image under JavaScript is missing #50141

Closed
xJkit opened this issue May 22, 2023 · 1 comment · Fixed by #50996
Labels
Documentation Related to Next.js' official documentation.

Comments

@xJkit
Copy link

xJkit commented May 22, 2023

What is the improvement or update you wish to see?

I would like to see more examples for the JavaScript version of open-graph image generation using external url or data source.

So far, the doc is okay under TypeScript version:


CleanShot 2023-05-22 at 11 44 14


However, When I switch to the JavaScript version, the example is missing like so:

CleanShot 2023-05-22 at 11 43 45


Is there any context that might help us understand?

All of the open-graph generation documentation is under App Router.
The missing example is JavaScript version.

Does the docs page already exist? Please link to it.

https://nextjs.org/docs/app/api-reference/file-conventions/metadata/opengraph-image#using-external-data

@xJkit xJkit added the Documentation Related to Next.js' official documentation. label May 22, 2023
@kodiakhq kodiakhq bot closed this as completed in #50996 Jun 8, 2023
kodiakhq bot pushed a commit that referenced this issue Jun 8, 2023
…50996)

Also changes JavaScript examples to use `.jsx` extensions so IDEs better recognize the JSX allowed as the first argument to `ImageResponse`. 

Fixes #50141
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2023

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation Related to Next.js' official documentation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant