404 if public/ filename contains a space

[rossdakin]

Bug report

Describe the bug

Static assets served from public/ result in 404 if they contain a space character.

Also true if the filename contains %20 rather than a space literal.

To Reproduce

Steps to reproduce the behavior, please provide code snippets or a repository:

1. mkdir test
2. cd test
3. npm init -y
4. npm install --save next react react-dom
5. mkdir pages public
6. echo "Foo" > public/hello.txt
7. echo "Foo" > public/hello\ world.txt
8. npx next

Expected behavior

curl http://localhost:3000/hello.txt → Foo
curl http://localhost:3000/hello\ world.txt → Foo
curl http://localhost:3000/hello%20world.txt → Foo

Actual behavior

curl http://localhost:3000/hello.txt → Foo
curl http://localhost:3000/hello\ world.txt → 404
curl http://localhost:3000/hello%20world.txt → 404

Screenshots

System information

• OS: macOS 10.15.2
• Browser: Chrome 79.0.3945.88
• Version of Next.js: 9.1.7

Additional context

Does't happen when serving from the deprecated static/ directory.

Have only tried with the next local dev server.

[Timer]

Related #9706

[alonre]

Not sure if we're doing anything wrong, but we're still getting this bug - we have an asset under /public with the @ character in it ([email protected]) and and when getting request for path/within/public/image%402x.png the server returns 404.
Would appreciate any clues, thanks.

[balazsorban44]

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.