Skip to content

Commit

Permalink
Skip webpack loader test in Turbopack (#60509)
Browse files Browse the repository at this point in the history
## What?

This test can be skipped as it checks a webpack loader. 

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->


Closes NEXT-2054
  • Loading branch information
timneutkens authored Jan 11, 2024
1 parent d8691f5 commit f06685f
Show file tree
Hide file tree
Showing 2 changed files with 82 additions and 74 deletions.
78 changes: 41 additions & 37 deletions test/development/acceptance-app/ReactRefreshRegression.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -335,56 +335,60 @@ describe('ReactRefreshRegression app', () => {
})

// https://github.com/vercel/next.js/issues/13574
test('custom loader mdx should have Fast Refresh enabled', async () => {
const files = new Map()
files.set(
'next.config.js',
outdent`
// Test is skipped with Turbopack as the package uses webpack loaders
;(process.env.TURBOPACK ? test.skip : test)(
'custom loader mdx should have Fast Refresh enabled',
async () => {
const files = new Map()
files.set(
'next.config.js',
outdent`
const withMDX = require("@next/mdx")({
extension: /\\.mdx?$/,
});
module.exports = withMDX({
pageExtensions: ["js", "mdx"],
});
`
)
files.set('app/content.mdx', `Hello World!`)
files.set(
'app/page.js',
outdent`
)
files.set('app/content.mdx', `Hello World!`)
files.set(
'app/page.js',
outdent`
'use client'
import MDX from './content.mdx'
export default function Page() {
return <div id="content"><MDX /></div>
}
`
)

const { session, cleanup } = await sandbox(next, files)
expect(
await session.evaluate(
() => document.querySelector('#content').textContent
)
).toBe('Hello World!')

let didNotReload = await session.patch('app/content.mdx', `Hello Foo!`)
expect(didNotReload).toBe(true)
expect(await session.hasRedbox(false)).toBe(false)
expect(
await session.evaluate(
() => document.querySelector('#content').textContent
)
).toBe('Hello Foo!')

didNotReload = await session.patch('app/content.mdx', `Hello Bar!`)
expect(didNotReload).toBe(true)
expect(await session.hasRedbox(false)).toBe(false)
expect(
await session.evaluate(
() => document.querySelector('#content').textContent
)
).toBe('Hello Bar!')

await cleanup()
})
const { session, cleanup } = await sandbox(next, files)
expect(
await session.evaluate(
() => document.querySelector('#content').textContent
)
).toBe('Hello World!')

let didNotReload = await session.patch('app/content.mdx', `Hello Foo!`)
expect(didNotReload).toBe(true)
expect(await session.hasRedbox(false)).toBe(false)
expect(
await session.evaluate(
() => document.querySelector('#content').textContent
)
).toBe('Hello Foo!')

didNotReload = await session.patch('app/content.mdx', `Hello Bar!`)
expect(didNotReload).toBe(true)
expect(await session.hasRedbox(false)).toBe(false)
expect(
await session.evaluate(
() => document.querySelector('#content').textContent
)
).toBe('Hello Bar!')

await cleanup()
}
)
})
78 changes: 41 additions & 37 deletions test/development/acceptance/ReactRefreshRegression.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -295,49 +295,53 @@ describe('ReactRefreshRegression', () => {
})

// https://github.com/vercel/next.js/issues/13574
test('custom loader (mdx) should have Fast Refresh enabled', async () => {
const { session, cleanup } = await sandbox(
next,
new Map([
[
'next.config.js',
outdent`
// Test is skipped with Turbopack as the package uses webpack loaders
;(process.env.TURBOPACK ? test.skip : test)(
'custom loader (mdx) should have Fast Refresh enabled',
async () => {
const { session, cleanup } = await sandbox(
next,
new Map([
[
'next.config.js',
outdent`
const withMDX = require("@next/mdx")({
extension: /\\.mdx?$/,
});
module.exports = withMDX({
pageExtensions: ["js", "mdx"],
});
`,
],
['pages/mdx.mdx', `Hello World!`],
]),
'/mdx'
)
expect(
await session.evaluate(
() => document.querySelector('#__next').textContent
],
['pages/mdx.mdx', `Hello World!`],
]),
'/mdx'
)
).toBe('Hello World!')

let didNotReload = await session.patch('pages/mdx.mdx', `Hello Foo!`)
expect(didNotReload).toBe(true)
expect(await session.hasRedbox(false)).toBe(false)
expect(
await session.evaluate(
() => document.querySelector('#__next').textContent
)
).toBe('Hello Foo!')

didNotReload = await session.patch('pages/mdx.mdx', `Hello Bar!`)
expect(didNotReload).toBe(true)
expect(await session.hasRedbox(false)).toBe(false)
expect(
await session.evaluate(
() => document.querySelector('#__next').textContent
)
).toBe('Hello Bar!')

await cleanup()
})
expect(
await session.evaluate(
() => document.querySelector('#__next').textContent
)
).toBe('Hello World!')

let didNotReload = await session.patch('pages/mdx.mdx', `Hello Foo!`)
expect(didNotReload).toBe(true)
expect(await session.hasRedbox(false)).toBe(false)
expect(
await session.evaluate(
() => document.querySelector('#__next').textContent
)
).toBe('Hello Foo!')

didNotReload = await session.patch('pages/mdx.mdx', `Hello Bar!`)
expect(didNotReload).toBe(true)
expect(await session.hasRedbox(false)).toBe(false)
expect(
await session.evaluate(
() => document.querySelector('#__next').textContent
)
).toBe('Hello Bar!')

await cleanup()
}
)
})

0 comments on commit f06685f

Please sign in to comment.