Skip to content

Commit

Permalink
wip
Browse files Browse the repository at this point in the history
  • Loading branch information
mischnic committed Dec 19, 2024
1 parent 9b0d8e4 commit ef12b9d
Showing 1 changed file with 16 additions and 14 deletions.
30 changes: 16 additions & 14 deletions turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use anyhow::Result;
use anyhow::{bail, Result};
use turbo_rcstr::RcStr;
use turbo_tasks::{FxIndexMap, ResolvedVc, ValueToString, Vc};
use turbo_tasks_hash::hash_xxh3_hash64;
Expand Down Expand Up @@ -57,19 +57,21 @@ impl ModuleIdStrategy for GlobalModuleIdStrategy {

// This shouldn't happen
// It means we missed something when generating the map
ModuleIssue {
ident: ident.to_resolved().await?,
title: StyledString::Text(
format!("ModuleId not found for ident: {:?}", ident_string).into(),
)
.resolved_cell(),
description: StyledString::Text(
format!("ModuleId not found for ident: {:?}", ident_string).into(),
)
.resolved_cell(),
}
.resolved_cell()
.emit();
println!("ModuleId not found for ident: {:?}", ident_string);
bail!("ModuleId not found for ident: {:?}", ident_string);
// ModuleIssue {
// ident: ident.to_resolved().await?,
// title: StyledString::Text(
// format!("ModuleId not found for ident: {:?}", ident_string).into(),
// )
// .resolved_cell(),
// description: StyledString::Text(
// format!("ModuleId not found for ident: {:?}", ident_string).into(),
// )
// .resolved_cell(),
// }
// .resolved_cell()
// .emit();

Ok(ModuleId::String(

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / stable - x86_64-unknown-linux-gnu - node@16

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / build / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test devlow package / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / build-native / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test unit (18) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / types and precompiled / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / Test new tests for flakes (dev) (2/5) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / Test new tests for flakes (dev) (4/5) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / Test new tests for flakes (dev) (3/5) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / Test new tests for flakes (dev) (5/5) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / rustdoc check / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test ppr integration / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / Test new tests for flakes (prod) (3/5) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / Test new tests for flakes (prod) (2/5) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / Test new tests for flakes (prod) (4/5) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / Test new tests for flakes (prod) (5/5) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / Test new tests for flakes (dev) (1/5) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / lint / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / Run devlow benchmarks (--turbopack=true, --scenario=heavy-npm-deps-dev --page=homepage) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test next-swc wasm / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / rust check / build

unreachable expression

Check failure on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / rust check / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / Run devlow benchmarks (--turbopack=false, --scenario=heavy-npm-deps-dev --page=homepage) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / Run devlow benchmarks (--turbopack=false, --scenario=heavy-npm-deps-build-turbo-cache-enabled --p... / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / Run devlow benchmarks (--turbopack=true, --scenario=heavy-npm-deps-build-turbo-cache-enabled --pa... / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test turbopack production (4/7) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / Test new tests for flakes (prod) (1/5) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test unit (20) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test integration (12/13) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test integration (4/13) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test integration (6/13) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test turbopack development integration (4/6) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test turbopack development integration (5/6) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test integration (3/13) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test firefox and safari / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test integration (13/13) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test turbopack development integration (2/6) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test turbopack production (2/7) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test turbopack development integration (6/6) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test turbopack development integration (3/6) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test cargo benches / Test

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test cargo benches / Test

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test integration (8/13) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test integration (7/13) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / Run devlow benchmarks (--turbopack=true, --scenario=heavy-npm-deps-build --page=homepage) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test integration (10/13) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test cargo unit / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / Run devlow benchmarks (--turbopack=false, --scenario=heavy-npm-deps-build --page=homepage) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test integration (2/13) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test turbopack production integration (6/7) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test ppr dev (2/6) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test integration (11/13) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test dev (4/6) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test turbopack production integration (5/7) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test turbopack dev (1/5) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test integration (1/13) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test dev (3/6) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test turbopack production integration (2/7) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test dev (5/6) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test integration (9/13) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test turbopack production integration (1/7) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test turbopack dev (3/5) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test turbopack production integration (3/7) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test ppr dev (6/6) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test turbopack dev (2/5) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test turbopack dev (4/5) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test ppr dev (4/6) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test ppr dev (3/6) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test ppr prod (6/7) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test ppr prod (1/7) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test ppr prod (5/7) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test turbopack production (3/7) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test turbopack production (1/7) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test dev (6/6) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test turbopack production (7/7) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test integration (5/13) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test ppr dev (1/6) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test ppr prod (3/7) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test prod (2/7) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test ppr dev (5/6) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test ppr prod (4/7) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test turbopack development integration (1/6) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test prod (6/7) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test prod (1/7) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test dev (2/6) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test turbopack dev (5/5) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test prod (7/7) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test turbopack production integration (7/7) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test turbopack production integration (4/7) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test ppr prod (7/7) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test prod (5/7) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test dev (1/6) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test prod (4/7) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test ppr prod (2/7) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test turbopack production (5/7) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test turbopack production (6/7) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / test prod (3/7) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / Test new tests when deployed (5/5) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / Test new tests when deployed (4/5) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / Test new tests when deployed (3/5) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / Test new tests when deployed (1/5) / build

unreachable expression

Check warning on line 76 in turbopack/crates/turbopack-core/src/chunk/module_id_strategies.rs

View workflow job for this annotation

GitHub Actions / Test new tests when deployed (2/5) / build

unreachable expression
hash_xxh3_hash64(ident.to_string().await?)
Expand Down

0 comments on commit ef12b9d

Please sign in to comment.