Skip to content

Commit

Permalink
chore: remove replay from issue template (#55397)
Browse files Browse the repository at this point in the history
### What?

Removes Replay.io as a valid reproduction link from our bug template.

### Why?

Based on issues #55181 and #55278 it looks like people are struggling to report the correct thing. Also, without source maps, replays are still harder to use for debugging than an actual code base

Ref: [Slack thread](https://vercel.slack.com/archives/C04DUD7EB1B/p1694608481515339?thread_ts=1694428848.689079&cid=C04DUD7EB1B)
  • Loading branch information
balazsorban44 authored Sep 18, 2023
1 parent 36e12a7 commit c6c3891
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 11 deletions.
4 changes: 1 addition & 3 deletions .github/ISSUE_TEMPLATE/1.bug_report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,10 @@ body:
- Ask a question on the [Next.js Discord](https://discord.com/invite/nextjs) server
- type: input
attributes:
label: Link to the code that reproduces this issue or a replay of the bug
label: Link to the code that reproduces this issue
description: |
A link to a **public** [GitHub repository](https://github.com/vercel/next.js/tree/canary/examples/reproduction-template) or a [CodeSandbox](https://codesandbox.io/p/sandbox/github/vercel/next.js/tree/canary/examples/reproduction-template) minimal reproduction. Minimal reproductions should be created from our [bug report template with `npx create-next-app -e reproduction-template`](https://github.com/vercel/next.js/tree/canary/examples/reproduction-template) and should include only changes that contribute to the issue. To report a Pages Router related issue, you can use these templates: [`npx create-next-app -e reproduction-template-pages`](https://github.com/vercel/next.js/tree/canary/examples/reproduction-template-pages) or [CodeSandbox](https://codesandbox.io/p/sandbox/github/vercel/next.js/tree/canary/examples/reproduction-template-pages)
If a minimal reproduction can't be created, please share a [replay](https://www.replay.io/) of the bug which doesn't require sharing a private repo.
**Skipping this/providing an invalid link will result in the issue being closed**
placeholder: 'https://github.com/user/my-minimal-nextjs-issue-reproduction'
validations:
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/issue-validator/repro-link/index.mjs

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion .github/actions/issue-validator/repro-link/invalid-link.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ We could not detect a valid reproduction link. **Make sure to follow the bug rep

To be able to investigate, we need access to a reproduction to identify what triggered the issue. We need a link to a **public** GitHub repository ([template for App Router](https://github.com/vercel/next.js/tree/canary/examples/reproduction-template), [template for Pages Router](https://github.com/vercel/next.js/tree/canary/examples/reproduction-template-pages)), but you can also use these templates: [CodeSandbox: App Router](https://codesandbox.io/s/github/vercel/next.js/tree/canary/examples/reproduction-template) or [CodeSandbox: Pages Router](https://codesandbox.io/s/github/vercel/next.js/tree/canary/examples/reproduction-template-pages).

The bug template that you filled out has a section called "Link to the code that reproduces this issue or a replay of the bug", which is where you should provide the link to the reproduction.
The bug template that you filled out has a section called "Link to the code that reproduces this issue", which is where you should provide the link to the reproduction.

- If you did not provide a link or the link you provided is not valid, we will close the issue.
- If you provide a link to a private repository, we will close the issue.
Expand Down
8 changes: 2 additions & 6 deletions .github/actions/issue-validator/src/repro-link.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ async function run() {

// https://github.com/vercel/next.js/blob/canary/.github/ISSUE_TEMPLATE/1.bug_report.yml?plain=1

const start =
'### Link to the code that reproduces this issue or a replay of the bug'
const start = '### Link to the code that reproduces this issue'
const end = '### To Reproduce'
const linkRe = new RegExp(`${start}(.*)${end}`, 'is')
const match = issue_body.match(linkRe)?.[1]?.trim()
Expand Down Expand Up @@ -78,10 +77,7 @@ async function hasRepro(link) {
if (!link) return false
try {
const url = new URL(link)
if (
!['github.com', 'codesandbox.io', 'app.replay.io'].includes(url.hostname)
)
return false
if (!['github.com', 'codesandbox.io'].includes(url.hostname)) return false
const { status } = await fetch(link)
// Verify that it's not a private repo/sandbox
// We allow 500, in case it's downtime on one of the services
Expand Down

0 comments on commit c6c3891

Please sign in to comment.