Skip to content

Commit

Permalink
refactor: added more strict app segment config validation (#70480)
Browse files Browse the repository at this point in the history
<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->


This increases the strictness that Next.js uses while parsing
configuration from applications as well as removing some legacy options
(in preparation for Next.js 15).

- Errors are now printing to the console while parsing app route segment
configuration, improving the reliability of the parsed configuration
- **Breaking** Pages and routes in App Router will no long support
`export const runtime = "experimental-edge"`, they will be required to
switch to `export const runtime = "edge"`. They were the same here
anyways but this stabilizes it.
- Enables the possibility of parsing the configuration values from
client component files via direct AST traversal.
  • Loading branch information
wyattjoh authored Oct 4, 2024
1 parent 7474f10 commit a20f750
Show file tree
Hide file tree
Showing 36 changed files with 898 additions and 624 deletions.
3 changes: 2 additions & 1 deletion packages/next/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,8 @@
"webpack-sources1": "npm:[email protected]",
"webpack-sources3": "npm:[email protected]",
"ws": "8.2.3",
"zod": "3.22.3"
"zod": "3.22.3",
"zod-validation-error": "3.4.0"
},
"keywords": [
"react",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
/* eslint-env jest */
import { getMiddlewareMatchers } from 'next/dist/build/analysis/get-page-static-info'
import { getMiddlewareMatchers } from './get-page-static-info'

describe('get-page-static-infos', () => {
describe('getMiddlewareMatchers', () => {
Expand Down
Loading

0 comments on commit a20f750

Please sign in to comment.