warn on sync access if dynamicIO is not enabled

vercel · Oct 23, 2024 · a0aeba5 · a0aeba5
1 parent c1cfee3
commit a0aeba5
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 8 deletions.
diff --git a/...deduped-by-callsite-server-error-loger.ts → ...eduped-by-callsite-server-error-logger.ts b/...deduped-by-callsite-server-error-loger.ts → ...eduped-by-callsite-server-error-logger.ts
@@ -8,13 +8,20 @@ const cache =
     ? React.cache
     : (fn: (key: unknown) => void) => fn
 
+// When Dynamic IO is enabled, we record these as errors so that they
+// are captured by the dev overlay as it's more critical to fix these
+// when enabled.
+const logErrorOrWarn = process.env.__NEXT_DYNAMIC_IO
+  ? console.error
+  : console.warn
+
 // We don't want to dedupe across requests.
 // The developer might've just attempted to fix the warning so we should warn again if it still happens.
 const flushCurrentErrorIfNew = cache(
   // eslint-disable-next-line @typescript-eslint/no-unused-vars -- cache key
   (key: unknown) => {
     try {
-      console.error(errorRef.current)
+      logErrorOrWarn(errorRef.current)
     } finally {
       errorRef.current = null
     }
@@ -41,7 +48,7 @@ export function createDedupedByCallsiteServerErrorLoggerDev<Args extends any[]>(
     if (process.env.NODE_ENV !== 'production') {
       const callStackFrames = new Error().stack?.split('\n')
       if (callStackFrames === undefined || callStackFrames.length < 4) {
-        console.error(message)
+        logErrorOrWarn(message)
       } else {
         // Error:
         //   logDedupedError
@@ -53,7 +60,7 @@ export function createDedupedByCallsiteServerErrorLoggerDev<Args extends any[]>(
         flushCurrentErrorIfNew(key)
       }
     } else {
-      console.error(message)
+      logErrorOrWarn(message)
     }
   }
 }
diff --git a/packages/next/src/server/request/cookies.ts b/packages/next/src/server/request/cookies.ts
@@ -20,7 +20,7 @@ import {
 import { getExpectedRequestStore } from '../app-render/work-unit-async-storage.external'
 import { StaticGenBailoutError } from '../../client/components/static-generation-bailout'
 import { makeHangingPromise } from '../dynamic-rendering-utils'
-import { createDedupedByCallsiteServerErrorLoggerDev } from '../create-deduped-by-callsite-server-error-loger'
+import { createDedupedByCallsiteServerErrorLoggerDev } from '../create-deduped-by-callsite-server-error-logger'
 import { scheduleImmediate } from '../../lib/scheduler'
 
 /**

diff --git a/packages/next/src/server/request/draft-mode.ts b/packages/next/src/server/request/draft-mode.ts
@@ -9,7 +9,7 @@ import {
   postponeWithTracking,
   trackSynchronousRequestDataAccessInDev,
 } from '../app-render/dynamic-rendering'
-import { createDedupedByCallsiteServerErrorLoggerDev } from '../create-deduped-by-callsite-server-error-loger'
+import { createDedupedByCallsiteServerErrorLoggerDev } from '../create-deduped-by-callsite-server-error-logger'
 import { StaticGenBailoutError } from '../../client/components/static-generation-bailout'
 import { DynamicServerError } from '../../client/components/hooks-server-context'
 

diff --git a/packages/next/src/server/request/headers.ts b/packages/next/src/server/request/headers.ts
@@ -17,7 +17,7 @@ import {
 } from '../app-render/dynamic-rendering'
 import { StaticGenBailoutError } from '../../client/components/static-generation-bailout'
 import { makeHangingPromise } from '../dynamic-rendering-utils'
-import { createDedupedByCallsiteServerErrorLoggerDev } from '../create-deduped-by-callsite-server-error-loger'
+import { createDedupedByCallsiteServerErrorLoggerDev } from '../create-deduped-by-callsite-server-error-logger'
 import { scheduleImmediate } from '../../lib/scheduler'
 
 /**

diff --git a/packages/next/src/server/request/params.ts b/packages/next/src/server/request/params.ts
@@ -19,7 +19,7 @@ import {
 import { InvariantError } from '../../shared/lib/invariant-error'
 import { describeStringPropertyAccess, wellKnownProperties } from './utils'
 import { makeHangingPromise } from '../dynamic-rendering-utils'
-import { createDedupedByCallsiteServerErrorLoggerDev } from '../create-deduped-by-callsite-server-error-loger'
+import { createDedupedByCallsiteServerErrorLoggerDev } from '../create-deduped-by-callsite-server-error-logger'
 import { scheduleImmediate } from '../../lib/scheduler'
 
 export type Params = Record<string, string | Array<string> | undefined>

diff --git a/packages/next/src/server/request/search-params.ts b/packages/next/src/server/request/search-params.ts
@@ -19,7 +19,7 @@ import {
 } from '../app-render/work-unit-async-storage.external'
 import { InvariantError } from '../../shared/lib/invariant-error'
 import { makeHangingPromise } from '../dynamic-rendering-utils'
-import { createDedupedByCallsiteServerErrorLoggerDev } from '../create-deduped-by-callsite-server-error-loger'
+import { createDedupedByCallsiteServerErrorLoggerDev } from '../create-deduped-by-callsite-server-error-logger'
 import {
   describeStringPropertyAccess,
   describeHasCheckingStringProperty,