Reenable app-static usePathname tests (#55065)

Re-enable `usePathname` related tests Closes NEXT-112
vercel · Sep 8, 2023 · 6ffb8da · 6ffb8da
1 parent 56eeedf
commit 6ffb8da
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 15 deletions.
diff --git a/test/e2e/app-dir/app-static/app-static.test.ts b/test/e2e/app-dir/app-static/app-static.test.ts
@@ -2263,7 +2263,7 @@ createNextDescribe(
             )
             const html = await res.text()
 
-            // Shouild not bail out to client rendering
+            // Should not bail out to client rendering
             expect(html).not.toInclude('<p>search params suspense</p>')
 
             // Use empty search params instead
@@ -2277,17 +2277,11 @@ createNextDescribe(
       }
     })
 
-    // TODO: needs updating as usePathname should not bail
-    describe.skip('usePathname', () => {
-      if (isDev) {
-        it('should bail out to client rendering during SSG', async () => {
-          const res = await next.fetch('/hooks/use-pathname/slug')
-          const html = await res.text()
-          expect(html).toInclude('<html id="__next_error__">')
-        })
-      }
-
+    describe('usePathname', () => {
       it('should have the correct values', async () => {
+        const $ = await next.render$('/hooks/use-pathname/slug')
+        expect($('#pathname').text()).toContain('/hooks/use-pathname/slug')
+
         const browser = await next.browser('/hooks/use-pathname/slug')
 
         expect(await browser.elementByCss('#pathname').text()).toBe(

diff --git a/test/e2e/app-dir/app-static/next.config.js b/test/e2e/app-dir/app-static/next.config.js
@@ -11,10 +11,6 @@ module.exports = {
     return {
       // beforeFiles: [ { source: '/assets/:path*', destination: '/:path*' } ],
       afterFiles: [
-        {
-          source: '/rewritten-to-dashboard',
-          destination: '/dashboard',
-        },
         {
           source: '/rewritten-use-search-params',
           destination: '/hooks/use-search-params',