Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #57 in statically analyzing
require('bindings')
andrequire('node-pre-gyp').find
loads and handling them as asset relocations.Cases supported:
import binary from 'node-pre-gyp'; binary.find(__dirname + 'package.json')
(plusimport *
variant)require('bindings')('asdf')
var bindings = require('bindings'); bindings('asdf')
This should be merged with the other PRs, so will rebase depending on what order the merges happen.
Because of the issue with architecture matching, I originally wanted to enable this specifically behind a "binary" flag, but since the default case is then effectively for binaries just not to work, I've left this out for now.