Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary require support #85

Merged
merged 1 commit into from
Dec 3, 2018
Merged

Binary require support #85

merged 1 commit into from
Dec 3, 2018

Conversation

guybedford
Copy link
Contributor

This implements the simple case of (3) in #57.

Thanks @TooTallNate for the suggestions on this one - was exactly as you described and using a similar approach to node-native-loader.

@guybedford
Copy link
Contributor Author

This also fixes another bug where asset name deduping was not being shared between modules, which should resolve #65.

@guybedford guybedford force-pushed the binary-require branch 4 times, most recently from 4e79584 to 7dbc910 Compare November 30, 2018 16:32
@codecov-io
Copy link

codecov-io commented Nov 30, 2018

Codecov Report

Merging #85 into master will decrease coverage by 1.24%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
- Coverage   70.85%   69.61%   -1.25%     
==========================================
  Files           4        5       +1     
  Lines         326      283      -43     
==========================================
- Hits          231      197      -34     
+ Misses         95       86       -9
Impacted Files Coverage Δ
src/loaders/relocate-loader.js 99.19% <100%> (ø)
src/loaders/node-loader.js 100% <100%> (ø)
src/utils/dedupe-names.js 100% <100%> (ø)
src/index.js 91.52% <100%> (+0.14%) ⬆️
src/cli.js 0% <0%> (ø) ⬆️
src/sourcemap-register.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ade601...1239e0a. Read the comment docs.

@rauchg
Copy link
Member

rauchg commented Dec 1, 2018

@guybedford has conflicts

@guybedford
Copy link
Contributor Author

Rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants