feat: bump to [email protected] #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
reviewed
Nov 8, 2021
| @@ -101,7 +101,6 @@ it('Should support custom watch API', async () => { | |||
| await new Promise((resolve, reject) => { | |||
| const watcher = new CustomWatchFileSystem(function watchStart (files, dirs, missing) { | |||
| expect(files._set.size).toBeGreaterThan(100); | |||
| expect(missing._set.size).toBeGreaterThan(40); | |||
There was a problem hiding this comment.
I found it unlikely to be useful.
As seen in earlier commit, 1bd2aac#diff-b886328ab4b91304e8f0ff17323f05d868c3f83cbb0a6c492f362fdedcd70f96, the line was changed to accommodate the new version of webpack.
There was a problem hiding this comment.
@guybedford Thoughts on this? I'm fine with removing it.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: #805, webpack/webpack#14532