Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interop test case #667

Merged
merged 3 commits into from
Mar 19, 2021
Merged

Interop test case #667

merged 3 commits into from
Mar 19, 2021

Conversation

guybedford
Copy link
Contributor

This is a failing test case for one of the few of the remaining module interop cases that is different between Webpack and Node.js.

I'm hopeful we can get an upstream fix for this in Webpack in some form.

@styfle styfle requested a review from sokra March 19, 2021 14:14
@guybedford
Copy link
Contributor Author

It turns out I spoke too soon here and @sokra has done some amazing work smoothing these edge cases (also per https://sokra.github.io/interop-test/).

As long as we are in the strict interop mode for Webpack there is full Node.js compat on the API patterns now.

@styfle styfle added the automerge Automatically merge PR once checks pass label Mar 19, 2021
@kodiakhq kodiakhq bot merged commit 8f25102 into master Mar 19, 2021
@kodiakhq kodiakhq bot deleted the interop branch March 19, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants