-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create hello-world example #153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌺
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
======================================
Coverage 72.3% 72.3%
======================================
Files 10 10
Lines 473 473
======================================
Hits 342 342
Misses 131 131 Continue to review full report at Codecov.
|
@rauchg addressed your comments. Here are examples of running the npm scripts from the |
Thanks @macklinu |
@rauchg this should be a good for another review - apologies for not sending a comment after my latest commit to communicate that more clearly. Let me know if I can help out without anything else on this PR. Will keep contributing example PRs if we like the start of this format. 👍 (This PR is also good to be squashed and merged unless you'd like me to squash/rebase it manually.) |
Awesome @macklinu ! Next step would be to show off an example of using |
This is a start at #50. The main goal of this PR is to figure out the primary structure for an example directory (README.md structure, how to install
@zeit/ncc
, how to communicate which commands to run, etc.) so that it becomes easier to add other examples moving forward. Feedback welcome (inline comments incoming)!