Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create hello-world example #153

Merged
merged 3 commits into from
Dec 21, 2018
Merged

Create hello-world example #153

merged 3 commits into from
Dec 21, 2018

Conversation

macklinu
Copy link
Contributor

This is a start at #50. The main goal of this PR is to figure out the primary structure for an example directory (README.md structure, how to install @zeit/ncc, how to communicate which commands to run, etc.) so that it becomes easier to add other examples moving forward. Feedback welcome (inline comments incoming)!

Copy link
Contributor Author

@macklinu macklinu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌺

examples/hello-world/index.js Outdated Show resolved Hide resolved
examples/hello-world/package.json Outdated Show resolved Hide resolved
examples/hello-world/README.md Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Dec 14, 2018

Codecov Report

Merging #153 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #153   +/-   ##
======================================
  Coverage    72.3%   72.3%           
======================================
  Files          10      10           
  Lines         473     473           
======================================
  Hits          342     342           
  Misses        131     131

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7bc7a0...de48c58. Read the comment docs.

@macklinu
Copy link
Contributor Author

@rauchg addressed your comments. Here are examples of running the npm scripts from the examples/hello-world directory:

image

image

@rauchg
Copy link
Member

rauchg commented Dec 16, 2018

Thanks @macklinu

@macklinu
Copy link
Contributor Author

@rauchg this should be a good for another review - apologies for not sending a comment after my latest commit to communicate that more clearly. Let me know if I can help out without anything else on this PR. Will keep contributing example PRs if we like the start of this format. 👍

(This PR is also good to be squashed and merged unless you'd like me to squash/rebase it manually.)

@rauchg rauchg merged commit c0a45d1 into vercel:master Dec 21, 2018
@rauchg
Copy link
Member

rauchg commented Dec 21, 2018

Awesome @macklinu ! Next step would be to show off an example of using arg and a CLI with subcommands, where each subcommand is a different bundle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants