Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pathToFileURL to handle windows file path #475

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use pathToFileURL to handle windows file path #475

wants to merge 1 commit into from
+3 −1

Conversation

t8g
Copy link

@t8g t8g commented Jan 14, 2023

Related to #474

Fix On Windows, absolute paths must be valid file:// URLs. Received protocol 'c:'

@leerob
Copy link
Member

leerob commented Jan 14, 2023

Could you add a test please?

@t8g
Copy link
Author

t8g commented Jan 16, 2023

The current tests are already failing on windows.
And the PR make them pass.
But I don't know how to emulate the error on non windows plateform.

@Marcel-G Marcel-G mentioned this pull request May 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t8g @leerob