Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't render italics #1460

Closed
2 tasks done
anrddh opened this issue Jan 28, 2017 · 23 comments
Closed
2 tasks done

Can't render italics #1460

anrddh opened this issue Jan 28, 2017 · 23 comments
Labels
help wanted Contributions wanted towards the issue 👆 Is Upstream Issue is the fault of something Hyper uses and not Hyper itself 🤯 Type: Compatibility Issue contains information about a compatibility issue in Hyper

Comments

@anrddh
Copy link

anrddh commented Jan 28, 2017

Issue

screen shot 2017-01-27 at 21 30 20

^ The same file in iTerm2:
screen shot 2017-01-27 at 21 31 03

The italics aren't rendering: HyperTerm renders the comments with a ugly grey background.

@timothyis timothyis added help wanted Contributions wanted towards the issue 🤯 Type: Compatibility Issue contains information about a compatibility issue in Hyper labels Feb 10, 2017
@audunolsen
Copy link

I too would like to see this addressed.

@albinekb
Copy link
Contributor

Is this still an issue in 2.0?

@albinekb albinekb added the 👀 Awaiting Response Issue or PR is awaiting a response from the author label Apr 19, 2018
@audunolsen
Copy link

It is. Currently using the font Menlo which has an italic set.

You can determine if a terminal supports italics by running this command:

echo -e "\e[3m foo \e[23m"

Hyper does not render italics, while Apple's terminal do.

screenshot 2018-04-19 12 27 40

@albinekb albinekb removed the 👀 Awaiting Response Issue or PR is awaiting a response from the author label Apr 19, 2018
@albinekb
Copy link
Contributor

Seems like xterm doesn't support italics, this is a screenshot from your test command in VS Code (that also uses xterm for rendering)
image

@albinekb
Copy link
Contributor

Upstream issue: xtermjs/xterm.js#580

@albinekb albinekb added the 👆 Is Upstream Issue is the fault of something Hyper uses and not Hyper itself label Apr 19, 2018
@flybayer
Copy link
Contributor

I just opened a pull request to xterm that adds support for italic! xtermjs/xterm.js#1422

@flybayer
Copy link
Contributor

flybayer commented May 5, 2018

xterm PR adding italic support has been merged! >> xtermjs/xterm.js#1422

@lyndsysimon
Copy link

Any idea when we'll see this in the release version of Hyper?

@lokesh-krishna
Copy link

Any update regarding this?

@lyndsysimon
Copy link

lyndsysimon commented Nov 5, 2018

@lokesh-krishna Well, it seems like the underlying issue was with xtermjs, not Hyper, and that the issue has a fix in place. The canary branch shows to be using a version of xtermjs with the fix included, but the lastest full release was 2.0.0, which doesn't include it.

If you want this to be applied through your OS's package manager, you'll have to wait for the 2.1.0 release to go live and your OS's repositories to update their version. Otherwise, you can download 2.1.0-canary.2 and it works today :)

ETA: Actually, you can modify your hyper.js to change your update channel to canary, and Hyper will update itself. If you download the canary version manually and don't change your hyper.js, it'll immediately download 2.0.0 again and prompt you to restart.

module.exports = {
  config: {
    updateChannel: 'canary',

@lokesh-krishna
Copy link

I just installed the 2.1.0-canary.2 release and tested italics support by entering echo -e "\e[3m foo \e[23m". The output was the same as earlier and not in italics. Does this require any additional configuration?

@oguzbilgic
Copy link

@lokesh-krishna were you able to solve the issue? I'm on v2.1 stable but italics are still not working

@lokesh-krishna
Copy link

I'm on 2.1.0-canary.3 now and even this version doesn't support italics.
So no, haven't been able to solve this.

@audunolsen
Copy link

This may be slightly off topic, but hyper now successfully displays italics (canary) for me — except in vim/neovim. I wonder if anyone is familiar with this? @anrddh You reported this with screenshots explicitly showing Neovim, has this resolved for you?

screenshot 2019-01-25 23 48 06

@jasonoverby
Copy link

@audunolsen I am experiencing the same issue where italics are present except for vim/neovim

@ntwb
Copy link

ntwb commented Mar 22, 2019

I just came looking to see if Hyper supported italics, it appears v2.1.2 is working for me:

Screen Shot 2019-03-22 at 5 30 54 pm

Above with the Input Mono font, below with Operator Mono font

Screen Shot 2019-03-22 at 5 33 27 pm

@audunolsen
Copy link

This may be slightly of topic for this issue, but I was able to resolve my own spesific problem; Vim and pretty much everything but Neovim was able to display italics. I wanted italics specifically for Neovim. I ran the following script which I was fortunate enough to stumble across. The script fixes the terminals' escape sequences for italics. This should probably be addressed by xterm, so this workaround can be avoided.

@jrieko
Copy link

jrieko commented Sep 3, 2019

Hyper 3.0.2 (stable) here, italics don't work, neither from echo -e "\e[3m foo \e[23m", or in vim.

I've tested with fonts Menlo and Ubuntu Mono, which do have an italic typeface.

@Stanzilla
Copy link
Contributor

Can you try with a CI build of current canary or maybe compile one yourself?

@thenerdlawyer
Copy link

i am having this issue with 3.02 stable and canary. Tried numerous fonts with italic typefaces including Input Mono, Menlo, and MesloLGS NF.

Running ubuntu on WLS

@yuntan
Copy link

yuntan commented Nov 26, 2019

I'm having this issue with 3.02 (stable) for both WebGL and Canvas renderer, and 3.1.0-canary.1 for Canvas renderer. I'm using Victor Mono font. I'd run echo -e "\e[3mitalic\e[23m" on WSL Ubuntu on Windows 10 (1909).

jrieko pushed a commit to jrieko/env-linux that referenced this issue Nov 30, 2019
- xterm.js implemented italic sequence, [hyper merged](vercel/hyper#1460)
- terminfo workaround still required
- re-enabled italics in vim
@ceoshikhar
Copy link

I'm having this issue with 3.02 (stable) for both WebGL and Canvas renderer, and 3.1.0-canary.1 for Canvas renderer. I'm using Victor Mono font. I'd run echo -e "\e[3mitalic\e[23m" on WSL Ubuntu on Windows 10 (1909).

Same here! did you find a fix?

@markpanado
Copy link

This may be slightly of topic for this issue, but I was able to resolve my own spesific problem; Vim and pretty much everything but Neovim was able to display italics. I wanted italics specifically for Neovim. I ran the following script which I was fortunate enough to stumble across. The script fixes the terminals' escape sequences for italics. This should probably be addressed by xterm, so this workaround can be avoided.

This solves my problem! Italics are now rendering with vim-gruvbox. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Contributions wanted towards the issue 👆 Is Upstream Issue is the fault of something Hyper uses and not Hyper itself 🤯 Type: Compatibility Issue contains information about a compatibility issue in Hyper
Projects
None yet
Development

No branches or pull requests