-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't render italics #1460
Comments
I too would like to see this addressed. |
Is this still an issue in 2.0? |
Upstream issue: xtermjs/xterm.js#580 |
I just opened a pull request to xterm that adds support for italic! xtermjs/xterm.js#1422 |
xterm PR adding italic support has been merged! >> xtermjs/xterm.js#1422 |
Any idea when we'll see this in the release version of Hyper? |
Any update regarding this? |
@lokesh-krishna Well, it seems like the underlying issue was with xtermjs, not Hyper, and that the issue has a fix in place. The If you want this to be applied through your OS's package manager, you'll have to wait for the 2.1.0 release to go live and your OS's repositories to update their version. Otherwise, you can download 2.1.0-canary.2 and it works today :) ETA: Actually, you can modify your
|
I just installed the 2.1.0-canary.2 release and tested italics support by entering |
@lokesh-krishna were you able to solve the issue? I'm on v2.1 stable but italics are still not working |
I'm on 2.1.0-canary.3 now and even this version doesn't support italics. |
This may be slightly off topic, but hyper now successfully displays italics (canary) for me — except in vim/neovim. I wonder if anyone is familiar with this? @anrddh You reported this with screenshots explicitly showing Neovim, has this resolved for you? |
@audunolsen I am experiencing the same issue where italics are present except for vim/neovim |
This may be slightly of topic for this issue, but I was able to resolve my own spesific problem; Vim and pretty much everything but Neovim was able to display italics. I wanted italics specifically for Neovim. I ran the following script which I was fortunate enough to stumble across. The script fixes the terminals' escape sequences for italics. This should probably be addressed by xterm, so this workaround can be avoided. |
Hyper 3.0.2 (stable) here, italics don't work, neither from I've tested with fonts Menlo and Ubuntu Mono, which do have an italic typeface. |
Can you try with a CI build of current canary or maybe compile one yourself? |
i am having this issue with 3.02 stable and canary. Tried numerous fonts with italic typefaces including Input Mono, Menlo, and MesloLGS NF. Running ubuntu on WLS |
I'm having this issue with 3.02 (stable) for both WebGL and Canvas renderer, and 3.1.0-canary.1 for Canvas renderer. I'm using Victor Mono font. I'd run |
- xterm.js implemented italic sequence, [hyper merged](vercel/hyper#1460) - terminfo workaround still required - re-enabled italics in vim
Same here! did you find a fix? |
This solves my problem! Italics are now rendering with vim-gruvbox. Thank you! |
I am on the latest Hyper.app version
I have searched the issues of this repo and believe that this is not a duplicate
OS version and name: macOS Sierra 10.12.2
Hyper.app version: 1.1.0
Link of a Gist with the contents of your .hyper.js: https://gist.github.com/awesomeaniruddh/7129bf3d86b515e139ec5b68ec4c57df
The issue is reproducible in vanilla Hyper.app: Yep
Issue
^ The same file in iTerm2:
The italics aren't rendering: HyperTerm renders the comments with a ugly grey background.
The text was updated successfully, but these errors were encountered: