Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mac] Dark mouse cursor is hard to see on dark background #1045

Open
2 tasks done
flowmemo opened this issue Nov 26, 2016 · 8 comments
Open
2 tasks done

[Mac] Dark mouse cursor is hard to see on dark background #1045

flowmemo opened this issue Nov 26, 2016 · 8 comments
Labels
help wanted Contributions wanted towards the issue 🍎 Platform: Mac Issue pertains to Mac 🎨 Type: Enhancement Issue or PR is an enhancement request/proposal for Hyper

Comments

@flowmemo
Copy link

flowmemo commented Nov 26, 2016

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: OS X 10.11.6
  • Hyper.app version: 0.8.3 (0.8.3.873)
  • The issue is reproducible in vanilla Hyper.app:

Issue

Hyper is cool! But I find the default mouse cursor of OS X is hard to see on dark background, especially when the screen is full of text.

screenshot

System-provided terminal and iTerm2 use custom image of mouse cursor like this:
d8e6e8a5d739406d33fc23d322e480cf-render
(source: https://github.com/gnachman/iTerm2/blob/master/images/IBarCursor-huge.psd)

@flowmemo
Copy link
Author

Some text editors like VS Code, Sublime Text have both white and black mouse cursor. They choose color against the background color of theme.

A temporary workaround is adding the following css into termCSS , which replace the original cursor with the white one in vscode.

 * { cursor: -webkit-image-set(url('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAQAAAC1+jfqAAAAL0lEQVQoz2NgCD3x//9/BhBYBWdhgFVAiVW4JBFKGIa4AqD0//9D3pt4I4tAdAMAHTQ/j5Zom30AAAAASUVORK5CYII=') 1x, url('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAQAAADZc7J/AAAAz0lEQVRIx2NgYGBY/R8I/vx5eelX3n82IJ9FxGf6tksvf/8FiTMQAcAGQMDvSwu09abffY8QYSAScNk45G198eX//yev73/4///701eh//kZSARckrNBRvz//+8+6ZohwCzjGNjdgQxkAg7B9WADeBjIBqtJCbhRA0YNoIkBSNmaPEMoNmA0FkYNoFKhapJ6FGyAH3nauaSmPfwI0v/3OukVi0CIZ+F25KrtYcx/CTIy0e+rC7R1Z4KMICVTQQ14feVXIbR695u14+Ir4gwAAD49E54wc1kWAAAAAElFTkSuQmCC') 2x) 5 8, text; }

(source:
https://github.com/Microsoft/vscode/blob/master/src/vs/editor/browser/viewParts/lines/viewLines.css#L45
microsoft/vscode#754 )

@moeriki
Copy link

moeriki commented Dec 14, 2016

Agreed. I use this to mostly have the default cursor.

    termCSS: `
      * {
        cursor: default;
      }
      x-row span {
        cursor: text;
      }
    `,

@dimitrieh
Copy link

iterm2 does this really well

@rianquinn
Copy link

The fix works, but this bug was really annoying.

@Stanzilla Stanzilla added 🎨 Type: Enhancement Issue or PR is an enhancement request/proposal for Hyper 🍎 Platform: Mac Issue pertains to Mac labels Apr 24, 2018
@Anand-Moghe
Copy link

Anand-Moghe commented May 14, 2018

The issue is with mouse pointer and not the terminal cursor. The termCSS fix is not working on my hyper.js terminal.

@albinekb albinekb added the help wanted Contributions wanted towards the issue label May 14, 2018
@scmx
Copy link

scmx commented Jun 20, 2018

The currently proposed solutions didn't work for me until I moved the rules to css: instead of termCSS:.

~/.hyper.js https://gist.github.com/scmx/42c1c4878caa45033eb2fe7d539db869

css: `
  .xterm {
    cursor: default;
  }
`,

(Hyper 2.0.0 Stable)

@chrismendis
Copy link

If you'd like to use the white cursor as mentioned in #1045 (comment), then this the configuration that worked for me:

    // custom css to embed in the main window
    css: `
      * { cursor: -webkit-image-set(url('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAQAAAC1+jfqAAAAL0lEQVQoz2NgCD3x//9/BhBYBWdhgFVAiVW4JBFKGIa4AqD0//9D3pt4I4tAdAMAHTQ/j5Zom30AAAAASUVORK5CYII=') 1x, url('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAQAAADZc7J/AAAAz0lEQVRIx2NgYGBY/R8I/vx5eelX3n82IJ9FxGf6tksvf/8FiTMQAcAGQMDvSwu09abffY8QYSAScNk45G198eX//yev73/4///701eh//kZSARckrNBRvz//+8+6ZohwCzjGNjdgQxkAg7B9WADeBjIBqtJCbhRA0YNoIkBSNmaPEMoNmA0FkYNoFKhapJ6FGyAH3nauaSmPfwI0v/3OukVi0CIZ+F25KrtYcx/CTIy0e+rC7R1Z4KMICVTQQ14feVXIbR695u14+Ir4gwAAD49E54wc1kWAAAAAElFTkSuQmCC') 2x) 5 8, text; }
    `,

@tanya355
Copy link

tanya355 commented May 18, 2020

If you'd like to use the white cursor as mentioned in #1045 (comment), then this the configuration that worked for me:

    // custom css to embed in the main window
    css: `
      * { cursor: -webkit-image-set(url('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAQAAAC1+jfqAAAAL0lEQVQoz2NgCD3x//9/BhBYBWdhgFVAiVW4JBFKGIa4AqD0//9D3pt4I4tAdAMAHTQ/j5Zom30AAAAASUVORK5CYII=') 1x, url('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAQAAADZc7J/AAAAz0lEQVRIx2NgYGBY/R8I/vx5eelX3n82IJ9FxGf6tksvf/8FiTMQAcAGQMDvSwu09abffY8QYSAScNk45G198eX//yev73/4///701eh//kZSARckrNBRvz//+8+6ZohwCzjGNjdgQxkAg7B9WADeBjIBqtJCbhRA0YNoIkBSNmaPEMoNmA0FkYNoFKhapJ6FGyAH3nauaSmPfwI0v/3OukVi0CIZ+F25KrtYcx/CTIy0e+rC7R1Z4KMICVTQQ14feVXIbR695u14+Ir4gwAAD49E54wc1kWAAAAAElFTkSuQmCC') 2x) 5 8, text; }
    `,

where would you have to add this code? im on a mac High Sierra and have the cursor visibility problem on vs code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Contributions wanted towards the issue 🍎 Platform: Mac Issue pertains to Mac 🎨 Type: Enhancement Issue or PR is an enhancement request/proposal for Hyper
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants