-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wrong Git clone command & package/tsconfig.json configuration #835
Open
TechQuery
wants to merge
4
commits into
vercel:main
Choose a base branch
from
TechQuery:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+32
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TechQuery
requested review from
okbel,
lfades,
goncy,
dominiksipowicz,
leerob and
lpalmes
as code owners
November 28, 2023 21:33
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@TechQuery is attempting to deploy a commit to the Vercel Examples Team on Vercel. A member of the Team first needs to authorize it. |
@ijjk @timneutkens @Timer Is there any Review Suggestion? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@vercel
Document bug
git clone
can't download a GitHub folder, so the command in this Example's ReadMe will throw error:A Node.js CLI tool
get-git-folder
is a good alternative.Configuration bug
If you run
vercel dev
in Node.js LTS (18+), and then callhttp://localhost:3000/api/hello
, it will throw an error:so, ESM is first choice for new Node.js projects.
But, TS with ESM will failed after deployment:
so, a
tsconfig.json
in/api
is required: vercel/vercel#10317 (comment)Finally, a Hello World of Vercel Node.js serverless works.
Type of Change