Support combined boolean flags #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 6, 2018 16:06
…of booleans (#11), add tests
…sure short argument keys are only one character, return boolean array instead of integer in boolean array key types, add tests
This commit adds support for combined boolean flags so that `-abc` will expand to `-a -b -c`. It also improves the logic of handling repeating boolean array flags like `-vvvv`. Both features now simply split the string into characters, and push them onto the argv array if they are have valid handlers. This avoids having more complex logic.
|
Very nice work @pacocoursey – wrote down some notes |
rauchg
reviewed
Dec 11, 2018
rauchg
reviewed
Dec 11, 2018
rauchg
reviewed
Dec 11, 2018
rauchg
reviewed
Dec 11, 2018
rauchg
reviewed
Dec 11, 2018
|
Awesome PR, thank you! 😊 Would you mind adding Codegov to the repo? Now CLI is a great example for this. Here's the badge: I added the You can find the Codecov page here. |
|
Having never used Codecov or CircleCI, I feel a little out of my depth. But there's my attempt anyways, based on the configs in Also added a |
|
In the future can we keep these as separate PRs? It's quickly become a kitchen sink of changes. |
Qix-
suggested changes
Dec 12, 2018
|
Superseded by #27. Thanks for all of the work, @pacocoursey :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request builds upon #14 and should be a major bump if merged.
I guess 14 can be closed? Not sure of the best way to build upon an open pull request and also introduce a new feature.
-abcdwill correctly be interpreted as-a -b -c -d.-abccwill be result in[true, true]if-cwas declared as a[Boolean].Also generally improves the logic so that it will be easier to add support for whatever comes out of #11.