Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Message annotations are compatible for any message type #959

Merged
merged 18 commits into from
Feb 9, 2024
Merged

fix: Message annotations are compatible for any message type #959

merged 18 commits into from
Feb 9, 2024

Conversation

nick-inkeep
Copy link
Contributor

@nick-inkeep nick-inkeep commented Feb 5, 2024 •
edited
Loading

Few updates/fixes:

  • resetting self.messageAnnotations after stream-part is encoded. Was causing issue when appendMessageAnnotation was used outside of onFinal. Was the root cause of message annotations are repeated #952.
  • made it so that annotations can be added to any message type, including function_call, not just text
  • added test cases to parse-complex-response.test.ts to account for the above
  • added example usage to the chat-with-functions page/route for the openai example

@nick-inkeep
adding message_data streaming part, appendToMessage, and parser
8fc58b6 
adding onEvent callback to ai-stream

fixing streaming part typo

removing onevent

adding optional event param to AIStreamParser

passing the extra arg in the transformer for event type
@nick-inkeep
renaming to annotations
9eec16a
@nick-inkeep
rename of messageData to messageAnnotations in stream parts and stram…
8592d8c 
… data
@nick-inkeep
updating to multi-array and adding test cases for parsing the complex…
7b54440 
… response
@nick-inkeep
putting event in the options param for customParser
9b849e3
@nick-inkeep
appendMessageAnnotations to appendMessageAnnotation
7e488d2
@nick-inkeep
changeset notes for message annotations
167c7a9
@nick-inkeep
prettier
00c9aa8
@nick-inkeep
resetting messageAnnotations once encoded in stream-data, ensuring me…
cbbae1d 
…ssage_annotations works for all Message types
@nick-inkeep
merging with main
d11df50
@nick-inkeep
removing text-message specific parser logic
8e6a205
@nick-inkeep
changeset
15dfd06
@nick-inkeep
changelog description
4769261
@nick-inkeep
all edge cases for parsing a message annotation
2d11829
@nick-inkeep
moving helper function to main module
5b9b941
@nick-inkeep nick-inkeep mentioned this pull request Feb 5, 2024
Merged
@nick-inkeep nick-inkeep changed the title Message annotations work for any message type Message annotations are compatible for any message type Feb 5, 2024
@nick-inkeep nick-inkeep changed the title Message annotations are compatible for any message type fix: Message annotations are compatible for any message type Feb 5, 2024
@nick-inkeep nick-inkeep mentioned this pull request Feb 6, 2024
Merged
nick-inkeep and others added 2 commits February 9, 2024 13:29
@nick-inkeep @MaxLeiter
Remove next-openai from patch
6a5c3c5 
Co-authored-by: Max Leiter <[email protected]>
@nick-inkeep @MaxLeiter
Spread boolean logic
4ad5ede 
Co-authored-by: Max Leiter <[email protected]>
@MaxLeiter MaxLeiter merged commit ed1e278 into vercel:main Feb 9, 2024
8 checks passed
@MaxLeiter
Copy link
Member

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxLeiter MaxLeiter MaxLeiter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nick-inkeep @MaxLeiter