Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect error code returned from go-cose Verifier instantiation #124

Closed
yogeshbdeshpande opened this issue Jan 27, 2023 · 1 comment
Closed

Incorrect error code returned from go-cose Verifier instantiation #124

yogeshbdeshpande opened this issue Jan 27, 2023 · 1 comment
Assignees
@yogeshbdeshpande
Milestone
v1.1.0

Comments

@yogeshbdeshpande
Copy link
Contributor

yogeshbdeshpande commented Jan 27, 2023 •
edited
Loading

File verifier.go, Interface Method: NewVerifier()
when switching on Algorithm and a correct algorithm is found, then it checks for ValidPublicKeys().

If the Public Key is not valid, it should return a suitable error code for not valid keys, instead the present code
returns ErrAlgorithmMistmatch, which is misleading!
@yogeshbdeshpande yogeshbdeshpande mentioned this issue Jan 27, 2023
Merged
@yogeshbdeshpande yogeshbdeshpande added this to the Future milestone Jan 27, 2023
@yogeshbdeshpande yogeshbdeshpande self-assigned this Jan 27, 2023
@yogeshbdeshpande
Copy link
Contributor Author

PR: #130
is used to address this issue

@SteveLasker SteveLasker modified the milestones: Future, v1.1.0 Feb 10, 2023
yogeshbdeshpande added a commit that referenced this issue Feb 10, 2023
@yogeshbdeshpande
Correct return error code when key cannot be decoded
eba8d14 
Fixes #124
Signed-off-by: Yogesh Deshpande <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yogeshbdeshpande yogeshbdeshpande

Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
2 participants
@SteveLasker @yogeshbdeshpande