Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeBSD: Support automatic detection and mounting of ext2/3/4, exFAT, NTFS filesystems #1350

Merged
merged 8 commits into from
Jun 3, 2024

Conversation

Jertzukka
Copy link
Contributor

Currently the mount implementation on FreeBSD does not support automatic filesystem detection on mount. We can alternatively use blkid which allows us to detect the filesystem that is contained on the virtual device before we attempt to mount the filesystem. The blkid program is part of the e2fsprogs package, which also provides the ext2/3/4 driver and is very likely to be installed on the user's system, if not, it will silently fail and behave like it has previously.

This patch adds support for automatic mounting of:

  • Ext2/3/4 (requires e2fsprogs)
  • exFAT via mount.exfat (requires fusefs-exfat)
  • NTFS via ntfs-3g (requires fusefs-ntfs)

Related: #576

Allows --filesystem=ext2/3/4 option to be used in CLI. In
CoreFreeBSD::MountFilesystem blkid is used in attempt to detect which
filesystem the device contains. If this is Ext, we change the chosen
filesystem to ext2fs. Similarly if specified filesystem through CLI
starts with Ext, we change the chosen filesystem to ext2fs.
Copy link
Member

@idrassi idrassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

query about src/Core/Unix/FreeBSD/CoreFreeBSD.cpp changes posted.

src/Core/Unix/FreeBSD/CoreFreeBSD.cpp Outdated Show resolved Hide resolved
@idrassi
Copy link
Member

idrassi commented Jun 3, 2024

Thank you for the quick update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants