Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise some cursed translations #1320

Closed
wants to merge 2 commits into from
Closed

Conversation

0x00000FF
Copy link

I saw some strings are translated in somehow cursed way, this need to be fixed.

and I think there are lots of things to be fixed.

Where can I see the english language pack for the reference?

@Jertzukka
Copy link
Contributor

You can find the default English translation strings here: https://github.com/veracrypt/VeraCrypt/blob/master/src/Common/Language.xml

Often single or couple of words in the translation string isn't enough to accertain what it means in the correct context, so it will help if you use the software and see where and how the translation is used in the program.

@0x00000FF
Copy link
Author

0x00000FF commented Mar 13, 2024

Alright, seems fine for now... as a korean.

Maybe this PR must be merged with #1291, he did very good work.

If there're any conflicts with it, it is better to follow his version.

@idrassi
Copy link
Member

idrassi commented Apr 10, 2024

@0x00000FF I have merged #1291 and so there is conflict with three entries in your PR (ASK_NONSYS_INPLACE_ENC_NOTIFICATION_REMOVAL, KEEP_PROMPTING_ME, DO_NOT_PROMPT_ME).

can you please remove the changes of these entries from your PR so that I can merge it.

Thank you for your contribution.

@0x00000FF
Copy link
Author

Well, It seems fine to close this PR because #1291 has been merged. Thank you!

@0x00000FF 0x00000FF closed this Apr 19, 2024
@0x00000FF 0x00000FF deleted the patch-1 branch April 19, 2024 02:28
@idrassi
Copy link
Member

idrassi commented Apr 19, 2024

You PR contained translations enhancements that were not covered by #1291. So, I have taken the liberty to push a commit containing your enhancements and of course I gave you credit in the commit message: 6d37bd6

Thank you again for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants