Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ERB deprecated warnings in Ruby 3 #53

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nivla
Copy link

@nivla nivla commented Jan 30, 2024

  • This PR fixes the following deprecated warnings:
    • Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead.
    • Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments

We're going to drop Ruby 2.5 from the CI matrix, right?

@nivla nivla self-assigned this Jan 30, 2024
@nivla nivla requested a review from a team January 30, 2024 19:34
@aharpervc
Copy link
Contributor

aharpervc commented Feb 13, 2024

We're going to drop Ruby 2.5 from the CI matrix, right?

Yes. Is this change safe for 2.7+ or do we need to do like "if ruby_version < 3"...? I see the CI jobs are passing, so I'm mainly asking about the deprecation notices for this code

@nivla
Copy link
Author

nivla commented Feb 15, 2024

Yes. Is this change safe for 2.7+ or do we need to do like "if ruby_version < 3"...? I see the CI jobs are passing, so I'm mainly asking about the deprecation notices for this code

Yes, this change is safe for 2.7+, the deprecation warning is no longer present on 2.7, we may need the 'if ruby_version <= 2.5' if we want to apps that use this gem and are still in 2.5.

@aharpervc
Copy link
Contributor

Can you rebase this & confirm it's ready for review? Putting back in draft mode for the moment, feel free to re-enable whenever you want

@aharpervc aharpervc marked this pull request as draft July 17, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants